[Bug 19383] New: [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Summary: [Monkey Island Special Edition] Version Hotswap does
                    not work
           Product: Wine
           Version: 1.1.26
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22463)
 --> (http://bugs.winehq.org/attachment.cgi?id=22463)
output of wine-1.1.26

Hello,
in monkey island special edition the version hotswap that should switch between
the old 90's design and the new one does not work.

F10 should activate the version hotswap ingame. But it seems that pressing F10
is just ignored. It also does not seem that the window manager has blocked that
key.

I am using Ubuntu 9.04 (amd64) and wine-1.1.26.

Attached is the output of wine. But it seems that nothing special is being
written if I press F10 ingame.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #1 from Christoph Korn   2009-07-20 09:49:24 ---
Created an attachment (id=22471)
 --> (http://bugs.winehq.org/attachment.cgi?id=22471)
+keyboard log of wine-1.1.26

Attached is the output of wine-1.1.26 with the keyboard debug channel enabled.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #2 from Christoph Korn   2009-07-20 09:51:05 ---
I pressed the F10 key (which should activate the version hotswap) ten times in
the game.

Each time I pressed it wine logs this:
trace:keyboard:X11DRV_KeyEvent XmbLookupString needs 0 byte(s)
trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010
trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010
trace:keyboard:X11DRV_ToUnicodeEx Found keycode 76 (0x4C)
trace:keyboard:X11DRV_ToUnicodeEx XmbLookupString needs 0 byte(s)
trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ffc7

While the output of xev when I press the F10 key is this:
KeyPress event, serial 33, synthetic NO, window 0x4200001,
    root 0x13c, subw 0x0, time 13716848, (73,-3), root:(156,113),
    state 0x10, keycode 76 (keysym 0xffc7, F10), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 33, synthetic NO, window 0x4200001,
    root 0x13c, subw 0x0, time 13716918, (73,-3), root:(156,113),
    state 0x10, keycode 76 (keysym 0xffc7, F10), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #3 from Christoph Korn   2009-07-20 09:55:43 ---
Hm, but a similar output occurs when I press F1 which successfully opens the
menu ingame.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Mikael Olsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Mikael Olsson   2009-07-20 12:57:02 ---
I'm running Fedora 11 and for me the version change keys are mapped to page up
and page down for some reason.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #5 from Christoph Korn   2009-07-20 13:19:43 ---
Oh, you are so right.

With the page up and down keys the version hotswap works perfectly.

Well, is this anyway a wine bug?
On my windows machine it is bound to F10 (like also the help ingame says).

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #6 from Dmitry Timoshkov   2009-07-21 01:09:30 ---
Please don't attach the logs if not been asked for.

Also you may want yo look at +event,+key,+msg log instead.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Christoph Korn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22463|0                           |1
        is obsolete|                            |
  Attachment #22471|0                           |1
        is obsolete|                            |

--- Comment #7 from Christoph Korn   2009-07-21 06:54:50 ---
Created an attachment (id=22497)
 --> (http://bugs.winehq.org/attachment.cgi?id=22497)
+event,+key,+msg log of wine-1.1.26

(In reply to comment #6)
> Please don't attach the logs if not been asked for.
>
> Also you may want yo look at +event,+key,+msg log instead.

Oh, sorry. Thought the log may be helpful.
I mark them as obsolete so.

Attached is now the proper log.

Looks like every time I press F10 there is something like this:
trace:event:call_event_handler KeyPress for hwnd/window 0x10030/4600005
trace:key:X11DRV_KeyEvent type 2, window 4600005, state 0x0010, keycode 0x004c
trace:key:X11DRV_KeyEvent nbyte = 0, status 0x3
trace:key:X11DRV_KeyEvent KeyPress : keysym=FFC7 (F10), # of chars=0 / ""
trace:key:EVENT_event_to_vkey e->keycode = 4c
trace:key:X11DRV_KeyEvent keycode 0x4c converted to vkey 0x79
trace:key:X11DRV_KeyEvent bScan = 0x44.
trace:key:X11DRV_send_keyboard_input  wParam=0079, lParam=00440001,
InputKeyState=40
trace:event:process_events processed 1 events
trace:msg:peek_message got type 7 msg 100 (WM_KEYDOWN) hwnd 0x10030 wp 79 lp
440001
trace:key:TranslateMessage Translating key VK_F10 (0079), scancode 44
trace:key:X11DRV_ToUnicodeEx (0079, 0044) : faked state = 0x0010
trace:key:EVENT_event_to_vkey e->keycode = 4c
trace:key:X11DRV_ToUnicodeEx type 2, window 4600005, state 0x0010, keycode
0x004c
trace:key:X11DRV_ToUnicodeEx nbyte = 0, status 0x3
trace:key:X11DRV_ToUnicodeEx KeyPress : keysym=FFC7 (F10), # of chars=0 / ""
trace:key:X11DRV_ToUnicodeEx returning 0 with L""

trace:event:call_event_handler KeyRelease for hwnd/window 0x10030/4600005
trace:key:X11DRV_KeyEvent type 3, window 4600005, state 0x0010, keycode 0x004c
trace:key:X11DRV_KeyEvent nbyte = 0, status 0x0
trace:key:X11DRV_KeyEvent KeyRelease : keysym=FFC7 (F10), # of chars=0 / ""
trace:key:EVENT_event_to_vkey e->keycode = 4c
trace:key:X11DRV_KeyEvent keycode 0x4c converted to vkey 0x79
trace:key:X11DRV_KeyEvent bScan = 0x44.
trace:key:X11DRV_send_keyboard_input  wParam=0079, lParam=c0440001,
InputKeyState=c1
trace:event:process_events processed 1 events
trace:msg:peek_message got type 7 msg 101 (WM_KEYUP) hwnd 0x10030 wp 79 lp
c0440001

Still I don't know if it is a wine bug.
With Page Up and Down the hotswap works perfectly.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #8 from Dmitry Timoshkov   2009-07-21 08:05:57 ---
Again, please don't generate or attach any logs unless somebody asked about it.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #9 from Christoph Korn   2009-07-21 09:04:47 ---
Oh, you meant to not attach the logs at all.

Sorry, :-(

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Erich Hoover   2009-10-09 19:21:28 ---
I've submitted a patch for this bug:
http://www.winehq.org/pipermail/wine-patches/2009-October/079731.html

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #11 from Christoph Korn   2009-10-11 16:11:15 ---
(In reply to comment #10)
> I've submitted a patch for this bug:
> http://www.winehq.org/pipermail/wine-patches/2009-October/079731.html

I can confirm that this patch fixes the bug.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

--- Comment #12 from Erich Hoover   2009-10-14 09:14:45 ---
(In reply to comment #11)
> (In reply to comment #10)
> > I've submitted a patch for this bug:
> > http://www.winehq.org/pipermail/wine-patches/2009-October/079731.html
>
> I can confirm that this patch fixes the bug.

The patch made it into the latest git, please give it a try.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Christoph Korn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Christoph Korn   2009-10-23 14:04:43 ---
Fixed in 1.1.32.

[Bug 19383] [Monkey Island Special Edition] Version Hotswap does not work

http://bugs.winehq.org/show_bug.cgi?id=19383

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2009-11-13 12:44:10 ---
Closing bugs fixed in 1.1.33.