[Bug 14373] New: Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Summary: Starcraft : select one overlord (and only it) makes the
                    game very slow.
           Product: Wine
           Version: unspecified
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The "bug" is mouse won't move at the same speed when you have selected one
overlord, and only one overlord.
When you have anything else selected, game will have a "normal" speed.

Steps to reproduce :

1/ update your registries as described :
* Use the key "DirectDrawRenderer" and add that to your registry 
* with the value "opengl"; you may also need to add the key 
* "RenderTargetLockMode" with the value "readtex".

2/ Launch single game "play custom" and choose zerg for you.

3/ select overlord

4/ move mouse

If you do "F10" to make menu appear, the mouse will still be slow !

Workaround : remove "Direct3D" from registry (Local user\Software\Wine)

Ref:
http://appdb.winehq.org/objectManager.php?sClass=version&iId=149#Comment...

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Charles de Noyelle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Severity|enhancement                 |major
            Version|unspecified                 |1.1.0

--- Comment #1 from Charles de Noyelle   2008-07-08 14:03:37 ---
I tested it on Wine v. 1.0 and 1.1 on my AMD64.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Hubmaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Hubmaster   2008-07-08 20:39:11 ---
I have also faced the same problem with Starcraft ever since Wine 0.9.x. It's
not only Overlords, it's also with upgrading Lairs and Hives when the game gets
slow as hell.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Hubmaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]   |

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Hubmaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Hubmaster   2008-08-22 16:16:32 ---
If im not mistaken, I remember that Wine 0.9.16 was when I first experienced
this.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Mischa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Mischa   2008-09-01 08:52:58 ---
*** This bug has been confirmed by popular vote. ***

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Lukáš Krejza  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Lukáš Krejza   2008-11-17 21:17:47 ---
I think this is dupe of bug 421... (http://bugs.winehq.org/show_bug.cgi?id=421)

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #6 from Austin English   2008-11-17 23:23:29 ---
(In reply to comment #5)
> I think this is dupe of bug 421... (http://bugs.winehq.org/show_bug.cgi?id=421)

Possibly, have you tried building with the DIB engine and seeing if it helps?

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #7 from Hubmaster   2008-11-30 17:26:28 ---
I don't think this is related to the DIB engine. This started happening with
the "big" wineserver rewrite. (I think 0.9.16 timeframe). If you compare 0.9.x
compared to 0.9.2x, you'll notice the bug we are talking about.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #8 from Lukáš Krejza   2008-12-01 16:27:20 ---
So please add regression to keywords :-)

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #9 from Jeff Zaroyko   2008-12-01 16:47:34 ---
(In reply to comment #8)
> So please add regression to keywords :-)

It would be better to do a regression test to confirm that it actually is a
regression or alternatively, profile the game running under Wine using oprofile
to see where the time is being spent.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #10 from Hubmaster   2008-12-02 00:52:31 ---
What I meant to say is the big DirectDraw rewrite on top of Direct3D, not the
"big wineserver rewrite." I'll try to do a regression test in the coming weeks.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #11 from Jeff Zaroyko   2008-12-02 01:02:54 ---
(In reply to comment #10)
> What I meant to say is the big DirectDraw rewrite on top of Direct3D, not the
> "big wineserver rewrite." I'll try to do a regression test in the coming weeks.

ah, not sure how much that will help then considering how much has changed, as
opposed to a small change that has caused a regression.

which video card and drivers do you have?

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #12 from Hubmaster   2008-12-02 01:21:21 ---
At the time, I had a 2.6 Ghz Pentium 4 with a NVidia GeForce AGP 7200 Video
card.

I will try to reproduce this bug on my new laptop.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Jon Dufresne  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Jan Kalab  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Jan Kalab   2009-04-03 02:29:48 ---
I think it's fixed in 1.1.18 (maybe even earlier).

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Austin English   2009-04-03 10:40:32 ---
Reported fixed.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2009-04-10 11:16:24 ---
Closing bugs fixed in 1.1.19.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Lauri Kenttä  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Lauri Kenttä   2009-04-11 17:00:46 ---
No, I think this bug is still present. Although the minor lag does not affect
gameplay (with 1,73 GHz CPU), it causes CPU usage to rise from 40% to 55%.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #17 from Jan Kalab   2009-04-12 02:05:19 ---
Will enabling Menu > Options > Speed > CPU Throttling help?

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #18 from Lauri Kenttä   2009-04-12 03:35:44 ---
(In reply to comment #17)
> Will enabling Menu > Options > Speed > CPU Throttling help?

I had it already enabled. Here are some more CPU percentages, now I remembered
to look at Xorg as well.

With CPU Throttling:
Overlord: SC 55%, Xorg 45%
Others: SC 40%, Xorg 25%

Without CPU Throttling:
Overlord: SC 55%, Xorg 45%
Others: SC 70%, Xorg 30%

The slowness (visibly slow FPS) with and without throttling remains the same,
as do the CPU utilisation percentages. Clearly this has something to do with
drawing with X drivers.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #19 from Lukáš Krejza   2009-04-12 07:25:53 ---
I thing this is sure an dupe of Bug 421 ... This slowness is not only when
selecting overlords, but it is more visible on them because they have complex
model (their tentacles)... You can observe this slowness on almost every flying
unit... And not only on them...
This is my opinion, i have no idea how much is DIB used in SCBW...

Regards
          Gryffus

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #20 from Lauri Kenttä   2009-04-12 08:37:21 ---
(In reply to comment #19)
> I thing this is sure an dupe of Bug 421 ... This slowness is not only when
> selecting overlords, but it is more visible on them because they have complex
> model (their tentacles)... You can observe this slowness on almost every flying
> unit... And not only on them...

This can't be. The slowness comes from selecting an overlord, not seeing them.
The game is slow even if the selected overlord is not in the view, and just
seeing overlords doesn't cause slowness, only selecting does.

It would be helpful if we had the CPU usage stats in Windows as well. There
must be something the game does differently when an overlord is selected, and
this might be a bug in the game itself and should logically be detectable in
Windows too, even if it doesn't cause the game to lag there.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

Javier Martin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Javier Martin   2009-04-14 12:00:43 ---
I can confirm that the bug is still present in 1.1.19: selecting an Overlord
(not a Mutalisk, not a dozen Overlords) causes the game speed to drop
noticeably on a machine that should have no problem with a game this old. This
has been tested with and without the in-game "CPU Throttling" switch.

[Bug 14373] Starcraft : select one overlord (and only it) makes the game very slow.

http://bugs.winehq.org/show_bug.cgi?id=14373

--- Comment #22 from Matteo   2010-07-11 17:56:07 ---
Created an attachment (id=29547)
 --> (http://bugs.winehq.org/attachment.cgi?id=29547)
cure for slowness

This bug is still present in wine-1.2rc6. Selecting buildings during upgrading,
overlords, evolving eggs and everything displaying a progress bar results in
100% CPU usage and slowness. The main cause is an increased number of
Locks/Unlocks needed to paint the scene.

As pointed out here:

http://wiki.winehq.org/DirectDraw

frequent Locks/Unlocks can lead to performance losses. Unfortunately even by
setting DirectDrawRender to opengl one still gets extremely high CPU usage
under the above circumstances.

The attached patch is a hack made specifically for starcraft that tries to
overcome the problem. Locks/Unlocks are redirected to a memory buffer and real
video memory Locks are allowed to occur roughly 50 times per second. This
successfully reduces the CPU overhead both in gdi and opengl mode.

Example: DirectDrawRenderer = opengl with "CPU throttling" enabled in starcarft
results in 25-30% CPU usage on my Pentium(R) 4 CPU 2.66GHz even when selecting
overlords / buildings.

Note that this is not a fix of wine's directdraw implementation, it will only
work with starcraft, possibly breaking other apps. I've tested the patch on
wine 1.0.1 (debian testing) and wine 1.2rc6, is there anyone willing to test it
further?