https://bugs.winehq.org/show_bug.cgi?id=50230
Bug ID: 50230 Summary: ntdll.dll is missing strcpy_s function Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: adam@michalik.es Distribution: ---
I was trying to run Microsoft's signtool.exe from Windows 10 SDK, and, trying to use native Windows libraries to make it work, finally it hit a snag on missing strcpy_s in ntdll.dll:
wine: Call from 0x7bc764b9 to unimplemented function ntdll.dll.strcpy_s, aborting
I think the call originates from native cryptsp.dll, though I'm not 100% certain about that.
https://bugs.winehq.org/show_bug.cgi?id=50230
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |5.22 Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- Confirming.
https://bugs.winehq.org/show_bug.cgi?id=50230
--- Comment #2 from Adam Michalik adam@michalik.es --- Also ntdll.strcat_s is missing.
https://bugs.winehq.org/show_bug.cgi?id=50230
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Keywords| |download URL| |https://web.archive.org/web | |/20201201121411/https://dow | |nload.microsoft.com/downloa | |d/1/c/3/1c3d5161-d9e9-4e4b- | |9b43-b70fe8be268c/windowssd | |k/Installers/Windows%20SDK% | |20Signing%20Tools-x86_en-us | |.msi Summary|ntdll.dll is missing |Signtool from Windows 10 |strcpy_s function |SDK with Windows 7+ native | |dll overrides need security | |enhanced string functions | |exported from ntdll.dll | |(strcpy_s, strcat_s ...)
--- Comment #3 from Anastasius Focht focht@gmx.net --- Hello folks,
refining summary to provide the actual context. Otherwise it reads like a general bug, affecting several apps/games which it isn't.
You probably copied a bunch of dlls over from a Windows 7/8/10 installation. The security enhanced versions of the string/CRT functions are exported starting with Windows 7.
https://www.geoffchappell.com/studies/windows/win32/ntdll/api/index.htm
Maybe you provide a list of them here by using 'winedump -j import foobar.dll' (foobar = the native dlls you use as replacement for builtins).
While native overrides can make things work, the missing "builtin" Wine functionality should be reported as well so Wine can be improved to work without resorting to such workarounds.
For example I created bug 50233 ("Signtool from Windows 10 SDK needs 'wintrust.CryptCATAdminAcquireContext2' implementation") an so developers can implement the missing functionality in future with no native dlls required at all. The is even bug 34071 ("implement SignTool.exe") which aims to have Wine provide a builtin replacement for the tool from the SDK. But that's more a long term goal.
Regards
https://bugs.winehq.org/show_bug.cgi?id=50230
--- Comment #4 from Adam Michalik adam@michalik.es ---
affecting several apps/games which it isn't.
It is not *known* to affect several apps, but given that str*_s are quite general general function, I think it's safe to assume that signtool is not a literally unique one that's using them.
Maybe you provide a list of them here by using 'winedump -j import foobar.dll'
Thanks for telling me about winedump, I didn't know about it. However, after patching my wine installation to add these functions to wine's ntdll.dll, signtool no longer complained about any missing functionality from ntdll.
https://bugs.winehq.org/show_bug.cgi?id=50230
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- (In reply to Adam Michalik from comment #4)
affecting several apps/games which it isn't.
It is not *known* to affect several apps, but given that str*_s are quite general general function, I think it's safe to assume that signtool is not a literally unique one that's using them.
They are in general, and if it were msvcrt, it'd be a different story, but most applications have no reason to jump through hoops to use undocumented functions from ntdll, especially for CRT functions like this.
In any case the more salient point is that native components, especially for core and non-redistributable libraries, are not really interesting to us; we'd rather fix builtin components instead. And of course any such builtin implementation would almost certainly not use strcpy_s() from ntdll.
https://bugs.winehq.org/show_bug.cgi?id=50230
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Signtool from Windows 10 |Multiple applications from |SDK with Windows 7+ native |Windows 10 SDK need |dll overrides need security |security enhanced CRT |enhanced string functions |functions exported from |exported from ntdll.dll |ntdll.dll when using |(strcpy_s, strcat_s ...) |Windows 7+ native dll | |overrides (strcpy_s, | |strcat_s ...)
--- Comment #6 from Anastasius Focht focht@gmx.net --- Hello Adam,
it's as Zeb said. I was trying to say/imply the same but Zeb is better at conveying the message ;-)
--- quote --- I think it's safe to assume that signtool is not a literally unique one that's using them. --- quote ---
If it makes you more happy, I'll refine the summary to "multiple applications" but the point still stands:
No user-space application = main executable and/or third-party dlls (excluding non-redistributable dlls bundled with Windows) is supposed to import secure CRT API from low-level ntdll. If you find a commercial or open-source application that does this, feel free to mention it here.
Regards
-
WineHQ Bugzilla