[Bug 12264] New: IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Summary: IDA disassembler window isn't added to taskbar
           Product: Wine
           Version: 0.9.58.
          Platform: PC
               URL: http://www.hex-rays.com/idapro/idadown.htm
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

IDA doesn't get a button on taskbar, so on minimizing the app it disappears and
can't be found (in non-virtual desktop mode).

Dmitry Timoshkov said on wine-devel about this problem:

"The problem with IDA is that the button you see in the Windows task bar
does not belong to the main IDA window, it belongs to a zero sized visible
window with the same caption. Since it's zero sized Wine doesn't map it all.
So, while formally it's a regression, technically it's not: main IDA window
has never been added to the task bar before my patch. This all can be easily
discovered with spy++ and a simple test app."

Can't be verified in free version (see url).

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #1 from Alexander Dorofeyev   2008-03-28 15:10:30 ---
Oh sorry I typed it wrongly, it CAN be verified in free version.

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Giuseppe Bilotta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Giuseppe Bilotta   2008-04-05 10:38:42 ---
*** Bug 12353 has been marked as a duplicate of this bug. ***

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #3 from Giuseppe Bilotta   2008-04-08 12:36:59 ---
Created an attachment (id=11981)
 --> (http://bugs.winehq.org/attachment.cgi?id=11981)
Patch to add owned windows to taskbar if owner isn't mapped

I attach here my proposed solution for this problem, which is to add owned
windows to the taskbar if the owner isn't mapped.

Technically speaking, this doesn't solve the problem Dmitry Timoshkov talks
about:
"""
What you need to be fixed is making a zero sized window with WS_VISIBLE
style set mapped, but X11/WMs doesn't handle that gracefully.
"""

Indeed, when I tried to make the zero sized visible window mapped I got odd
results such as the zero sized window appearing, with decorations and all,
causing strange focusing problems etc.

I don't know if it's even possible to make the zero sized windows mapped in a
sensible way, so I propose this alternative fix.

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dmitry Timoshkov   2008-04-11 07:13:44 ---
*** Bug 12480 has been marked as a duplicate of this bug. ***

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Petr Dlouhý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Petr Dlouhý   2008-04-11 14:16:25 ---
*** This bug has been confirmed by popular vote. ***

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dmitry Timoshkov   2008-04-11 22:26:49 ---
*** Bug 12505 has been marked as a duplicate of this bug. ***

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #7 from Paul Romanyszyn   2008-04-11 22:55:03 ---
Could the summary be changed to make it easier to find.
like Windows not added to taskbar ?
I would also severity in not enhancement but normal unless you consider using
the virtual desktop as a workaround.

[Bug 12264] IDA disassembler window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Keywords|                            |download, patch

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
            Summary|IDA disassembler window     |IDA disassembler (and other
                   |isn't added to taskbar      |apps developed in Delphi)
                   |                            |window isn't added to
                   |                            |taskbar

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Austin English   2008-04-14 02:23:13 ---
*** Bug 12437 has been marked as a duplicate of this bug. ***

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #9 from Dmitry Timoshkov   2008-04-16 02:51:30 ---
Please try the following patch:

http://www.winehq.org/pipermail/wine-patches/2008-April/053435.html

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #10 from Lei Zhang   2008-04-16 03:05:12 ---
Looks like I need this one as well:
http://www.winehq.org/pipermail/wine-patches/2008-April/053433.html

PSPad works as expected with the patches.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #11 from Paul Romanyszyn   2008-04-16 10:22:53 ---
I get an error applying the patch. I will test if it get into git or look at
the error later when I get some free time.

paul@paul-semipron:~/Git/wine-git$ patch -p1
<../tools/delphiwindowlist3.patch.eml 
patching file dlls/winex11.drv/window.c
Hunk #1 succeeded at 144 (offset 21 lines).
Hunk #2 succeeded at 183 (offset 21 lines).
Hunk #3 succeeded at 879 (offset 21 lines).
patching file dlls/winex11.drv/winpos.c
Hunk #1 FAILED at 293.
1 out of 1 hunk FAILED -- saving rejects to file dlls/winex11.drv/winpos.c.rej

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #12 from Dmitry Timoshkov   2008-04-16 10:31:24 ---
Comment #10 has a link to an additional patch which should be applied first.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #13 from Paul Romanyszyn   2008-04-16 11:39:45 ---
I manually corrected the bad hunk without the other patch and testing my app
works.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #14 from Petr Dlouhý   2008-04-16 16:52:40 ---
Yes, PSPad is showing taskbar item also for me after aplying the patch.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Dmitry Timoshkov   2008-04-17 08:21:46 ---
The patch has been committed.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #16 from Petr Dlouhý   2008-04-17 15:10:30 ---
Yes, it is working in newest GIT. But I realize one thing: the item in taskbar
has disabled controls for minimizing, maximizing and sizing. I am using Gnome
2.22.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #17 from Giuseppe Bilotta   2008-04-17 15:33:29 ---
I can confirm. Should we reopen with different summary, or open a new bug?

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #18 from Dmitry Timoshkov   2008-04-18 03:48:44 ---
Please open a separate bug.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

--- Comment #19 from Petr Dlouhý   2008-04-18 05:35:12 ---
Ok, reported as Bug 12640.

[Bug 12264] IDA disassembler (and other apps developed in Delphi) window isn't added to taskbar

http://bugs.winehq.org/show_bug.cgi?id=12264

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2008-04-18 11:04:24 ---
Closing bugs reported fixed in 0.9.60.