[Bug 41700] New: "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

Bug ID: 41700
           Summary: "Install Now" and "Customize installation" buttons are
                    invisible in Python 3.5 installer
           Product: Wine
           Version: 1.9.23
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The "Install Now" and "Customize installation" buttons do not appear on either
the regular Python 3.5 installer or the Python 3.5 web installer, not even if
you hover the mouse over the buttons or press the tab key repeatedly. However,
the installation continues if you click where the button should be, and the tab
key appears to move focus onto and off of the buttons even though there is no
visual feedback.

Note that you must set the Windows version to Windows Vista or later in winecfg
or the installer will only show you an error message.

$ sha1sum python-3.5.2.exe 
3873deb137833a724be8932e3ce659f93741c20b  python-3.5.2.exe

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #1 from Alex Henrie  ---
Created attachment 56103
  --> https://bugs.winehq.org/attachment.cgi?id=56103
Windows screenshot

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #2 from Alex Henrie  ---
Created attachment 56104
  --> https://bugs.winehq.org/attachment.cgi?id=56104
Wine screenshot

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #3 from Dmitry Timoshkov  ---
(In reply to Alex Henrie from comment #0)
> The "Install Now" and "Customize installation" buttons do not appear on
> either the regular Python 3.5 installer or the Python 3.5 web installer, not
> even if you hover the mouse over the buttons or press the tab key
> repeatedly. However, the installation continues if you click where the
> button should be, and the tab key appears to move focus onto and off of the
> buttons even though there is no visual feedback.
>
> Note that you must set the Windows version to Windows Vista or later in
> winecfg or the installer will only show you an error message.

Actually Python 3.5 installer should work under XP too, and under XP
the aforementioned buttons are also missing. That's a bug in the class
library (can't recall its name off the top of my head, but it's open
source) the installer is using.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #4 from Dmitry Timoshkov  ---
(In reply to Dmitry Timoshkov from comment #3)
> Actually Python 3.5 installer should work under XP too, and under XP
> the aforementioned buttons are also missing. That's a bug in the class
> library (can't recall its name off the top of my head, but it's open
> source) the installer is using.

The library name is WIX.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #5 from Alex Henrie  ---
Created attachment 56119
  --> https://bugs.winehq.org/attachment.cgi?id=56119
Windows XP screenshot

(In reply to Dmitry Timoshkov from comment #3)
> Actually Python 3.5 installer should work under XP too

The attached screenshot shows that it does not. Wine's Windows XP behavior is
correct.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #6 from Dmitry Timoshkov  ---
Created attachment 56120
  --> https://bugs.winehq.org/attachment.cgi?id=56120
Python 3.5.0 installer under Windows XP

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #7 from Dmitry Timoshkov  ---
(In reply to Alex Henrie from comment #5)
> Created attachment 56119 [details]
> Windows XP screenshot
>
> (In reply to Dmitry Timoshkov from comment #3)
> > Actually Python 3.5 installer should work under XP too
>
> The attached screenshot shows that it does not. Wine's Windows XP behavior
> is correct.

It looks like the supported Windows version requirements have changed
starting from the Python 3.5.1 release. I've attached a screenshot of
Python 3.5.0 installer startup screen running under XP, it matches
the Wine one.

If I recall correctly since when I looked at this problem last time
the source of the problem is that the Python installer (or rather WIX)
uses invalid style for the "Button" window class which leads to a failure
in repainting the window.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5 installer

https://bugs.winehq.org/show_bug.cgi?id=41700

--- Comment #8 from Dmitry Timoshkov  ---
(In reply to Dmitry Timoshkov from comment #7)
> (In reply to Alex Henrie from comment #5)
> > Created attachment 56119 [details]
> > Windows XP screenshot
> >
> > (In reply to Dmitry Timoshkov from comment #3)
> > > Actually Python 3.5 installer should work under XP too
> >
> > The attached screenshot shows that it does not. Wine's Windows XP behavior
> > is correct.
>
> It looks like the supported Windows version requirements have changed
> starting from the Python 3.5.1 release. I've attached a screenshot of
> Python 3.5.0 installer startup screen running under XP, it matches
> the Wine one.
>
> If I recall correctly since when I looked at this problem last time
> the source of the problem is that the Python installer (or rather WIX)
> uses invalid style for the "Button" window class which leads to a failure
> in repainting the window.

Probably WIX depends on another quirk between user32 and comctl32 in
the "Button" class implementations. See for another example of a similar
painting issue bug 29921, it has a test case with source attached.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5.2 installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41700

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Install Now" and           |"Install Now" and
                   |"Customize installation"    |"Customize installation"
                   |buttons are invisible in    |buttons are invisible in
                   |Python 3.5 installer        |Python 3.5.2 installer
                URL|                            |https://web.archive.org/web
                   |                            |/20161109152228if_/https://
                   |                            |www.python.org/ftp/python/3
                   |                            |.5.2/python-3.5.2.exe
           Keywords|                            |download

--- Comment #9 from Gijs Vermeulen  ---
This seems to be fixed with wine-6.19-173-g0925a730272, tested in a 32bit
prefix and both winvista & win7.

Alex, can you confirm?

Adding stable download.

$ sha1sum python-3.5.2.exe
3873deb137833a724be8932e3ce659f93741c20b  python-3.5.2.exe

$ du -sh python-3.5.2.exe
28M    python-3.5.2.exe

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5.2 installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41700

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Alex Henrie  ---
Yes, I believe this has been fixed for quite a while.

[Bug 41700] "Install Now" and "Customize installation" buttons are invisible in Python 3.5.2 installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41700

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 6.20.