http://bugs.winehq.org/show_bug.cgi?id=17163
Summary: winrar text box covered by a horizontal scrollbar Product: Wine Version: 1.1.13 Platform: PC-x86-64 URL: http://rarlabs.com/download.htm OS/Version: Linux Status: NEW Keywords: download, regression Severity: minor Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: thestig@google.com
Created an attachment (id=19041) --> (http://bugs.winehq.org/attachment.cgi?id=19041) screenshot - bad on the left, good on the right.
I was looking at bug 12087 and 12088, and I noticed a regression. Steps to reproduce:
- start winrar - press the add button on the toolbar - go to the file tab - press the append... button next to the "files to add" textbox You should be in the WinRar directory. - Hold down Ctrl and select both Order.htm and Readme.txt - Press ok
Expected result: the "files to add" textbox should have the names of the files I selected. Actual result: the textbox is covered by a horizontal scrollbar.
Regression test says:
e6fedf879c0666f1646b013d920fa7752f4ea42d is first bad commit commit e6fedf879c0666f1646b013d920fa7752f4ea42d Author: Dylan Smith dylan.ah.smith@gmail.com Date: Wed Jan 14 13:24:02 2009 -0500
richedit: Implemented the horizontal scrollbar.
http://bugs.winehq.org/show_bug.cgi?id=17163
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12088
http://bugs.winehq.org/show_bug.cgi?id=17163
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17163
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #1 from Dylan Smith dylan.ah.smith@gmail.com 2009-01-28 00:38:38 --- Sent a patch to wine-patches that seems to fix the bug: richedit: Suppress scrollbar if missing WS_[VH]SCROLL style. http://www.winehq.org/pipermail/wine-patches/2009-January/068491.html
These window style flags that determine whether the scrollbar should be shown or not weren't actually used before. Possibly because there wasn't as much of a problem with the vertical scrollbar being shown when it shouldn't be shown.
http://bugs.winehq.org/show_bug.cgi?id=17163
--- Comment #2 from Dylan Smith dylan.ah.smith@gmail.com 2009-01-28 08:18:25 --- (In reply to comment #1)
Sent a patch to wine-patches that seems to fix the bug: richedit: Suppress scrollbar if missing WS_[VH]SCROLL style. http://www.winehq.org/pipermail/wine-patches/2009-January/068491.html
The patch has just been accepted in to the main git tree as commit a051a231190a0b76887a8f90a00d41b54ac703d5
It should be fixed in git. could you re-test and make sure.
http://bugs.winehq.org/show_bug.cgi?id=17163
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #3 from Lei Zhang thestig@google.com 2009-01-28 13:40:40 --- Fixed. Thanks for the quick response.
http://bugs.winehq.org/show_bug.cgi?id=17163
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org 2009-01-30 11:05:20 --- Closing bugs fixed in 1.1.14.