[Bug 47751] New: x64dbg crashes in get_current_context / InterlockedCompareExchange

https://bugs.winehq.org/show_bug.cgi?id=47751

Bug ID: 47751
           Summary: x64dbg crashes in get_current_context /
                    InterlockedCompareExchange
           Product: Wine
           Version: 4.9
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While investigating on debian bug 939559 I tried to launch x64dbg
and found it crash on startup already.
This was with debian distribution packages of wine.
I could reproduce it also with a wine built from git.

Backtrace:
=>0 0x7e62644a get_current_context+0x70()
    [...wine\include\winbase.h:2927] in msvcr120 (0x0b19fe78)
  1 0x7e626538 get_current_scheduler+0xa()
    [...wine\dlls\msvcr120..\msvcrt\scheduler.c:234] in msvcr120 (0x0b19fe98)
  2 0x7e628ab6 _CurrentScheduler__Id+0x4d()
    [...wine\dlls\msvcr120..\msvcrt\scheduler.c:1074] in msvcr120 (0x0b19feb8)
  3 0x00c5ca3e EntryPoint+0xffffffff() in x32dbg (0x0b19ff34)
  4 0x00c5c60b EntryPoint+0xffffffff() in x32dbg (0x0b19ff3c)
  5 0x7bca9dd4 call_thread_func_wrapper+0xb() in ntdll (0x0b19ff4c)
  6 0x7bca9e37 call_thread_func+0x60()
    [...wine\dlls\ntdll\signal_i386.c:2723] in ntdll (0x0b19ffdc)
  7 0x7bca9dc6 call_thread_entry+0x9() in ntdll (0x0b19ffec)

[Bug 47751] x64dbg crashes in get_current_context / InterlockedCompareExchange

https://bugs.winehq.org/show_bug.cgi?id=47751

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Debian
    Regression SHA1|                            |d5a372abbba2e174de78855bdd4
                   |                            |a004b56cdc006

--- Comment #1 from Bernhard Übelacker  ---
A git bisect leads to commit d5a372abbba2e174de78855bdd4a004b56cdc006.
The function _CurrentScheduler__Id is tested in msvcrt110 tests,
but for some reason I could not find a crash in any testbot logs,
also not with a noop patch to msvcrt110.
While I am seeing this issue on Debian 10,
which is used by testbot too.

I think the issue might be in debian build and mine,
that the variable context_tls_index ends up in the
.text section of msvcr120.dll.so, which might be readonly.

Before the above mentioned commit that variable is
in the .data section of msvcr120.dll.so.

For some reason the DEFINE_VTBL_WRAPPER lines are related.
Moving these to the end of the file makes the variable
be again in the .data section in current git head.

But as testbot does not suffer from this, I am not
sure if this is an issue with my setup or compiler versions,
or such. Doesn't testbot use the Debian 10 compiler versions?

[Bug 47751] x64dbg crashes in get_current_context / InterlockedCompareExchange

https://bugs.winehq.org/show_bug.cgi?id=47751

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |https://sourceforge.net/pro
                   |                            |jects/x64dbg/files/snapshot
                   |                            |s/snapshot_2019-09-01_17-37
                   |                            |.zip/download

--- Comment #2 from Bernhard Übelacker  ---
Adding keywords and url.

[Bug 47751] x64dbg crashes in get_current_context / InterlockedCompareExchange

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47751

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |0c853f026578dd7c8aede2f716c
                   |                            |8e55d816ccf40

--- Comment #3 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=0c853f026578dd7c8aede2f71...

[Bug 47751] x64dbg crashes in get_current_context / InterlockedCompareExchange

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47751

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 4.18.

[Bug 47751] x64dbg crashes in get_current_context / InterlockedCompareExchange

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47751

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://sourceforge.net/pro |https://web.archive.org/web
                   |jects/x64dbg/files/snapshot |/20210214163556if_/https://
                   |s/snapshot_2019-09-01_17-37 |netactuate.dl.sourceforge.n
                   |.zip/download               |et/project/x64dbg/snapshots
                   |                            |/snapshot_2019-09-01_17-37.
                   |                            |zip
                 CC|                            |[e-mail]