[Bug 11494] New: The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

Summary: The Install does not work, acts like it finises though
           Product: Wine
           Version: 0.9.54.
          Platform: PC-x86-64
               URL: http://www.speedproject.de/enu/speedcommander/index.html
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=10648)
 --> (http://bugs.winehq.org/attachment.cgi?id=10648)
First screen

I don't know if it's because of the installer it uses, but take a look through
the pictures and you can see that it doesn't install into the correct
directory, and at the end of the install you only get an uninstall.exe in the
Default folder.  By the way, the Default install path for this program is
Program files/SpeedProject/SpeedCommander 12/ instead of this wierd Program
Files/Default.  I have tried manually changing the install directory to the
correct one but it never copies the correct file into the folder.  I have
attached all pics from the install process for reference.  Not sure if this
install is tied to the bug from 11490.  Thank you.

[Bug 11494] The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #1 from Thom   2008-02-06 14:17:56 ---
Created an attachment (id=10649)
 --> (http://bugs.winehq.org/attachment.cgi?id=10649)
Second

[Bug 11494] The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #2 from Thom   2008-02-06 14:18:19 ---
Created an attachment (id=10650)
 --> (http://bugs.winehq.org/attachment.cgi?id=10650)
Third

[Bug 11494] The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #3 from Thom   2008-02-06 14:18:38 ---
Created an attachment (id=10651)
 --> (http://bugs.winehq.org/attachment.cgi?id=10651)
Fourth

[Bug 11494] The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #4 from Thom   2008-02-06 14:19:17 ---
Created an attachment (id=10652)
 --> (http://bugs.winehq.org/attachment.cgi?id=10652)
Fifth - The install dir with only uninstall.exe

[Bug 11494] The Install does not work, acts like it finises though

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #5 from Thom   2008-02-06 14:19:39 ---
Created an attachment (id=10653)
 --> (http://bugs.winehq.org/attachment.cgi?id=10653)
Terminal Output - Not much info?

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download, Installer
            Summary|The Install does not work,  |Speed Commander 12 does not
                   |acts like it finises though |install

--- Comment #6 from Austin English   2008-02-06 15:08:46 ---
http://www.sp-download.de/sc12/sc12u.exe

Confirming. Though, I'm getting some different results in current git.
Installer crashes for me, doesn't pretend to finish. The unintall.exe is there,
however. Terminal output is short:

err:ntdll:RtlpWaitForCriticalSection section 0x13158c "animate.c:
ANIMATE_INFO*->cs" wait timed out in thread 0016, blocked by 001a, retrying (60
sec)
wine: Critical section 0013158c wait failed at address 0x7ef967f0 (thread
0016), starting debugger...
Unhandled exception: wait failed on critical section 0x0013158c
err:seh:raise_exception Unhandled exception code c0000194 flags 0 addr
0x7ef967f0
fixme:exec:SHELL_execute flags ignored: 0x00000400
Process of pid=0015 has terminated

I'll attach the backtrace.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #7 from Austin English   2008-02-06 15:09:37 ---
Created an attachment (id=10655)
 --> (http://bugs.winehq.org/attachment.cgi?id=10655)
Backtrace in current git.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #8 from Austin English   2008-02-06 15:12:34 ---
(In reply to comment #7)
> Created an attachment (id=10655)

--> (http://bugs.winehq.org/attachment.cgi?id=10655) [details]
> Backtrace in current git.

Ignore these past two comments. They're a separate bug. I tested in wine
0.9.54, however, and THIS bug is valid/confirmed. I'll file a separate bug for
that one.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #9 from Anastasius Focht   2008-02-06 16:45:09 ---
Created an attachment (id=10656)
 --> (http://bugs.winehq.org/attachment.cgi?id=10656)
patch which fixes Profile_Open file access attributes bug

Hello,

the installer writes out a temporary ini-style file from its resources with
delete-on-close semantics (FILE_FLAG_DELETE_ON_CLOSE).
Wine's profile API -> Profile_Open() doesn't honour this, failing to open the
temporary file (share flags) returning "Default" value.
The solution is to open the profile file with FILE_SHARE_READ |
FILE_SHARE_DELETE by default.

Attached patch fixes this problem and lets the installer successfully finish.

SC12 later crashes on other issues, unimplemented shell32 apis.
You should file separate bug reports for that.

Regards

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #10 from Thom   2008-02-09 22:13:08 ---
(In reply to comment #9)
> Created an attachment (id=10656)

--> (http://bugs.winehq.org/attachment.cgi?id=10656) [details]
> patch which fixes Profile_Open file access attributes bug
>
> Hello,
>
> the installer writes out a temporary ini-style file from its resources with
> delete-on-close semantics (FILE_FLAG_DELETE_ON_CLOSE).
> Wine's profile API -> Profile_Open() doesn't honour this, failing to open the
> temporary file (share flags) returning "Default" value.
> The solution is to open the profile file with FILE_SHARE_READ |
> FILE_SHARE_DELETE by default.
>
> Attached patch fixes this problem and lets the installer successfully finish.
>
> SC12 later crashes on other issues, unimplemented shell32 apis.
> You should file separate bug reports for that.
>
> Regards

Thanks so much, I don't know much about compiling and using diff files.  Will
this fix make it to the next release?

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #11 from Thom   2008-03-31 15:17:14 ---
I am running WINE 0.9.58 and I notice this behavior still exists.  What needs
to be done to commit this patch to the production code?

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Anastasius Focht   2008-03-31 17:18:44 ---
Hello,

--- quote ---
I am running WINE 0.9.58 and I notice this behavior still exists.  What needs
to be done to commit this patch to the production code?
--- quote ---

depends.
For such a change, an additional conformance test might be needed.

Writing CT should be a no-brainer with the information I gave.

Example: Create a temp ini file with delete-on-close semantics
(FILE_FLAG_DELETE_ON_CLOSE), containing sample data and then call one of the
ini file APIs on it (GetPrivateProfileString, ..) reading existing values.

Regards

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #13 from Thom   2008-04-01 14:42:04 ---
Hi Anastasius, I am not a coder and am pretty much a noob for linux so I'm not
even sure what you mean by trying those things.  I put the bug in hoping that
it would get Wine closer to running windows apps without problems.  I guess at
this point I'm not sure what to do to get this approved but can only hope the
project maintainers see that you submitted a patch that fixes it and will put
it in the next wine version.  Thank you again for your help!

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #14 from Thom   2008-06-03 16:35:45 ---
Could this patch be applied before 1.0 is released?  It's still a problem with
1.0 rc3

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #15 from Thom   2008-06-07 11:08:21 ---
Just tried with 1.0 rc4 amd it's still an issue, thank you

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |kernel32

--- Comment #16 from Louis Lenders   2008-06-07 11:22:15 ---
i guess this needs a testcase. I'll see if i can add a testcase later this
week.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

--- Comment #17 from Thom   2008-06-19 08:50:23 ---
Just an FYI that this is still a bug in 1.0.  Should I keep testing on all
released versions to see if progress is made?  I don't want to spam people's
mailboxes

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.1

--- Comment #18 from Louis Lenders   2008-06-19 09:20:28 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.1

--- Comment #18 from Louis Lenders   2008-06-19 09:20:28 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

--- Comment #19 from Louis Lenders   2008-06-19 09:20:46 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.1

--- Comment #18 from Louis Lenders   2008-06-19 09:20:28 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

--- Comment #19 from Louis Lenders   2008-06-19 09:20:46 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

--- Comment #20 from Louis Lenders   2008-06-19 09:21:54 ---
> Should I keep testing on all released versions to see if progress is made?

Not really necessary. I'm a it limited in time to look into this. But i'll set
it as a target for wine-1.0.1 as the bug+solution seems to be completely clear

--- Comment #21 from Thom   2008-07-16 13:01:55 ---
I hate to be a pest but this is a still a problem with 1.1.1, sorry

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

L. Rahyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from L. Rahyen   2008-07-17 22:56:50 ---
> > But i'll set it as a target for wine-1.0.1 as the bug+solution seems to be
> > completely clear
>
> I hate to be a pest but this is a still a problem with 1.1.1, sorry

1.1.1 != 1.0.1; see "Task List" for "Wine 1.0.1" right under WineHQ menu on the
bugzilla in order to see bugs that are expected (but not guaranteed) to be
solved in 1.0.1.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Michael Karcher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]-
                   |                            |berlin.de

--- Comment #23 from Michael Karcher   2008-08-17 12:06:11 ---
patch submitted to wine-patches, see
  http://www.winehq.org/pipermail/wine-patches/2008-August/059543.html

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #24 from Detlef Riekenberg   2008-09-12 09:45:45 ---
Patch committed:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=33ca67dcab8e99d2fddbd2...

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard   2008-09-19 11:17:06 ---
Closing bugs fixed in 1.1.5.

[Bug 11494] Speed Commander 12 does not install

http://bugs.winehq.org/show_bug.cgi?id=11494

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |33ca67dcab8e99d2fddbd2d3a11
                   |                            |d73b21ba0ef41