[Bug 50923] New: Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

Bug ID: 50923
           Summary: Long freezes in osu! when searching in beatmaps
           Product: Wine-staging
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Created attachment 69739
  --> https://bugs.winehq.org/attachment.cgi?id=69739
Patch that adds a single-entry sortguid cache to sortkey_compare

Wine-Staging patchset libs-Unicode_Collation makes CompareStringEx far slower
than before. This is because the sortkey_compare function added by the last
patch and used by CompareStringEx makes a call to get_language_sort, which is
not exactly cheap (it reads from the registry which involves server calls).

A small patch that adds a simple cache for the last used sortguid makes the
search function fast again.

[Bug 50923] Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

Torge Matthies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 50923] Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
please add keyword patch. Also you should offer the patch for wine-staging.

[Bug 50923] Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

--- Comment #2 from Torge Matthies  ---
(In reply to Torge Matthies from comment #0)
> Created attachment 69739 [details]
> Patch that adds a single-entry sortguid cache to sortkey_compare
>
> Wine-Staging patchset libs-Unicode_Collation makes CompareStringEx far
> slower than before. This is because the sortkey_compare function added by
> the last patch and used by CompareStringEx makes a call to
> get_language_sort, which is not exactly cheap (it reads from the registry
> which involves server calls).
>
> A small patch that adds a simple cache for the last used sortguid makes the
> search function fast again.

I sent a patch to the mailing list, see
https://source.winehq.org/patches/data/203183

[Bug 50923] Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

Torge Matthies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 50923] Long freezes in osu! when searching in beatmaps

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50923

Neko-san  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]