[Bug 28824] New: shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

http://bugs.winehq.org/show_bug.cgi?id=28824

Bug #: 28824
           Summary: shell32/tests/recyclebin.ok: uninitialised value used
                    in TRASH_GetDetails
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: shell32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

In "make recyclebin.ok", valgrind complains:

Conditional jump or move depends on uninitialised value(s)
    at __mktime_internal (mktime.c:428)
    by mktime (mktime.c:518)
    by TRASH_GetDetails (trash.c:444)
    by TRASH_EnumItems (trash.c:523)
    by SHQueryRecycleBinW (recyclebin.c:859)
    by SHQueryRecycleBinA (recyclebin.c:848)
    by test_query_recyclebin (recyclebin.c:74)
    by func_recyclebin (recyclebin.c:106)
    by run_test (test.h:556)
    by main (test.h:624)
  Uninitialised value was created by a stack allocation
    at TRASH_GetDetails (trash.c:367)

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

https://bugs.winehq.org/show_bug.cgi?id=28824

--- Comment #1 from Austin English  ---
Conditional jump or move depends on uninitialised value(s)
    at  __mktime_internal (mktime.c:185)
    by  mktime (mktime.c:591)
    by  TRASH_GetDetails (trash.c:518)
    by  TRASH_EnumItems (trash.c:597)
    by  SHQueryRecycleBinW (recyclebin.c:866)
    by  SHQueryRecycleBinA (recyclebin.c:855)
    by  test_query_recyclebin (recyclebin.c:74)
    by  func_recyclebin (recyclebin.c:106)
    by  run_test (test.h:584)
    by  main (test.h:654)
  Uninitialised value was created by a stack allocation
    at  TRASH_GetDetails (trash.c:441)

still present.

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

http://bugs.winehq.org/show_bug.cgi?id=28824

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Vincent Povirk  ---
Created attachment 48642
  --> http://bugs.winehq.org/attachment.cgi?id=48642
DeletionDate format checking

Do you get any additional ERR output from the test with this patch?

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

http://bugs.winehq.org/show_bug.cgi?id=28824

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48642|0                           |1
        is obsolete|                            |

--- Comment #3 from Vincent Povirk  ---
Created attachment 48643
  --> http://bugs.winehq.org/attachment.cgi?id=48643
set tm_isdst to denote unknown dst status

Does this help?

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

https://bugs.winehq.org/show_bug.cgi?id=28824

--- Comment #4 from Austin English  ---
(In reply to Vincent Povirk from comment #3)
> Created attachment 48643 [details]
> set tm_isdst to denote unknown dst status
>
> Does this help?

Works here in wine-1.7.19-70-gd6a59f7, thanks.

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

https://bugs.winehq.org/show_bug.cgi?id=28824

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source, testcase,
                   |                            |valgrind

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

https://bugs.winehq.org/show_bug.cgi?id=28824

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |fa8d59c30b250ac1d4814268e2b
                   |                            |7956a11d8f8b9
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
(In reply to Austin English from comment #4)
> (In reply to Vincent Povirk from comment #3)
> > Created attachment 48643 [details]
> > set tm_isdst to denote unknown dst status
> >
> > Does this help?
>
> Works here in wine-1.7.19-70-gd6a59f7, thanks.

https://source.winehq.org/git/wine.git/commitdiff/fa8d59c30b250ac1d4814268e2...

Thanks Vincent

[Bug 28824] shell32/tests/recyclebin.ok: uninitialised value used in TRASH_GetDetails

https://bugs.winehq.org/show_bug.cgi?id=28824

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.