[Bug 18899] New: Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Summary: Notepad++ right click menu doesn't work
           Product: Wine
           Version: 1.1.23
          Platform: PC
               URL: http://sourceforge.net/project/showfiles.php?group_id=
                    95717&package_id=102072
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21741)
 --> (http://bugs.winehq.org/attachment.cgi?id=21741)
screenshot

Notepad++ pops up a little menu if you right click on a file name in the
toolbar, with options to save all files, close all, print, etc. Under wine, the
menu doesn't show up.

There's no terminal output.

Screenshot attached, for those unfamiliar with notepad++.

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

--- Comment #1 from Austin English   2010-05-23 17:37:33 ---
Still present.

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] 2010-09-11 01:35:43 CDT ---
I have had this problem for a long time as well. I love Notepad++! I just came
across this tonight, funny thing is that I had given up on finding a solution
and wasn't even looking for it when I found it. Anyways...

I ran across this:
https://answers.launchpad.net/ubuntu/+source/wine/+question/38804

Which says:

With Wine versions 1.0.1 or greater Notepad++ will install and run almost 100%.
To get all functionality download winetricks:
wget http://www.kegel.com/wine/winetricks

Install the comctl32 (native microsoft)

Otherwise when you right click on the Tabs nothing happens.

There you go. It works now for me, and to think that I am halfway through
learning gVIM. Hehe

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32

--- Comment #3 from Austin English  2010-09-11 14:33:39 CDT ---
Setting component then. Thanks!

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Mark  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Mark  2011-02-10 02:08:09 CST ---
hattwj's solutions works like a charm.

thanks!

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

--- Comment #5 from Nikolay Sivov  2011-05-12 12:41:58 CDT ---
Interesting, tab control gets WM_LBUTTONDOWN instead of WM_RBUTTONDOWN (and not
*UP one, that is not so interesting).

Will take a look at their code.

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

--- Comment #6 from Nikolay Sivov  2011-05-12 15:53:49 CDT ---
Created an attachment (id=34668)
 --> (http://bugs.winehq.org/attachment.cgi?id=34668)
patch

They relay WM_RBUTTONDOWN as WM_LBUTTONDOWN in a first place in subclass
procedure so control never gets it:

--- TabBar.cpp ----
case WM_RBUTTONDOWN :    //rightclick selects tab aswell
{
    ::CallWindowProc(_tabBarDefaultProc, hwnd, WM_LBUTTONDOWN, wParam, lParam);
    return TRUE;
}
---

Wine's control sends NM_RCLICK notification after WM_RBUTTONDOWN (so it doesn't
in this case). Simple test with ControlSpy with default Tab behaviour shows
that NM_RCLICK is sent on mouse release, so after WM_RBUTTONUP.

Attached patch fixes this.

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Nikolay Sivov  2011-05-13 11:25:51 CDT ---
Fixed by 4daa5459f48a8b1f2f9a9818cdd775280ede4f01.

[Bug 18899] Notepad++ right click menu doesn't work

http://bugs.winehq.org/show_bug.cgi?id=18899

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2011-05-13 13:34:09 CDT ---
Closing bugs fixed in 1.3.20.

[Bug 18899] Notepad++ right click menu doesn't work

https://bugs.winehq.org/show_bug.cgi?id=18899

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]