[Bug 49375] New: Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

Bug ID: 49375
           Summary: Test Drive 6 demo crashes when starting a race
           Product: Wine
           Version: 5.9
          Hardware: x86-64
               URL: https://www.fileplanet.com/35366/download/Test-Drive-6
                    -Demo
                OS: Mac OS X
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: f02b0226caa7a7a3f1c45563f144aee506044be6

Created attachment 67435
  --> https://bugs.winehq.org/attachment.cgi?id=67435
output + backtrace

Found while trying to retest bug 43232. This might be relevant:
https://bugs.winehq.org/show_bug.cgi?id=43232#c11.

Wine-5.8 works. Bisection revealed:

078b249665b338b25b5966f4879f5dcbb6e11a9a is the first bad commit
commit 078b249665b338b25b5966f4879f5dcbb6e11a9a
Author: Paul Gofman 
Date:   Thu May 14 19:55:44 2020 +0430

wined3d: Allow setting user memory for mipmapped textures in
wined3d_texture_update_desc().

Resetting to the commit before makes it work again.

Logs are attached. I am running macOS 10.14 and compiling with mingw and the
10.13 SDK. I have a 2015 MacBook Pro with an AMD Radeon R9 M370X 2GB.

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #1 from Paul Gofman  ---
Thanks for the report. So the referenced bug (which is open) says that the game
is crashing, and it is still crashing, but was working for some period before
the blamed commit? Did you bisect by any chance which commit allowed the game
to work?

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #2 from Gijs Vermeulen  ---
(In reply to Paul Gofman from comment #1)
> Thanks for the report. So the referenced bug (which is open) says that the
> game is crashing, and it is still crashing, but was working for some period
> before the blamed commit? Did you bisect by any chance which commit allowed
> the game to work?

The original crash has been long gone, possibly because of
https://source.winehq.org/git/wine.git/commitdiff/13861b7952684505fd4e850b2963926436b17b4a

The bug should've been split up between the crash and the black terrain and
43232 should've been solely about the black terrain. Comment #11 is strictly
about the black terrain, which wasn't a crash.

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #3 from Paul Gofman  ---
Ok, so as I understand:

1. Bug #43232 is about the crash that was fixed.
2. There always has been the black screen which was never fixed.
3. The game is now crashing instead of black screen after the blamed commit.

Is that correct?

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #4 from Gijs Vermeulen  ---
(In reply to Paul Gofman from comment #3)
> Ok, so as I understand:
> - Bug #43232 is about the crash that was fixed.
> - There always has been the black screen which was never fixed.
> - The game is now crashing instead of black screen after the blamed commit.
>
> Is that correct?

Sorry for my terrible explanation.

1. Bug 43232 was both about the crash that was fixed and black texture issue.
Bug 42387 exists, reported by the same person, about the same crash. These bugs
should've been renamed/sorted out, but never were.

2. Correct. Although, according to my testing, the black terrain issue has
improved greatly before the blamed commit, which I should have mentioned,
sorry. (I hadn't retested the bug since 2018)

3. As mentioned above, the black terrain was improved/maybe completely fixed
before the blamed commit (somewhere between my last test in 2018 and the blamed
commit), but yes, now the game is crashing.

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #5 from Paul Gofman  ---
Thanks, I will try to take a look on the weekend.

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #6 from Gijs Vermeulen  ---
(In reply to Paul Gofman from comment #5)
> Thanks, I will try to take a look on the weekend.

I just tested 186963-186967 and can confirm it fixes both this bug and bug
43232.

Thanks for the quick fixes!

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

--- Comment #7 from Paul Gofman  ---
Should be fixed by
https://source.winehq.org/git/wine.git/commit/5b287bb0ca813eba988e6550453b7f...

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |5b287bb0ca813eba988e6550453
                   |                            |b7fc4501b4f1f
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Gijs Vermeulen  ---
(In reply to Paul Gofman from comment #7)
> Should be fixed by
> https://source.winehq.org/git/wine.git/commit/
> 5b287bb0ca813eba988e6550453b7fc4501b4f1f

I can confirm it's fixed, thanks!

[Bug 49375] Test Drive 6 demo crashes when starting a race

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49375

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 5.11.