[Bug 43197] New: 5Plus: regression: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Bug ID: 43197
           Summary: 5Plus: regression: Print dialog crashes with illegal
                    floating point operation
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

5Plus (a German school credits and report program) crashes with lately versions
of wine when trying to print a report. A pop-up with "Unzulässige
Gleitkommaoperation" (illegal floating point operation) occurs and the print
cancel button doesn't react anymore. Interestingly, the menu bar gets corrupted
with the first letters missing the left half.

The regression occurs here:

commit a60144ee74e1db170f04edeb8cfd3a5a17d36d46
Author: Huw Davies 
Date:   Thu Jan 26 09:30:20 2017 +0000

user32: Disable cached DCs once they are released.

Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

:040000 040000 e4b9b15bea9e9ba5c5e59a9bc1711793f8ef38db
82429bb454753e5dd76e396abababde24e0db498 M      dlls

The error is in dlls/user32/painting.c 
static INT release_dc( HWND hwnd, HDC hdc, BOOL end_paint )
     {
         if (!(dce->flags & DCX_NORESETATTRS)) SetHookFlags( dce->hdc,
DCHF_RESETDC );
         if (end_paint || (dce->flags & DCX_CACHE)) delete_clip_rgn( dce );
         if (dce->flags & DCX_CACHE)
         {
             dce->count = 0;
             SetHookFlags( dce->hdc, DCHF_DISABLEDC );
         }
         ret = TRUE;
     }

Commenting out SetHookFlags() bings back normal behaviour.

[Bug 43197] 5Plus: regression: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
    Regression SHA1|                            |a60144ee74e1db170f04edeb8cf
                   |                            |d3a5a17d36d46
           Keywords|                            |regression

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|5Plus: regression: Print    |5Plus: Print dialog crashes
                   |dialog crashes with illegal |with illegal floating point
                   |floating point operation    |operation

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #1 from Huw Davies  ---
Is there a demo version of this program available?

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #2 from [e-mail] ---
Yes (in German) http://www.gew-bw.de/1p5p/setup5p2013.exe

I am using version 2007, but this also shows the crash. Just open one of the
demo db files, select a line and click on the print icon.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #3 from Huw Davies  ---
(In reply to felix.huber from comment #2)
> Yes (in German) http://www.gew-bw.de/1p5p/setup5p2013.exe
>
> I am using version 2007, but this also shows the crash. Just open one of the
> demo db files, select a line and click on the print icon.

Please give detailed instructions on how to reproduce this.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #4 from [e-mail] ---
1) Download http://www.gew-bw.de/1p5p/setup5p2013.exe

2) env WINEPREFIX=~/.wineTest wine setup5p2013.exe

3) Click 5 times on „weiter“ (continue), then on „installieren“ (install) and
finally on „fertigstellen“ (finish)

4) cd ~/.wineTest/drive_c/5PLUS_2013

5) env WINEPREFIX=~/.wineTest wine Einsplus.exe

6) Click on ok for the update check dialog

7) Choose Menu „Klasse“, „wählen und bearbeiten“, click on „Hauptschule“, then
ok. Double-click 5m-03041.dbf

8) Click the tool button „Zeugnis drucken“, choose yes in the dialog
„Einzelzeugnis drucken“ → Crash with „Ungültige Gleitkommaoperation“ (invalid
floating point operation)

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #5 from Huw Davies  ---
I can't reproduce this.  Could you confirm it's still happening for you with an
up to date Wine.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #6 from [e-mail] ---
I tried with the latest version (both rpm and self compiled), still crashes.

I wonder if the floating error is the right message: It looks as if the screen
shortly flickers before the message, so the problem might be a race condition
in the graphics.

My systems are Suse Leap 42.2/42.3, no proprietary drivers.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #7 from Huw Davies  ---
Could you get me a +relay,+tid,+seh,+win,+message log of the crash? Put it on a
server somewhere (rather than on here) and send me the link.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #8 from Huw Davies  ---
(In reply to Huw Davies from comment #7)
> Could you get me a +relay,+tid,+seh,+win,+message log of the crash? Put it
> on a server somewhere (rather than on here) and send me the link.

Actually, please see if this patch helps:
https://source.winehq.org/patches/data/136642

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #9 from Huw Davies  ---
(In reply to Huw Davies from comment #8)
> (In reply to Huw Davies from comment #7)
> > Could you get me a +relay,+tid,+seh,+win,+message log of the crash? Put it
> > on a server somewhere (rather than on here) and send me the link.
>
> Actually, please see if this patch helps:
> https://source.winehq.org/patches/data/136642

This patch was committed:
https://source.winehq.org/git/wine.git/commit/9ea33ed00a242392a7c19dbb51afb5...

Please retest with the current git or wait until Wine 2.16 is released.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #10 from [e-mail] ---
I recompiled from wine-2.15 with your patch applied: works fine

I will retest once 2.16 is officially out.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

--- Comment #11 from [e-mail] ---
Issue is fixed in wine 2.16

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |9ea33ed00a242392a7c19dbb51a
                   |                            |fb54c0770d178

--- Comment #12 from Nikolay Sivov  ---
Marking fixed, 9ea33ed00a242392a7c19dbb51afb54c0770d178.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 2.17.

[Bug 43197] 5Plus: Print dialog crashes with illegal floating point operation

https://bugs.winehq.org/show_bug.cgi?id=43197

Omega Software  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Omega Software  ---
*** Bug 44713 has been marked as a duplicate of this bug. ***