[Bug 16356] New: 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Summary: 16 bit file dialog file filter not working
           Product: Wine
           Version: 0.9.52.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Regression
77c0fad57207dd38864eaa8a54ae0571f37e5b20 is first bad commit
commit 77c0fad57207dd38864eaa8a54ae0571f37e5b20
Author: Dmitry Timoshkov 
Date:   Tue Jan 8 16:43:14 2008 +0800

comdlg32: If lpstrFile points to a valid string use it as a default value
for edit control.
After this commit A simple Delphi 1 program with a file open or save dialog no
longer updates the files listbox when the drop down file type selector is
changed. 
It will be a few weeks before I have time to look for solution.

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #1 from Paul Romanyszyn   2008-12-06 00:48:36 ---
Created an attachment (id=17673)
 --> (http://bugs.winehq.org/attachment.cgi?id=17673)
Delphi1 source and exe demo

Click on form to bring up file open dialog. Switch file type from txt to all
and right side list box of files in directory should change.

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Paul Romanyszyn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #2 from Paul Romanyszyn   2008-12-06 12:12:57 ---
Looking at the traces and code it seems that the nFilterIndex in the 16 bit
code is never set to anything other then 1 and this is the default
initialization.

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #3 from Paul Romanyszyn   2008-12-07 22:22:36 ---
It looks like the combobox should set the dialog filter index when it changes
but it does not. Before the patch the file name was set to the filter and then
used by scandir. Now it is done the correct way but with the wrong (default)
filter index.

With my limited knowledge of how the 16 to 32 bit stuff is handled along with
not knowing enough of the WINAPI it will be a while (at least 2 weeks) before I
have any free time to investigate much further. In FD31_FileTypeChange it needs
to query the combobox with the filter str to get the index then set
nFilterIndex to the new index.

traces with some additional data and traces added

trace:commdlg:FD31_WMInitDialog add str=L"txt" associated to L"*.txt"
trace:commdlg:FD31_WMInitDialog add str=L"all" associated to L"*.*"
...
trace:commdlg:FD31_FileTypeChange Selected filter : L"*.*"
trace:commdlg:FD31_Validate got filename = L"File.txt"
trace:commdlg:FD31_TestPath before scandir
trace:commdlg:FD31_ScanDir Trying to change to L"File.txt\" filter L"txt"
filterinx 1

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #4 from Paul Romanyszyn   2008-12-26 00:22:16 ---
Created an attachment (id=18194)
 --> (http://bugs.winehq.org/attachment.cgi?id=18194)
c  source from win16-test's filddlg.c modified to run interactively

This when compiled in win16-tests frameworks demonstrates the problem. I added
a third filter type and set the filter to that type. Use the dropdown list to
change the filter index to show the problem.

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |testcase

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Luke Benstead  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #5 from Luke Benstead   2009-08-16 03:34:16 ---
Confirmed in Wine 1.1.27

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from André H.   2010-06-04 09:24:54 ---
reverting the patch of the bisect does not fix the Problem!

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #7 from Paul Romanyszyn   2010-06-04 09:58:28 ---
See comment #3. From what I remember when I dug into this the original 32 bit
code was wrong and when fixed the 16 bit path needed did not work or was not
complete.

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

--- Comment #8 from André H.   2010-06-04 11:02:14 ---
patch sent:
http://www.winehq.org/pipermail/wine-patches/2010-June/089276.html

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from André H.   2010-06-07 12:13:32 ---
patch commited, should be fixed

[Bug 16356] 16 bit file dialog file filter not working

http://bugs.winehq.org/show_bug.cgi?id=16356

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2010-06-11 12:50:43 ---
Closing bugs fixed in 1.2-rc3.

[Bug 16356] 16 bit file dialog file filter not working

https://bugs.winehq.org/show_bug.cgi?id=16356

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |31b9fefe0e0eeca504274281492
                   |                            |6454d92e0de1f
    Regression SHA1|                            |77c0fad57207dd38864eaa8a54a
                   |                            |e0571f37e5b20