[Bug 44160] New: Possible access to unintended field in "tools/winegcc/ winegcc.c" line 1633

https://bugs.winehq.org/show_bug.cgi?id=44160

Bug ID: 44160
           Summary: Possible access to unintended field in
                    "tools/winegcc/winegcc.c" line 1633
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tools
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While experimenting with a CodeSonar plugin we develop, we noticed a
potential bug in file "tools/winegcc/winegcc.c" line 1633, function main

else if (!strncmp("--lib-suffix", argv[i], 12) && opts.wine_objdir) //HERE
 {
     if (argv[i][12] == '=') opts.lib_suffix = argv[i] + 13;
     else opts.lib_suffix = argv[++i];
     raw_compiler_arg = raw_linker_arg = 0;
 }

Wasn't the intention to access lib_suffix (instead of wine_objdir)?

Regards,
Petru Florin Mihancea

[Bug 44160] Possible access to unintended field in "tools/winegcc/ winegcc.c" line 1633

https://bugs.winehq.org/show_bug.cgi?id=44160

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Alexandre Julliard  ---
No, wine_objdir is correct, lib_suffix isn't set yet at this point.

[Bug 44160] Possible access to unintended field in "tools/winegcc/ winegcc.c" line 1633

https://bugs.winehq.org/show_bug.cgi?id=44160

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Ken Sharp  ---
Closing