[Bug 38009] New: winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

Bug ID: 38009
           Summary: winex11.drv does not set NET_WM_STATE_FULLSCREEN if
                    the display mode was changed
           Product: Wine
           Version: 1.7.35
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Winex11.drv only sets NET_WM_STATE_FULLSCREEN on a fullscreen game window if
the game uses the monitor resolution that was set when winex11.drv was loaded.
The cause of this is that is_window_rect_fullscreen compares the window
rectangle against the monitor size reported by Xinerama when winex11.drv was
loaded.

This appears to trigger bugs inside Metacity clones and Compiz when creating a
window at a lower resolution. It also breaks the fix that was proposed by a
Marco developer to fix the bug that currently prevents fullscreen windows from
being iconified.

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ken Thomases  ---
> ... when the display mode was changed

Changed by whom?  By Wine or externally?

I'm pretty sure that when Wine changes the display mode, it changes the
recorded size of the primary monitor.  xrandr*_set_current_mode() ->
X11DRV_resize_desktop() -> xinerama_init() -> query_screens() -> sets
rcMonitor, which is what is_window_rect_fullscreen() compares against.

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

--- Comment #2 from Stefan Dösinger  ---
By Wine, called by the application

I didn't spot that codepath, I came to the conclusion that xinerama_init was
only called on driver load. I'll have a look.

This problem happens on the Nvidia driver (with the Xrandr 1.1 fallback) and
open source drivers (with newer xrandr) fwiw.

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

--- Comment #3 from Stefan Dösinger  ---
It seems that the Xinerama info is updated, but only in the process that
changes the display settings. I'll have to do more testing and see if the
problem is specific to Warcraft 3, which happened to be my test application.

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from joaopa  ---
Still a bug in current wine?

[Bug 38009] winex11.drv does not set NET_WM_STATE_FULLSCREEN if the display mode was changed

https://bugs.winehq.org/show_bug.cgi?id=38009

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]