[Bug 53542] New: Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

Bug ID: 53542
           Summary: Hog4PC 3.17 installer VBScript custom action needs
                    IWshShell::Run to return signed type.
           Product: Wine
           Version: 7.11
          Hardware: x86-64
               URL: https://web.archive.org/web/20211128125004/https://cdn
                    .etcconnect.com/Hog_4_PC_3.17.0.3327.msi.zip
                OS: Linux
            Status: NEW
          Keywords: download, Installer, patch
          Severity: normal
          Priority: P2
         Component: wshom.ocx
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail], [e-mail]
        Depends on: 52128
      Distribution: ---

+++ This is successor to Bug #52128 +++

After applying scrrun::Movefolder patch, we get script error in msi custom
action

$WINEDEBUG=+vbscript ./wine  msiexec -i C:\Hog_4_PC_3.17.0.3327.msi
...
01c4:trace:vbscript:do_icall L"unpack1" 0
01c4:trace:vbscript:interp_int 0
01c4:trace:vbscript:interp_equal 
01c4:trace:vbscript:var_cmp 0017A75C {VT_UI4: 0} 00176FB8 {VT_I2: 0}
01c4:trace:vbscript:VBScriptError_GetExceptionInfo (0017AE58)->(03D0FB10)
01c4:err:msi:MsiActiveScriptSite_OnScriptError script error: L"Type mismatch"

Excerpt from script file:
...
    Set objShell  = CreateObject("Shell.Application")
...
        firstCmd = """" & TargetDir & "\7za.exe"" x -y " & """" & FixtureLib &
"""" & " -o""" & FixtureLibDir & """"
        unpack1 = shell.Run(firstCmd, 0, True)
        If ( unpack1 = 0 ) Then
...

Return value of shell.Run is of type VT_UI4 which is no integrated type of
vbscript.

Output value of IWshShell::Run  [out, retval] DWORD* out_ExitCode)
seems to be int* in native and not DWORD* as in wine.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #1 from Nikolay Sivov  ---
Yes, this makes sense. Please send a patch when you have time.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #2 from Robert Wilhelm  ---
I created a merge request:
https://gitlab.winehq.org/wine/wine/-/merge_requests/634

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |f0e2ea988e666533dd9f5ba1a6e
                   |                            |68b2853dd0038
           Keywords|                            |regression

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #3 from Nikolay Sivov  ---
Turns out we had it with correct type at some point, and I changed it to DWORD
back in 2015 for no good reason.

There's also two methods in IWshExec that need the same DWORD -> long (int)
change.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #4 from Robert Wilhelm  ---
(In reply to Nikolay Sivov from comment #3)
> There's also two methods in IWshExec that need the same DWORD -> long (int)
> change.

I noticed this, too.

I can send patch for WshExec_get_ProcessID after current MR went in.

I am not sure what to do with WshExec_get_ExitCode, as it is currently not
implemented.
I could just change interface (DWORD to long) or implement the function using
GetExitCodeProcess().

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #5 from Robert Wilhelm  ---
Forgot to mention:

With this MR (https://gitlab.winehq.org/wine/wine/-/merge_requests/634) and
https://gitlab.winehq.org/wine/wine/-/merge_requests/391 from #52128,
the Hog_4_PC installer finishes successfully.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #6 from Nikolay Sivov  ---
(In reply to Robert Wilhelm from comment #4)
> (In reply to Nikolay Sivov from comment #3)
> > There's also two methods in IWshExec that need the same DWORD -> long (int)
> > change.
>
> I noticed this, too.
>
> I can send patch for WshExec_get_ProcessID after current MR went in.
>
> I am not sure what to do with WshExec_get_ExitCode, as it is currently not
> implemented.
> I could just change interface (DWORD to long) or implement the function
> using GetExitCodeProcess().

It's fine to fix the interface first.

I tried to test typeinfo quickly with ITypeInfo on WshShell, and there is
something else going on. On Wine I get whole set of inherited methods from
GetFuncDesc(), i.e. GetFuncDesc(0) return QueryInterface. While on Windows it
returns 0 index for IWshShell3 (id 0xbc4). Not sure what's happening, if it's a
problem with definition, typelib generation, or typelib API.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #7 from Robert Wilhelm  ---
I tested with vbscript:

Set objShell = CreateObject("WScript.Shell")
Set objExec = objShell.Exec ("notepad.exe")
msgbox  TypeName(objExec.ProcessID)

With wine, I get 
0164:fixme:vbscript:Global_TypeName arg 0075F700 {VT_UI4: 360} not supported

With native (winetricks install wsh57) I get "Long" typename for ProcessID.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

--- Comment #8 from Nikolay Sivov  ---
Yes, it would be correct to change both from DWORD to int, that corresponds to
"Long". What I meant is C typeinfo API behavior does not match, but that does
not affect scripting.

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |484f028338f3a3ff26c2a8a0da1
                   |                            |7daed8d433c59

--- Comment #9 from Robert Wilhelm  ---
Merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/634
was merged in
https://gitlab.winehq.org/wine/wine/-/commit/484f028338f3a3ff26c2a8a0da17dae...

[Bug 53542] Hog4PC 3.17 installer VBScript custom action needs IWshShell::Run to return signed type.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53542

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 7.16.