[Bug 43019] New: redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Bug ID: 43019
           Summary: redefinition of typedef 'QWORD' (wine compilation
                    fails with gcc 4.2.1)
           Product: Wine
           Version: 2.8
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wmp&wmvcore
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: d5930db829680734ac0a6b10b1a2125cf24dba15

Created attachment 58163
  --> https://bugs.winehq.org/attachment.cgi?id=58163
console output

Regression test reveals:

author    Alistair Leslie-Hughes     
Thu, 11 May 2017 03:51:42 +0000 (21:51 -0600)
commit    d5930db829680734ac0a6b10b1a2125cf24dba15

include: Add drmexternals.idl and wmdrmsdk.idl.

As the first bad commit.

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

--- Comment #1 from Alistair Leslie-Hughes  ---
Created attachment 58164
  --> https://bugs.winehq.org/attachment.cgi?id=58164
Patch

Does this fix the issue?

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

--- Comment #2 from Gijs Vermeulen  ---
(In reply to Alistair Leslie-Hughes from comment #1)
> Created attachment 58164 [details]
> Patch
>
> Does this fix the issue?

It does, thank you.

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

--- Comment #3 from Austin English  ---
ifndef would probably be preferable ​over removing it completely

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #4 from Alistair Leslie-Hughes  ---
(In reply to Austin English from comment #3)
> ifndef would probably be preferable ​over removing it completely

No, the proper place for this define is in mfobjects.idl.

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] ---
https://source.winehq.org/git/wine.git/commit/0c07a33c4c86fce7923f8e18bd99b7...

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0c07a33c4c86fce7923f8e18bd9
                   |                            |9b75243c9d9b5
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Gijs Vermeulen  ---
Fixed.

[Bug 43019] redefinition of typedef 'QWORD' ( wine compilation fails with gcc 4.2.1)

https://bugs.winehq.org/show_bug.cgi?id=43019

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 2.9.