https://bugs.winehq.org/show_bug.cgi?id=55247
Bug ID: 55247 Summary: Assertion in riched20 while installing Office 2007 Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: richedit Assignee: wine-bugs@winehq.org Reporter: ulrich.gemkow@ikr.uni-stuttgart.de Distribution: ---
Created attachment 74844 --> https://bugs.winehq.org/attachment.cgi?id=74844 Log file with WINEDEBUG=riched20
The installer of Office 2007 fails with an assertion in riched20. A bisect shows the following commit
commit b70eb32c5f3e506181d9e1e9fbef62e9baf3674d Author: Jinoh Kang jinoh.kang.kr@gmail.com Date: Sat Jul 1 13:22:46 2023 +0900
riched20: Wrap marked paragraphs at Text Services initialization.
Today, CreateTextServices() returns an Rich Edit object without row start and end marks, which are expected to exist by many Rich Edit operations as well as EM_* message handlers.
This leads to a crash when certain messages (e.g., EM_SCROLLCARET) are sent to the Rich Edit object via ITextServices::TxSendMessage(), unless ME_WrapMarkedParagraphs() has been called beforehand.
Fix this by calling wrap_marked_paras_dc() early in the initialization process.
This is not a problem for windowed Rich Edit controls, which already calls ME_WrapMarkedParagraphs() before the user or application starts interacting with it.
dlls/riched20/para.c | 1 + dlls/riched20/tests/txtsrv.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+)
A log file with WINEDEBUG=riched20 is attached.
https://bugs.winehq.org/show_bug.cgi?id=55247
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |b70eb32c5f3e506181d9e1e9fbe | |f62e9baf3674d
https://bugs.winehq.org/show_bug.cgi?id=55247
--- Comment #1 from Ken Sharp imwellcushtymelike@gmail.com --- What version of Wine are you using?
https://bugs.winehq.org/show_bug.cgi?id=55247
--- Comment #2 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Thanks for looking into this bug!
The bug happens with the current git as of 07/12/2023 (how should "current git" given to bugzilla?)
I think there is already a MR !3321 which may fix this. I saw this after submitting this bug and am waiting for this MR to be applied.
https://bugs.winehq.org/show_bug.cgi?id=55247
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #3 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Fixed by 548d7179e3b2b9961321a4df50644c9b3874a295
https://bugs.winehq.org/show_bug.cgi?id=55247
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |548d7179e3b2b9961321a4df506 | |44c9b3874a295
https://bugs.winehq.org/show_bug.cgi?id=55247
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.13.