[Bug 32087] New: External environment variables interfere with cmd runtest, causing it to issue false errors
http://bugs.winehq.org/show_bug.cgi?id=32087
Bug #: 32087 Summary: External environment variables interfere with cmd runtest, causing it to issue false errors Product: Wine Version: 1.5.15 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: cmd AssignedTo: wine-bugs@winehq.org ReportedBy: jay@henrythorson.com Classification: Unclassified
Created attachment 42301 --> http://bugs.winehq.org/attachment.cgi?id=42301 Examples of failed and successful 'make test' output
Runtest ('make test') in programs/cmd/tests fails for me (see attachment for test output). The likely cause is due to the command 'set BA' in the 'Testing set' section of test_builtins.cmd. When cmd is given this command, it echoes all environment variables that begin with BA as well as the desired output BAZ=bazbaz, which throws the test output out of sync with the expected output. I am able to fix the problem by unsetting such variables (e.g. BASH_ENV) before running 'make test'. The cmd documentation states that importing variables into cmd from the shell environment is a desired feature, thus I would recommend that the cmd test suite selectively unset or unexport environment variables prior to running the test (but please do not unset critical ones like DISPLAY).
This problem may be related to bug # 31889.
http://bugs.winehq.org/show_bug.cgi?id=32087
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com 2012-10-28 18:54:11 CDT --- Reminds me of bug 28880.
http://bugs.winehq.org/show_bug.cgi?id=32087
Jason Edmeades us@edmeades.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |us@edmeades.me.uk
--- Comment #2 from Jason Edmeades us@edmeades.me.uk 2012-10-29 05:12:07 CDT --- No, the original reporter has it right - its purely a case of the 'set' tests displaying the environment and relying on nothing in the environment already existing which starts with those characters. It'll be interesting to work around, although possible when we eventually have working for /f, as we could add before the test something like for /f "delims==" %%i in ('set ba') do set %%i= (I dont have Linux to hand to test this, but I suspect its enough - Are you able to confirm it and I'll send a patch later in the week)
http://bugs.winehq.org/show_bug.cgi?id=32087
Jason Edmeades us@edmeades.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |us@edmeades.me.uk
--- Comment #3 from Jason Edmeades us@edmeades.me.uk 2012-11-08 16:02:28 CST --- export BASH_ENV=dummy && make test fails...
http://bugs.winehq.org/show_bug.cgi?id=32087
Jason Edmeades us@edmeades.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #4 from Jason Edmeades us@edmeades.me.uk 2012-11-19 15:05:54 CST --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2012-November/120068.html
http://bugs.winehq.org/show_bug.cgi?id=32087
Jason Edmeades us@edmeades.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2e92853091262fee67f651dfc6a | |0188e349ba0b2 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #5 from Jason Edmeades us@edmeades.me.uk 2012-11-20 14:30:43 CST --- Committed (we also changed all env vars to WINE_ as a precaution)
http://bugs.winehq.org/show_bug.cgi?id=32087
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2012-11-23 14:30:59 CST --- Closing bugs fixed in 1 5.18.
-
wine-bugs＠winehq.org