[Bug 27732] New: WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Summary: WinRAR became unusable since Wine 1.3.23, it
                    constantly flashes and consumes 100% of CPU
           Product: Wine
           Version: 1.3.23
          Platform: x86
               URL: http://www.rarlabs.com/rar/wrar393.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

There's nothing to add to the bug title.

If you cursor is placed on ".." (the upper item of the files list), this line
will be constantly flashing while WinRAR consumes 100% of CPU.

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail],
                   |                            |[e-mail]
          Component|-unknown                    |comctl32
     Ever Confirmed|0                           |1

--- Comment #1 from Wylda  2011-07-09 03:45:35 CDT ---

Confirming, crazy re-drawing/refreshing of the blue bar + high CPU usage.
Tested under winrar-4.01.

1. I did a regression test between 1.3.22 and 1.3.23:

commit 1a67903b04001c7064f6e4705a66dc3cfa47feed
Author: Piotr Caban 
Date:   Mon Jun 20 12:46:37 2011 +0200

comctl32: Fix area invalidated by LISTVIEW_SetItemT.

:040000 040000 c0e2e6923ba42074b57138cca367458336a6631b
9cc28e2ad36c163910dc3ccdcbce88e2e025043b M      dlls

2. No other bug report suffers from this commit.

3. Revert of this patch on top of wine-1.3.24 makes that problem go away.

4. Adding author of this patch to CC.

--private keyword: bisected

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

root  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Alexander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Grazvydas Ignotas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Grazvydas Ignotas  2011-07-17 11:10:41 CDT ---
This also affects IDA Pro (similar effects), revert fixes the problem.

Any comments, Piotr?

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

--- Comment #3 from Nikolay Sivov  2011-07-17 23:00:31 CDT ---
Hi, Piotr. Patch looks suspicious for me, why do we need to always invalidate
even if item contents are not changed for example? That's what
set_main_item/set_sub_item is supposed to return as 'changed' flag.

What was this fix for?

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Piotr Caban  2011-07-20 08:58:11 CDT ---
I will look on it tomorrow (I was on vacation). The patch was intended to fix
redrawing of items that have different size when selected.

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Nikolay Sivov  2011-07-20 09:04:47 CDT ---
(In reply to comment #4)
> I will look on it tomorrow (I was on vacation). The patch was intended to fix
> redrawing of items that have different size when selected.

That's interesting. If state changes we need to redraw for sure, I thought
that's handled fine.

CC'ing myself.

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Piotr Caban  2011-07-21 11:20:32 CDT ---
Fixed by commit:
c47c62a802e28053cc3bf61f8114e49ab983d431

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-07-22 12:45:25 CDT ---
Closing bugs fixed in 1.3.25.

[Bug 27732] WinRAR became unusable since Wine 1.3.23, it constantly flashes and consumes 100% of CPU

http://bugs.winehq.org/show_bug.cgi?id=27732

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c47c62a802e28053cc3bf61f811
                   |                            |4e49ab983d431