[Bug 20761] New: Regression - Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

Summary: Regression - Riven pallet error
           Product: Wine
           Version: 1.1.33
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24839)
 --> (http://bugs.winehq.org/attachment.cgi?id=24839)
Example of pallet errors

Somewhere between 1.1.28 and 1.1.33 there was a regression in Riven that cause
the colour pallet in still images within the game to be corrupt/wrong. (See
attached image for example) Videos and the cursor are unaffected.
I did regression testing and came up with this:
6b8753185f30197047773af6a26eafd34d45367c is first bad commit
commit 6b8753185f30197047773af6a26eafd34d45367c
Author: Roderick Colenbrander 
Date:   Sat Sep 26 14:52:46 2009 +0200

winex11: Add support for 16-bit/32-bit DIB sections.

:040000 040000 f2d2821909d152a1d37ae2932bf6017d7b622344
74221a3bdd0b8be716ed4c7900a58fddc93a2f08 M    dlls

[Bug 20761] Regression - Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

David Rogers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Summary|Regression - Riven pallet   |Riven pallet error
                   |error                       |

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from GyB   2009-12-29 10:01:08 ---
*** This bug has been confirmed by popular vote. ***

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #2 from Roderick Colenbrander   2010-02-12 06:54:15 ---
Can you try to run the game using WINEDEBUG=+xrender and post that log here?

Thanks,
Roderick

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #3 from David Rogers   2010-02-12 07:23:50 ---
Created an attachment (id=26225)
 --> (http://bugs.winehq.org/attachment.cgi?id=26225)
WINEDEBUG=+xrender output

I just loaded the main menu then exited as the main menu shares the pallet
errors.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #4 from Roderick Colenbrander   2010-02-15 17:41:40 ---
Created an attachment (id=26263)
 --> (http://bugs.winehq.org/attachment.cgi?id=26263)
Fix

This patch likely fixes the problem. It fixes a similar bug in a game called
Nemesis.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #5 from Roderick Colenbrander   2010-02-16 13:05:19 ---
The fix is in GIT, so you can try that version to see if it works.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #6 from David Rogers   2010-02-16 14:58:31 ---
(In reply to comment #5)
> The fix is in GIT, so you can try that version to see if it works.

I downloaded and compiled the latest git wine but the pallet error still shows
up.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

--- Comment #7 from Roderick Colenbrander   2010-02-16 15:06:06 ---
Then this is a different error. From a quick glance in your case the colors
look more or less 'okay'. I guess the data is 16-bit and it is interpreted as
15-bit or the way around causing some color corruption.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from GyB   2010-04-13 13:17:14 ---
I've just tried the game (GoG.com version) with today's git
(wine-1.1.42-260-ge35f54e), colors are correct again. Don't know which commit
solved the problem, though.

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Roderick Colenbrander   2010-04-13 13:36:10 ---
If it was a patch from today which triggered it, it most likely was:
c29cf0591976f96c3adb30c3c3b6db59f4983251

Roderick

[Bug 20761] Riven pallet error

http://bugs.winehq.org/show_bug.cgi?id=20761

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2010-04-16 13:02:57 ---
Closing bugs fixed in 1.1.43.