[Bug 27636] New: Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Summary: Brigade E5 NEW jagged union do not run
           Product: Wine
           Version: 1.3.23
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=35331)
 --> (http://bugs.winehq.org/attachment.cgi?id=35331)
Log1

Log1 in attachements (WINEDEBUG=+relay wine ./e5.exe) clean prefix.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #1 from Roman D Zavalishin  2011-06-28 09:31:23 CDT ---
Created an attachment (id=35332)
 --> (http://bugs.winehq.org/attachment.cgi?id=35332)
Log2

Log2 in attachements (WINEDEBUG=+relay wine ./e5.exe) prefix with overrides dx
libraries.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #2 from Roman D Zavalishin  2011-06-28 09:34:05 CDT ---
Created an attachment (id=35334)
 --> (http://bugs.winehq.org/attachment.cgi?id=35334)
Game logs

Native Logs from game

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Ilya "FileJunkie" Ershov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Louis Lenders  2011-06-28 11:51:35 CDT ---
Does the same bug occur in the demo from here
http://download.direct2drive.com/ftp1/042006/brigadee5_public_demo.zip?clien...
??

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #4 from Roman D Zavalishin  2011-06-28 12:27:29 CDT ---
No. Demo version run in main menu, but when select new game it crush. My
version is 1.13 full. Do not run even main menu. But test from config file
(E5Config.exe) works good.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #5 from Austin English  2011-06-28 13:39:27 CDT ---
Please attach plain terminal output.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #6 from Roman D Zavalishin  2011-06-28 13:53:27 CDT ---
/home/games/E5$ wine ./E5
fixme:win:EnumDisplayDevicesW ((null),0,0x32f7ec,0x00000000), stub!
fixme:d3d:swapchain_init Add OpenGL context recreation support to
context_validate_onscreen_formats
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.
fixme:d3d:resource_check_usage Unhandled usage flags 0x8.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #7 from Roman D Zavalishin  2011-06-28 13:54:29 CDT ---
if need sone options or environments - tell me

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Michael Curran  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Michael Curran  2012-02-23 12:21:13 CST ---
I chased around this bug for a bit before, but I could never get it resolved.
Specifically, I lost the trail somewhere in the d3dxof module, as the Tutorial
was crashing while processing something handled by parsing.c

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Christian Costa  2012-02-24 07:18:39 CST ---
If there is something related to d3dxof please test with latest git. There is a
lot of improvements in that area.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #10 from Michael Curran  2012-02-24 18:42:37 CST ---
Created attachment 39047
  --> http://bugs.winehq.org/attachment.cgi?id=39047
Log with +d3dxof, d3dxof_parsing

Looks this we are making progress on this one. The game no longer crashes hard
and instead crashes through while parsing. I've attached a log, specifically
noting that:

warn:d3dxof:IDirectXFileEnumObjectImpl_GetNextDataObject Object is not correct

is the last warning before the crash.

My best guess from debugging one of these before (same program no less) is that
the developer is straining the limit of acceptable strings for names and
parameters in the load file.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Dan Kegel  2012-02-24 20:58:20 CST ---
Just for grins, does 'winetricks d3dxof' work around it?

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #12 from Michael Curran  2012-02-24 21:07:10 CST ---
Sadly not that easy, no luck with the native override.

Dumping the x files reveals that the program is aborting in the middle of
processing this element, aborting at the * and attempt to start processing a
new object.

SkinWeights {
  "Bip01";
  0;
-0.000003,*-2.199685,-0.000000,0.0,-0.000000,0.000000,2.199684,0.0,2.199685,-0.000003,0.000000,0.0,0.109992,-0.000005,-1.964378,1.0;;
}

The .x file is a total of 212 kb, but Wine is only allocating it 16890 bytes in
memory... so unless the compression is awesome, I think it might be running out
of allocated space.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #13 from Michael Curran  2012-02-24 21:22:51 CST ---
Actually, check that, it is reporting the file size correctly, it's just
stopping 3/4ths of the way through for some reason.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #14 from Michael Curran  2012-02-24 21:25:08 CST ---
Created attachment 39049
  --> http://bugs.winehq.org/attachment.cgi?id=39049
X file that is causing the crash

I've added a copy of the .x file created by d3dxof_dump

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #15 from Michael Curran  2012-02-24 22:42:36 CST ---
Okay, I figured out this problem, wrapping:

for (k = 0; k < nb_elems; k++)
{...}
if (buf->txt && (check_TOKEN(buf) != TOKEN_CBRACE) && (check_TOKEN(buf) !=
TOKEN_NAME))
buf->pxo->members[i].size = buf->cur_pos_data - buf->pxo->members[i].start;

inside of:

if (nb_elems > 0)
{}

resolves the d3dxof issues, but the program still crash when starting a new
game, without any useful feedback.

I'll hash out a patch tomorrow when I have some time.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #16 from Christian Costa  2012-02-25 05:25:23 CST ---
It's a regression I introduced with 07931f73f0544e067c5a86b4ac92723c11600dd3.
I have a patch and tests ready.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #17 from Christian Costa  2012-02-25 06:55:42 CST ---
Patch sent.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Michael Curran  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39047|0                           |1
        is obsolete|                            |

--- Comment #18 from Michael Curran  2012-02-25 09:39:02 CST ---
Created attachment 39068
  --> http://bugs.winehq.org/attachment.cgi?id=39068
New log with patch applies

Making progress, the patch submitted clears the error but now d3dxof seems to
hang on processing the next mesh. After the 212kb file is processed it attempts
to read the next file, never reports any parsing and ends up looping through
this section until the program crashes:

trace:d3dxof:IDirectXFileDataImpl_Create (0x32cbc8)
trace:d3dxof:IDirectXFileDataImpl_QueryInterface
(0x95c4518/0x95c4518)->({3d82ab44-62da-11cf-ab39-0020af71e433},0x32ccb0)
trace:d3dxof:IDirectXFileDataImpl_AddRef (0x95c4518/0x95c4518): AddRef from 1
trace:d3dxof:IDirectXFileDataImpl_GetType (0x95c4518/0x95c4518)->(0x32cc4c)
trace:d3dxof:IDirectXFileDataImpl_GetData
(0x95c4518/0x95c4518)->((null),0x32cc88,0x32ccd8)
trace:d3dxof:IDirectXFileDataImpl_Release (0x95c4518/0x95c4518): ReleaseRef to
1
trace:d3dxof:IDirectXFileDataImpl_Release (0x95c4518/0x95c4518): ReleaseRef to
0
trace:d3dxof:IDirectXFileDataImpl_GetNextObject
(0x95c1dd8/0x95c1dd8)->(0x32cca0)

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Michael Curran  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39068|0                           |1
        is obsolete|                            |

--- Comment #19 from Michael Curran  2012-02-25 10:55:30 CST ---
Created attachment 39071
  --> http://bugs.winehq.org/attachment.cgi?id=39071
Log after patch with WINEDEBUG="+d3dxof,d3d,tid,seh,relay,d3d8"

Looks like the d3dxof processing is completing without error and the program is
crashing somewhere between d3d and d3d8 function calls.

To find the crash in the above attachment, the is triggered at the first seh
trace.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

--- Comment #20 from Christian Costa  2012-03-20 15:43:55 CDT ---
Patch is in git now. This bug should be closed now. Enter a new bug for
remaining problems.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from Austin English  2012-03-20 16:01:17 CDT ---
(In reply to comment #20)
> Patch is in git now. This bug should be closed now. Enter a new bug for
> remaining problems.

Fixed.

[Bug 27636] Brigade E5 NEW jagged union do not run

http://bugs.winehq.org/show_bug.cgi?id=27636

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Alexandre Julliard  2012-03-30 13:34:49 CDT ---
Closing bugs fixed in 1.5.1.