[Bug 14946] New: Aliens vs Predator exits while starting game engine - regression

http://bugs.winehq.org/show_bug.cgi?id=14946

Summary: Aliens vs Predator exits while starting game engine -
                    regression
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Aliens vs Predator exits when starting the game engine from the startup menu.

Regression caused by commit c1bbab7c (draw: Send the ddraw output to the
clipper window, if any.)

http://source.winehq.org/git/wine.git/?a=commit;h=c1bbab7c54618935d74b7d2b70...

Other dx7 games have problems caused by this commit too:
Thief/Thief2 exit when swtching out of game's 3d engine, using the esc key to
go to in-game menu.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Andrew Charles Hurst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Summary|Aliens vs Predator exits    |Aliens vs Predator exits
                   |while starting game engine -|while starting game engine
                   |regression                  |

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jeff Zaroyko   2008-08-22 07:59:24 ---
(In reply to comment #0)
> Aliens vs Predator exits when starting the game engine from the startup menu.
>
> Regression caused by commit c1bbab7c (draw: Send the ddraw output to the
> clipper window, if any.)
>
> http://source.winehq.org/git/wine.git/?a=commit;h=c1bbab7c54618935d74b7d2b70...
>
> Other dx7 games have problems caused by this commit too:
> Thief/Thief2 exit when swtching out of game's 3d engine, using the esc key to
> go to in-game menu.

Also breaks Jedi Knight: Dark Forces II, using the esc key to go into the game
menu.  demo available here;
http://files.filefront.com/jedidemoexe/;845549;/fileinfo.html

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Andrew Charles Hurst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.fileshack.com/fil
                   |                            |e.x/871/Aliens+vs+Predator+P
                   |                            |redator+Demo
           Keywords|                            |download

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Vitaliy Margolen   2008-08-22 08:51:45 ---
Can you guys attach a terminal output?

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Stefan Dösinger   2008-08-22 09:20:37 ---
Please attach a ddraw,d3d,wgl,opengl,win log

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #4 from Andrew Charles Hurst   2008-08-22 17:44:45 ---
Created an attachment (id=15554)
 --> (http://bugs.winehq.org/attachment.cgi?id=15554)
output with +ddraw+d3d+opengl+wgl+win

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #5 from Andrew Charles Hurst   2008-08-22 17:45:26 ---
(From update of attachment 15554)
> From commit c1bbab7c

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #6 from Jeff Zaroyko   2008-08-22 19:23:55 ---
Created an attachment (id=15556)
 --> (http://bugs.winehq.org/attachment.cgi?id=15556)
+ddraw,+d3d,+opengl,+wgl,+win jkdemo

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Dimitar Boichev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Dimitar Boichev   2008-08-23 14:13:51 ---
Star Treck Bridge Commander is affected too. Demo:
http://download.activision.com/activision/stbdgcmd/demo/StarTrekBridgeComman...
But the game don't start at all... hitting the escape key desn't help.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #8 from Stefan Dösinger   2008-08-23 14:59:11 ---
There is no call to SetClipper or even CreateClipper in the logs. Are you sure
the regression test is ok?

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #9 from Dimitar Boichev   2008-08-23 15:50:01 ---
I've compiled wine without that patch ( git checkout
3d49e8cd5e3872c06c5b86f8d2bb0cc41d5ddfa9 )  and Star Trek Bridge Commander
works fine.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #10 from Stefan Dösinger   2008-08-23 16:33:16 ---
This is a different patch, which has no effect on ddraw apps as-is. If it
breaks something it is likely that wine wasn't recompiled properly. Can you try
a make distclean and rebuild wine?

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #11 from Dimitar Boichev   2008-08-23 16:46:33 ---
I know you have to checkout the previous patch to remove the next one here is
the buggy patch
http://source.winehq.org/git/wine.git/?a=commit;h=c1bbab7c54618935d74b7d2b70...

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #12 from Stefan Dösinger   2008-08-24 01:04:44 ---
Just for the record, I can reproduce this issue with AvP

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #13 from Stefan Dösinger   2008-08-24 01:04:55 ---
forgot to confirm

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #14 from Stefan Dösinger   2008-08-24 01:19:12 ---
I think I found it. The This->d3d_window move caused the swapchain destroying
code to destroy the application-owned window accidentally. I'll look at this
tomorrow and after my wine tree recompiled.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Andrew Charles Hurst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Andrew Charles Hurst   2008-08-26 16:20:51 ---
Fixed by this commit, I think:

http://source.winehq.org/git/wine.git/?a=commit;h=58ac095d9dc5f8e6776f7acf57...

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #16 from Stefan Dösinger   2008-08-26 16:47:36 ---
Yep, this patch was intended to fix this bug.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #17 from Jeff Zaroyko   2008-08-26 16:49:45 ---
(In reply to comment #16)
> Yep, this patch was intended to fix this bug.

confirmed fixed for Jedi Knight: Dark Forces II.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #18 from Dimitar Boichev   2008-08-27 07:32:30 ---
Star Trek Bridge Commander works now.
Thanks :)

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Athrun  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Athrun   2008-08-27 14:41:54 ---
*** Bug 15008 has been marked as a duplicate of this bug. ***

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #20 from Dimitar Boichev   2008-08-28 07:01:20 ---
Don't you think that after fixing this bug wine must put a patch. Something
like wine version 1.1.3.1 or something like that because there will be people
coming and downloading wine. And when then try to run an app affected by this
bug they will say "ohh wine still suck" and go back to windows.... I thing that
the current wine version in git should be made wine version 1.1.3.1 or wine
1.1.3 patched only with the patch fixing that bug should be wine 1.1.3.1. Don't
you thing so ?

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #21 from Andrew Charles Hurst   2008-08-28 07:55:06 ---
Dimitar,
Wine releases are made at regular intervals, which are usually very frequent
(less than one month between releases).
One single patch, even if it does fix several games is not sufficient cause to
deviate from this system.

Andy

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #22 from Austin English   2008-08-28 08:13:54 ---
(In reply to comment #20)
> Don't you think that after fixing this bug wine must put a patch. Something
> like wine version 1.1.3.1 or something like that because there will be people
> coming and downloading wine. And when then try to run an app affected by this
> bug they will say "ohh wine still suck" and go back to windows.... I thing that
> the current wine version in git should be made wine version 1.1.3.1 or wine
> 1.1.3 patched only with the patch fixing that bug should be wine 1.1.3.1. Don't
> you thing so ?

The next release will be a week from tomorrow.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #23 from Dimitar Boichev   2008-08-28 08:46:12 ---
Well I guess a week won't hurt so much. Thanks

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #24 from Andrew Charles Hurst   2008-08-28 12:29:56 ---
Yep,
I did try to mean "don't worry you won't have to wait long for the release",
not "how dare you ask for another release"! in my post above, but it doesn't
really sound like that :)

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #25 from Dimitar Boichev   2008-08-28 13:11:42 ---
Ohh I'm not worried I have the patched wine. I was thinking of the user
friendly side of the thinkg.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Michael Bonfils  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #26 from Michael Bonfils   2008-08-28 14:48:28 ---
*** Bug 15004 has been marked as a duplicate of this bug. ***

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #27 from Michael Bonfils   2008-08-28 14:49:37 ---
Wizardry 8 is also fixed :)

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

--- Comment #28 from Andrew Charles Hurst   2008-09-02 03:21:17 ---
For info: also broke Grim Fandango.
But now fixed.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #29 from Alexandre Julliard   2008-09-05 10:39:37 ---
Closing bugs fixed in 1.1.4.

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 14946] Aliens vs Predator exits while starting game engine

http://bugs.winehq.org/show_bug.cgi?id=14946

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d