[Bug 14642] New: mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

Summary: mIRC 6.33 hang up then IRC channel topic has unicode
                    char
           Product: Wine
           Version: 1.1.2
          Platform: PC-x86-64
               URL: http://www.mirc.com/get.html
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P1
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15063)
 --> (http://bugs.winehq.org/attachment.cgi?id=15063)
log

mIRC 6.33 hang up when IRC channel topic has unicode char.
Using wine 1.1.1 this bug not exist

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #1 from mero   2008-07-26 10:09:59 ---
Created an attachment (id=15064)
 --> (http://bugs.winehq.org/attachment.cgi?id=15064)
bt all

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #2 from mero   2008-07-26 10:20:39 ---
i can make regression test, but in what component is this bug ?

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

mero  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal
           Priority|P1                          |P2

--- Comment #3 from Vitaliy Margolen   2008-07-26 11:36:19 ---
Not a blocker.
Just do a full regression testing between versions that worked and now.

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #4 from mero   2008-07-27 08:58:00 ---
Created an attachment (id=15092)
 --> (http://bugs.winehq.org/attachment.cgi?id=15092)
regression test

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

mero  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

mero  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download                    |regression

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has unicode char

http://bugs.winehq.org/show_bug.cgi?id=14642

mero  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

mero  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|mIRC 6.33 hang up then IRC  |mIRC 6.33 hang up then IRC
                   |channel topic has unicode   |channel topic has ISO-8859-2
                   |char                        |char

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #5 from Dmitry Timoshkov   2008-07-28 00:34:27 ---
0d7d5ebf3b0a8c41fa4c37ebf4e3ec84ad9c9b1d is first bad commit
commit 0d7d5ebf3b0a8c41fa4c37ebf4e3ec84ad9c9b1d
Author: Aric Stewart 
Date:   Wed Jul 16 14:01:08 2008 +0900

mlang: Stub implementation of IMLangFontLink2.

:040000 040000 840542c46ad2d66b3857357d4ae901430f41c47d
d300ebaabfe09d8f056477f2e61f87cfb31e9975 M      dlls
:040000 040000 34307322ab5f47d4ae3df19699f40b94a203eecb
8011eecb0b33d52e9f5c056143edf4bae4247932 M      include

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #6 from Aric Stewart   2008-07-29 12:27:58 ---
fnIMLangFontLink2_GetStrCodePages is currently returning E_NOTIMPL. Which the
app may not be expecting.  Pretty much all of IMLangFontLink2 is unimplemented
at this time.

fnIMLangFontLink_GetStrCodePages is a stub that is doing:

*pdwCodePages = 0;
    *pcchCodePages = 1;
    return S_OK;

You could try seeing if changing the fnIMLangFontLink2_GetStrCodePages to the
same behavior helps your application.  Otherwise it may be needed to
investigate and implement more of IMLangFontLink2

-aric

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #7 from mero   2008-08-29 11:51:56 ---
changing what ?

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #8 from Aric Stewart   2008-08-29 12:04:03 ---
Created an attachment (id=15726)
 --> (http://bugs.winehq.org/attachment.cgi?id=15726)
Patch to test

Here try this patch. Tell me if it improves things. It implements the
suggestion I gave above.

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #9 from mero   2008-09-03 13:37:55 ---
this patch fix this bug :)

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #10 from mero   2008-09-08 20:26:51 ---
patch fixed bug, so what next ? now i must wait or what ?

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

--- Comment #11 from Austin English   2008-09-08 23:06:00 ---
(In reply to comment #8)
> Created an attachment (id=15726)

--> (http://bugs.winehq.org/attachment.cgi?id=15726) [details]
> Patch to test
>
> Here try this patch. Tell me if it improves things. It implements the
> suggestion I gave above.

Aric, have you sent your patch to [e-mail]?

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #12 from Aric Stewart   2008-09-09 07:13:41 ---
Patch sent.

(In reply to comment #11)
> (In reply to comment #8)
> > Created an attachment (id=15726)

--> (http://bugs.winehq.org/attachment.cgi?id=15726) [details] [details]
> > Patch to test
> >
> > Here try this patch. Tell me if it improves things. It implements the
> > suggestion I gave above.
>
> Aric, have you sent your patch to [e-mail]?

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

scguy318  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from scguy318   2008-09-25 02:04:28 ---
This patch was committed on September 10, 2008, so this bug should be closed.

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Vitaliy Margolen   2008-09-25 09:41:33 ---
Patch committed, closing.

[Bug 14642] mIRC 6.33 hang up then IRC channel topic has ISO-8859-2 char

http://bugs.winehq.org/show_bug.cgi?id=14642

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2008-10-10 10:10:15 ---
Closing bugs fixed in 1.1.6.