http://bugs.winehq.org/show_bug.cgi?id=35039
Bug #: 35039 Summary: Build broken when specifying a full path to configure Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: build-env AssignedTo: wine-bugs@winehq.org ReportedBy: mstefani@redhat.com Classification: Unclassified
The out of tree build with /full/patch/to/configure is broken in shell32 since:
commit bc9650392ab72551c583c89afe464a94837e9a7e Author: Alexandre Julliard julliard@winehq.org Date: Sat Nov 30 12:43:20 2013 +0100
makefiles: Include AUTHORS file directly from the top-level directory.
The error is: dlls/shell32$ make gcc -m32 -g -O2 -c -o appbar.o /home/mstefani/j/wine/source/wine/dlls/shell32/appbar.c /home/mstefani/j/wine/source/wine/dlls/shell32/appbar.c:21:20: fatal error: config.h: No such file or directory #include "config.h" ^ compilation terminated. make: *** [appbar.o] Error 1
There is no -I passed to gcc in shell32 (as well as other compiler flags).
To workaround the issue both commits bc9650392ab72551c583c89afe464a94837e9a7e and 202d046d685802640675651b3c039bf800e9732b need to be reverted.
http://bugs.winehq.org/show_bug.cgi?id=35039
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |bc9650392ab72551c583c89afe4 | |64a94837e9a7e
http://bugs.winehq.org/show_bug.cgi?id=35039
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #1 from Anastasius Focht focht@gmx.net 2013-12-03 05:46:34 CST --- Hello folks,
I get a different failure caused by same changeset (out-of-tree build).
--- snip --- ... make[1]: Entering directory `/home/focht/projects/wine/wine-build64/dlls/shell32' ../../tools/makedep -C/home/focht/projects/wine/wine-git/dlls/shell32 -S/home/focht/projects/wine/wine-git -T../.. -I/home/focht/projects/wine/wine-git appbar.c assoc.c autocomplete.c brsfolder.c changenotify.c classes.c clipboard.c control.c cpanelfolder.c dataobject.c dde.c debughlp.c dialogs.c dragdrophelper.c ebrowser.c enumidlist.c folders.c iconcache.c pidl.c recyclebin.c shell32_main.c shelldispatch.c shellitem.c shelllink.c shellole.c shellord.c shellpath.c shellreg.c shellstring.c shfldr_desktop.c shfldr_fs.c shfldr_mycomp.c shfldr_netplaces.c shfldr_printers.c shfldr_unixfs.c shlexec.c shlfileop.c shlfolder.c shlfsbind.c shlmenu.c shlview.c shlview_cmenu.c shpolicy.c systray.c trash.c xdg.c shell32.rc shell32_classes.idl shell32_tlb.idl
/home/focht/projects/wine/wine-git/dlls/shell32/shell32.rc:457: error: AUTHORS: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/focht/projects/wine/wine-build64/dlls/shell32' make: *** [dlls/shell32/Makefile] Error 2 --- snip ---
--- snip --- /* @makedep: AUTHORS */ AUTHORS RCDATA AUTHORS --- snip ---
strace of makedep shows:
--- snip --- ... 9542 open("/home/focht/projects/wine/wine-git/dlls/shell32/AUTHORS", O_RDONLY) = -1 ENOENT (No such file or directory) 9542 open("/home/focht/projects/wine/wine-git/include/AUTHORS", O_RDONLY) = -1 ENOENT (No such file or directory) 9542 open("/home/focht/projects/wine/wine-git/dlls/shell32/AUTHORS", O_RDONLY) = -1 ENOENT (No such file or directory) 9542 write(2, "/home/focht/projects/wine/wine-g"..., 71) = 71 9542 write(2, "AUTHORS: No such file or directo"..., 35) = 35 9542 exit_group(1) = ? 9542 +++ exited with 1 +++ --- snip ---
It seems "-I/home/focht/projects/wine/wine-git" was not taken into account?
Regards
http://bugs.winehq.org/show_bug.cgi?id=35039
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Build broken when |Wine out-of-source tree |specifying a full path to |build broken when |configure |specifying a full path to | |configure
--- Comment #2 from Anastasius Focht focht@gmx.net 2013-12-03 14:05:51 CST --- Hello folks,
for me the issue is fixed with commit http://source.winehq.org/git/wine.git/commitdiff/4674566ba4d9f523dd48bbe4af1... ("makedep: Allow the source directory itself in include paths.")
Does it work for you too, Michael? If yes, resolve the bug ...
Regards
http://bugs.winehq.org/show_bug.cgi?id=35039
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4674566ba4d9f523dd48bbe4af1 | |31c2a0b136394 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #3 from Michael Stefaniuc mstefani@redhat.com 2013-12-03 14:12:12 CST --- Yeah, it is fixed for me too.
http://bugs.winehq.org/show_bug.cgi?id=35039
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org 2013-12-06 13:44:33 CST --- Closing bugs fixed in 1.7.8.
-
wine-bugs＠winehq.org