[Bug 17851] New: WSAAddressToStringA AF_INET6 implementation missing

List overview All Threads

newer

older

[Bug 17904] New: Wine 1.1.18 and...

[Bug 17832] New: FEAR 1.08:...

wine-bugs＠winehq.org

25 Mar 2009 25 Mar '09

8:15 p.m.

http://bugs.winehq.org/show_bug.cgi?id=17851

Summary: WSAAddressToStringA AF_INET6 implementation missing Product: Wine Version: 1.0.1 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: winsock AssignedTo: wine-bugs@winehq.org ReportedBy: berni@birkenwald.de

The well-known Torrent client application uTorrent gained IPv6 support in Version 1.8. When running within the Wine environment it displays [<ERROR>] instead of the literal IPv6 address for peers.

According to http://forum.utorrent.com/viewtopic.php?pid=363137#p363137 uTorrent uses the WSAAddressToStringA function to format the address to a string. Looking into dlls/ws2_32/socket.c it's pretty obvious that the wine version only supports AF_INET (IPv4).

Please support AF_INET6 in that function.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

25 Mar 25 Mar

9:09 p.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Austin English austinenglish@gmail.com changed:

wine-bugs＠winehq.org

26 Mar 26 Mar

2:18 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Vitaliy Margolen vitaliy@kievinfo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other

wine-bugs＠winehq.org

8:47 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Kai Blin kai.blin@gmail.com changed:

--- Comment #1 from Kai Blin kai.blin@gmail.com 2009-03-26 03:47:56 --- Yup, we don't handle IPv6 in WSAAddressToStringA/W yet. Looking into this.

wine-bugs＠winehq.org

13 Apr 13 Apr

9:28 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Jeff L lats@yless4u.com.au changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lats@yless4u.com.au

--- Comment #2 from Jeff L lats@yless4u.com.au 2009-04-13 04:28:35 --- Kai, I did not see the bug. I have created a patch for this condition. Do you wnat to have a look?

wine-bugs＠winehq.org

10:14 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

--- Comment #3 from Kai Blin kai.blin@gmail.com 2009-04-13 05:14:54 --- Sure. Did you add some tests for this as well? That's where I got stuck.

wine-bugs＠winehq.org

10:28 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

--- Comment #4 from Jeff L lats@yless4u.com.au 2009-04-13 05:28:54 --- Yes I have some that I am fine tuning.

wine-bugs＠winehq.org

27 Apr 27 Apr

10 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Jeff L lats@yless4u.com.au changed:

--- Comment #5 from Jeff L lats@yless4u.com.au 2009-04-27 05:00:47 --- http://www.winehq.org/pipermail/wine-patches/2009-April/072343.html http://www.winehq.org/pipermail/wine-patches/2009-April/072344.html

implement the IPv6 code to fix this bug.

wine-bugs＠winehq.org

9:35 p.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

--- Comment #6 from Bernhard Schmidt berni@birkenwald.de 2009-04-27 16:35:36 --- Created an attachment (id=20761) --> (http://bugs.winehq.org/attachment.cgi?id=20761) µTorrent 1.8.3 screenshot

Jeff,

thanks for creating the patch. Unfortunately it seems to have some issue, as it is printing out bogus information in µTorrent.

Connections according to ss/netstat:

ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:56374 2002:4e5a:3338::4e5a:3338:34932 users:(("uTorrent.exe",21482,44),("wineserver",21485,94)) ESTAB 0 53876 2001:a60:f001:1:219:66ff:fe8b:a6e:48277 2002:775e:1ce9::775e:1ce9:19033 users:(("uTorrent.exe",21482,42),("wineserver",21485,92)) ESTAB 0 19996 2001:a60:f001:1:219:66ff:fe8b:a6e:53254 2002:5ebf:a61b::5ebf:a61b:17897 users:(("uTorrent.exe",21482,43),("wineserver",21485,93)) ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:44704 2002:4bbb:3dc8::4bbb:3dc8:57324 users:(("uTorrent.exe",21482,39),("wineserver",21485,61))

I applied the four patches to the Ubuntu PPA package of Wine 1.1.20

wine-bugs＠winehq.org

28 Apr 28 Apr

8:41 a.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

Jeff L lats@yless4u.com.au changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #7 from Jeff L lats@yless4u.com.au 2009-04-28 03:41:04 --- (In reply to comment #6)

...

Created an attachment (id=20761)

--> (http://bugs.winehq.org/attachment.cgi?id=20761) [details]

...

µTorrent 1.8.3 screenshot

Jeff,

thanks for creating the patch. Unfortunately it seems to have some issue, as it is printing out bogus information in µTorrent.

Connections according to ss/netstat:

ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:56374 2002:4e5a:3338::4e5a:3338:34932 users:(("uTorrent.exe",21482,44),("wineserver",21485,94)) ESTAB 0 53876 2001:a60:f001:1:219:66ff:fe8b:a6e:48277 2002:775e:1ce9::775e:1ce9:19033 users:(("uTorrent.exe",21482,42),("wineserver",21485,92)) ESTAB 0 19996 2001:a60:f001:1:219:66ff:fe8b:a6e:53254 2002:5ebf:a61b::5ebf:a61b:17897 users:(("uTorrent.exe",21482,43),("wineserver",21485,93)) ESTAB 0 0 2001:a60:f001:1:219:66ff:fe8b:a6e:44704 2002:4bbb:3dc8::4bbb:3dc8:57324 users:(("uTorrent.exe",21482,39),("wineserver",21485,61))

I applied the four patches to the Ubuntu PPA package of Wine 1.1.20

I changed inet_ntop to WS_inet_ntop which meant that those patches were dependent on the following. The following patches have just been accepted into the tree and should fix the problem.

http://www.winehq.org/pipermail/wine-cvs/2009-April/054960.html http://www.winehq.org/pipermail/wine-cvs/2009-April/054961.html

wine-bugs＠winehq.org

7:17 p.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

--- Comment #8 from Bernhard Schmidt berni@birkenwald.de 2009-04-28 14:17:04 --- okay, _almost_ fixed :-)

With those additional two patches the IP addresses in the peers tab are okay now, but the ones in the detailled logging aren't.

[2009-04-28 21:11:08] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.8)]: Got Have 616 [2009-04-28 21:12:06] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.8)]: Got Have 825 [2009-04-28 21:12:48] [2001:0:d5c7:a2d6:0:b136:a274:8421]:60671: [BitTorrent 6.1.2 (51.9)]: Got Have 782 [2009-04-28 21:12:54] Incoming connection from [2bb1:c67b:f46f:807e:ece9:8c00::]:1792 [2009-04-28 21:13:19] [2001:0:cf2e:3096:0:fbd9:8354:d3f3]:48176: [µTorrent 1.8.2 (100.0)]: Sending 4 bytes of aggregated data

the addresses with "Incoming connection" are broken, the other ones are fine. I suspect they use a different function to print it, do you see anything obvious in the code?

wine-bugs＠winehq.org

8:49 p.m.

New subject: [Bug 17851] WSAAddressToStringA AF_INET6 implementation missing

http://bugs.winehq.org/show_bug.cgi?id=17851

--- Comment #9 from Bernhard Schmidt berni@birkenwald.de 2009-04-28 15:49:42 --- Disregard the last report for now.

[2009-04-28 22:03:31] Incoming connection from [2bb1:c67b:f46f:807e:ece9:8c00::]:1792 [2009-04-28 22:07:07] Incoming connection from [2001:0:d5c7:a2d6:34a4:2c32:ae28:5d07]:59126 [2009-04-28 22:07:07] [2001:0:d5c7:a2d6:34a4:2c32:ae28:5d07]:59126: [Mainline 6.1.2 (0.0)]: Handshake completed [2009-04-28 22:11:44] Incoming connection from [2001:0:cf2e:3096:0:fbd9:8354:d3f3]:2174

As you can see there are cases where the neighbor IP is correctly printed. I also ran tcpdump and could not register a single IPv6 connection attempt when the event happened. Neither did the firewall.

So I'd say the code is good. Thanks a lot.