[Bug 20963] New: CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

Summary: CIV4(BTS)/steam crashes at launch after upgrade
                    wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1
           Product: Wine
           Version: 1.1.34
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After applying the following Update Manager upgrade on Ubuntu 9.10 amd64:
bind9-host (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
devicekit-disks (007-2ubuntu3) to 007-2ubuntu4
dnsutils (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
gnome-screensaver (2.28.0-0ubuntu3) to 2.28.0-0ubuntu3.1
google-chrome-unstable (4.0.249.22-r33427) to 4.0.249.30-r33928
libbind9-50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
libdns50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
libisc50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
libisccc50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
libisccfg50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
liblwres50 (1:9.6.1.dfsg.P1-3) to 1:9.6.1.dfsg.P1-3ubuntu0.2
ttf-symbol-replacement (1.1.33-0ubuntu1~ppa1) to 1.1.34-0ubuntu1
ttf-tahoma-replacement (1.1.33-0ubuntu1~ppa1) to 1.1.34-0ubuntu1
wine-gecko (1.1.33-0ubuntu1~ppa1) to 1.1.34-0ubuntu1
wine1.2 (1.1.33-0ubuntu1~ppa1) to 1.1.34-0ubuntu1
[Commit Log for Tue Dec  8 07:46:37 2009]

Steam launched properly but CIV4BTS Blanked the screen and locked the system.

In prior version, CIVBTS worked fine (better than on Vista/WinXP actually)

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #1 from Austin English   2009-12-08 14:26:45 ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #2 from Larry Johnson   2009-12-10 11:56:49 ---
Created an attachment (id=25158)
 --> (http://bugs.winehq.org/attachment.cgi?id=25158)
bisect_log

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #3 from Larry Johnson   2009-12-10 12:00:53 ---
Created an attachment (id=25159)
 --> (http://bugs.winehq.org/attachment.cgi?id=25159)
termout

This is the terminal out from the last bisect attempt to run CIV4BTS/steam

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #4 from Larry Johnson   2009-12-10 12:02:40 ---
Hope this helps.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #5 from Juan Lang   2009-12-10 12:27:28 ---
Your regression test resulted in:
user@ubuntuKARMIC64:~/wine-git$ git bisect bad
2203264bfa40ea3ad532090fdd40b0196fb2e303 is first bad commit
commit 2203264bfa40ea3ad532090fdd40b0196fb2e303
Author: Vincent Povirk 
Date:   Thu Nov 12 12:34:05 2009 -0600

ole32: Rename propertyType to stgType.

You need to try again, this didn't have any functional changes at all, it just
renamed a variable.  If you revert this patch, does it work?

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #6 from Larry Johnson   2009-12-10 19:05:59 ---
Created an attachment (id=25164)
 --> (http://bugs.winehq.org/attachment.cgi?id=25164)
bisect_log

successful bisect

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

Larry Johnson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |keepitsimpleengineer@gmail.
                   |                            |com

--- Comment #7 from Larry Johnson   2009-12-10 19:15:24 ---
3cedef2ffea3a72d9717470f01a3a046db923e4b is first bad commit
commit 3cedef2ffea3a72d9717470f01a3a046db923e4b
Author: Henri Verbeet 
Date:   Fri Dec 4 11:50:46 2009 +0100

d3d8: Simplify GetDevice().

We already store "parentDevice", so we might as well use it.

:040000 040000 028027d1ba5bfd55a2b118aba1863625d17487c7
ccebe44be5e36f17c326a41100c911a49651f50f M    dlls

UNABLE TO ADD Henri Verbeet  to CC list

Note: wine-1.1.34 and wine-1.1.33 failed to compile on Ubuntu 9.10 amd64 system
due to the following bug in mpegl3.c

mpg123_feedseek(aad->mh, 0, SEEK_SET, NULL);

⋯was replaced with⋯

mpg123_feedseek_64(aad->mh, 0, SEEK_SET, NULL);

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #8 from Henri Verbeet   2009-12-11 04:56:09 ---
(In reply to comment #7)
> 3cedef2ffea3a72d9717470f01a3a046db923e4b is first bad commit
> commit 3cedef2ffea3a72d9717470f01a3a046db923e4b
> Author: Henri Verbeet 
> Date:   Fri Dec 4 11:50:46 2009 +0100
> d3d8: Simplify GetDevice().
>
> We already store "parentDevice", so we might as well use it.
>
> :040000 040000 028027d1ba5bfd55a2b118aba1863625d17487c7
> ccebe44be5e36f17c326a41100c911a49651f50f M    dlls

That should have been fixed by 179cee08b043105da85fd9ffa87f1138f2534a7a, did
you try with current git?

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #9 from Larry Johnson   2009-12-11 09:18:47 ---
The app failed with both:
 ubuntu 1.1.34-ubuntu1 from repository; and 
 wine-1.1.34 from wine.git with the mpegl3.c bug fixed.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #10 from Henri Verbeet   2009-12-11 09:22:04 ---
(In reply to comment #9)
> The app failed with both:
>  ubuntu 1.1.34-ubuntu1 from repository; and 
>  wine-1.1.34 from wine.git with the mpegl3.c bug fixed.

Yes, but that's not what I asked. How does it behave with git versions after
179cee08b043105da85fd9ffa87f1138f2534a7a?

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #11 from Larry Johnson   2009-12-11 09:42:28 ---
(In reply to comment #10)
> (In reply to comment #9)
> > The app failed with both:
> >  ubuntu 1.1.34-ubuntu1 from repository; and 
> >  wine-1.1.34 from wine.git with the mpegl3.c bug fixed.
>
> Yes, but that's not what I asked. How does it behave with git versions after
> 179cee08b043105da85fd9ffa87f1138f2534a7a?

I don't know.

The ubuntu 1.1.34-0ubuntu1 version failed to run the app.  1.1.33-0ubuntu1~ppa1
did run the app.

I finally discovered the bug preventing compilation on amd64, ran the bisect as
requested.

I am not a developer.  I have years of experience but not with kernel related
development.  I have had 2 days experience with git.

If you have a specific request for testing, I will be glad to do it.

I have both 32 and 64 bit Karmic systems.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #12 from Henri Verbeet   2009-12-11 10:05:52 ---
http://wiki.winehq.org/RegressionTesting#head-05e42bb1e9c9659783d6280064efa1...
or http://wiki.winehq.org/GitWine might be useful to you. Basically you do

git bisect reset
git fetch
git rebase origin

and make a build. You can also just wait for the 1.1.35 release, but that's
expected for next week Friday.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #13 from Larry Johnson   2009-12-11 10:40:16 ---
(In reply to comment #12)
> http://wiki.winehq.org/RegressionTesting#head-05e42bb1e9c9659783d6280064efa1...
> or http://wiki.winehq.org/GitWine might be useful to you. Basically you do
>
> git bisect reset
> git fetch
> git rebase origin
>
> and make a build. You can also just wait for the 1.1.35 release, but that's
> expected for next week Friday.

I followed the process at
http://wiki.winehq.org/RegressionTesting#head-efe98a3aade37d2588b7f64cb72cc2...

git bisect start
git bisect good wine-1.1.33
git bisect bad wine-1.1.34
compile-test-git bisect good/bad=repeat until…

The first bisect regression failed probably because of the mpegl3.c.  The
second seemed successful.  The bisect logs were attached.

My current resources are:
http://wiki.winehq.org/RegressionTesting
http://source.winehq.org/git/?p=wine.git;a=tags
http://wiki.winehq.org/WineOn64bit#head-d0fe1b547cf65ae6e1b166debd309bd5189a...
http://ubuntuforums.org/showthread.php?p=8285328
file:///usr/share/doc/git-doc/git.html
file:///usr/share/doc/git-doc/user-manual.html
file:///usr/share/doc/git-doc/user-manual.html#git-quick-start
file:///usr/share/doc/git-doc/everyday.html
file:///usr/share/doc/git-doc/gittutorial.html
http://wiki.winehq.org/winetricks
http://wiki.winehq.org/WineOn64bit
http://wiki.winehq.org/GitWine

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #14 from Juan Lang   2009-12-11 10:47:58 ---
You did the regression right the second time around.  It was a regression
introduced between 1.1.33 and 1.1.34--we got that.  Henri says it's been fixed,
and he's asking, have you tried with the current git head?

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #15 from Austin English   2009-12-11 12:47:09 ---
(In reply to comment #14)
> You did the regression right the second time around.  It was a regression
> introduced between 1.1.33 and 1.1.34--we got that.  Henri says it's been fixed,
> and he's asking, have you tried with the current git head?

In case that's not clear, Juan/Henri are asking you to try:
$ git fetch ; git rebase origin
$ ./configure && make depend && make

then retest, to see if the problem is already fixed in the latest wine.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #16 from Larry Johnson   2009-12-11 12:56:50 ---
> then retest, to see if the problem is already fixed in the latest wine.

Today will do, in a little while.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

--- Comment #17 from Larry Johnson   2009-12-11 14:59:35 ---
(In reply to comment #16)
> Today will do, in a little while.

Recreated wine-git, fetch, rebase and compiled.

Compile failed, due to the bug in mpegl3.c

made this cgage
@LINE 401 IN mpegl3.c
 /***********************************************************************
*        Replced to allow compile on 64bit computer 
*   mpg123_feedseek(aad->mh, 0, SEEK_SET, NULL);
*
*/
    mpg123_feedseek_64(aad->mh, 0, SEEK_SET, NULL);

Recompiled, compile succeeded, app tested, worked O.K.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Juan Lang   2009-12-11 15:29:04 ---
Fixed then.

[Bug 20963] CIV4(BTS)/steam crashes at launch after upgrade wine1.2 1.1.33-0ubuntu1~ppa1 to 1.1.34-0ubuntu1

http://bugs.winehq.org/show_bug.cgi?id=20963

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard   2009-12-18 13:08:12 ---
Closing bugs fixed in 1.1.35.