https://bugs.winehq.org/show_bug.cgi?id=40201
Bug ID: 40201 Summary: EccoPro only works on Wine 1.6.2 Product: Wine Version: 1.9.3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: tim.c.quinn@gmail.com Distribution: ---
Created attachment 53710 --> https://bugs.winehq.org/attachment.cgi?id=53710 wine eccoext.exe output
Ecco Pro 4.01 only works on Wine 1.6.2 and fails to run on any later version.
Installation instructions for getting a static installation of ecco pro is here: http://nixplayground.blogspot.ca/2015/02/installing-ecco-pro-401-in-linux-us...
I have run through eccoext.exe and ecco32.exe on later versions and they fail in all cases.
I have tested on the following systems: * Ubuntu 14.04.4 x64 * Ubuntu 15.10 * Opensuse 42.1
I will attach the outputs for each of the following tests: 1) % wine eccoext.exe --> eccoext_output.txt 2) % winedbg ecco32.exe --> ecco32_output.txt
Test 3) % wine ecco32.exe just results in a dialog "An application error has occurred. Please exit Ecco and restart"
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #1 from Timothy C. Quinn tim.c.quinn@gmail.com --- Created attachment 53711 --> https://bugs.winehq.org/attachment.cgi?id=53711 winedbg ecco32.exe output
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #2 from Timothy C. Quinn tim.c.quinn@gmail.com --- Information about EccoPro can be found here: http://creativeservices.us/wikipedia.html
Original 32 bit installer from site labeled 401e32.zip
Ecco Pro is one of the most popular Win32 productivity programs out there and would be great to have ongoing support.
https://bugs.winehq.org/show_bug.cgi?id=40201
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |sebastian@fds-team.de
--- Comment #3 from Sebastian Lackner sebastian@fds-team.de --- A regression test will be needed to find out which commit exactly introduced the error. See https://wiki.winehq.org/RegressionTesting for more details.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #4 from Timothy C. Quinn tim.c.quinn@gmail.com --- Understood. I have been able to get it working on wine-1.7.28 on opensuse. I will keep narrowing in on the version that breaks Ecco Pro.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #5 from Timothy C. Quinn tim.c.quinn@gmail.com --- I've narrowed the issue down to version 1.7.44 which broke ecco32.exe functionality. 1.7.43 worked ok.
Couple of questions: 1) Should I now run a Bisection as per Regression testing docs? 2) What is the ideal linux distribution for building and testing 32bit wine?
https://bugs.winehq.org/show_bug.cgi?id=40201
Sagawa sagawa.aki+winebugs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs@gmail.c | |om
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #6 from Rosanne DiMesio dimesio@earthlink.net --- (In reply to Timothy C. Quinn from comment #5)
Couple of questions:
- Should I now run a Bisection as per Regression testing docs?
Yes
- What is the ideal linux distribution for building and testing 32bit wine?
It will be easiest on the 32 bit version of any distro.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #7 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 53879 --> https://bugs.winehq.org/attachment.cgi?id=53879 proposed patch
I can confirm the issue. Could you apply this patch and choose Windows 98 in winecfg? On my environment, it works now.
sha1(401e32.zip) = a68cdd2634dd72278a1b6f6ef0ffba61b555d441
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #8 from Timothy C. Quinn tim.c.quinn@gmail.com --- Should I apply patch to 1.7.44 or a later version?
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #9 from Sagawa sagawa.aki+winebugs@gmail.com --- Please apply to the latest wine-git or at least wine-1.9.5.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #10 from Timothy C. Quinn tim.c.quinn@gmail.com --- Proposed patch fixed the issue. I was able to get ecco32.exe to launch correctly on wine-1.9.5.
$ cat /proc/version Linux version 4.4.3-300.fc23.i686 (mockbuild@bkernel02.phx2.fedoraproject.org) (gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC) ) #1 SMP Fri Feb 26 19:16:05 UTC 2016
I also applied EccoExtension (http://eccopro.com/ecco-extension/) and was able to launch eccoext.exe as well. First try did not work but second one stuck.
Note: ecco32.exe does have intermittent issues with starting but this occurs with any version of wine. I'll raise a separate bug in the future to see if we can nail that one down later on.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #11 from Sagawa sagawa.aki+winebugs@gmail.com --- Thanks for testing. git bisect shows this is a regression introduced by 817d903cb97a1c088eecd0574745d8274726e912.
My previous patch completely ignores class and class_len arguments, but it seems to be wrong. So, I'll refine my patch.
https://bugs.winehq.org/show_bug.cgi?id=40201
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.faber@reactos.org Regression SHA1| |817d903cb97a1c088eecd057474 | |5d8274726e912
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #12 from Sagawa sagawa.aki+winebugs@gmail.com --- I sent revised patch to wine-patches: https://source.winehq.org/patches/data/120190
Windows 9x (and Windows 9x compatibility mode in Windows 7) doesn't touch class buffer at all.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #13 from Timothy C. Quinn tim.c.quinn@gmail.com --- Thank you for patching =)
Patch 120190 worked ok for both ecco32.exe and eccoext.exe.
Steps I followed:
- $ sudo make uninstall - $ make clean && make distclean - Reverted original patch - Applied new patch - $ ./configure && make depend && make && make install
I reused the same WINEPREFIX from the previous test.
[Q] Should I build a new WINEPREFIX to test this patch?
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #14 from Sagawa sagawa.aki+winebugs@gmail.com --- No, you don't have to update WINEPREFIX for this case.
https://bugs.winehq.org/show_bug.cgi?id=40201
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x Fixed by SHA1| |303daeef58b7fe56ef991dde850 | |4d65c11924937 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #15 from Alexandre Julliard julliard@winehq.org --- It should be fixed by 303daeef58b7fe56ef991dde8504d65c11924937.
https://bugs.winehq.org/show_bug.cgi?id=40201
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |advapi32
https://bugs.winehq.org/show_bug.cgi?id=40201
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.6.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #17 from Timothy C. Quinn tim.c.quinn@gmail.com --- Thank you all for your feedback and assistance with getting this patched. The EccoPro community appreciates your work.
- Tim
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #18 from Timothy C. Quinn tim.c.quinn@gmail.com --- Should I be recommending that users target Windows 98 in winecfg to run ecco32.exe going forward?
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #19 from Sagawa sagawa.aki+winebugs@gmail.com --- You can safely remove winecfg settings for ecco32.exe because the root cause doesn't depend on windows version. I misunderstood the cause and AJ fixed this issue instead of me. Sorry for your confusion.
https://bugs.winehq.org/show_bug.cgi?id=40201
--- Comment #20 from Timothy C. Quinn tim.c.quinn@gmail.com --- No problem at all. Thanks again.
https://bugs.winehq.org/show_bug.cgi?id=40201
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #21 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.2.