[Bug 33606] New: Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

Bug #: 33606
           Summary: Spin Tires rendering issue
           Product: Wine
           Version: 1.5.30
          Platform: x86
               URL: http://www.oovee.co.uk/spintire-download-mirrors/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified

Created attachment 44486
  --> http://bugs.winehq.org/attachment.cgi?id=44486
screenshot

Demo has a dirt rendering issue like on the screenshot. This string repeats in
a terminal while playing: err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>>
GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 5818

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #1 from Andrey Gusev  2013-05-29 11:22:11 CDT ---
New version of beta from 24.05 on 1.5.31 still have issue but now 5818 changed
to 5813.

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #2 from Andrey Gusev  2013-06-14 08:33:22 CDT ---
Version from 06.06 and 1.6-rc1

err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from glUseProgramObjectARB @ glsl_shader.c / 6087
fixme:d3d_surface:surface_load_location Unimplemented copy from 0 to
SFLAG_INTEXTURE for depth/stencil buffers.
err:d3d_surface:surface_modify_location Surface 0x11289600 does not have any up
to date location.

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #3 from Andrey Gusev  2013-06-15 12:00:39 CDT ---
1.6-rc2

err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from glUseProgramObjectARB @ glsl_shader.c / 6172

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #4 from Andrey Gusev  2013-06-20 04:41:59 CDT ---
Created attachment 44881
  --> http://bugs.winehq.org/attachment.cgi?id=44881
dirt screenshot

Should be like this.

[Bug 33606] Spin Tires rendering issue

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|directx-d3d                 |directx-d3dx9

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Spin Tires rendering issue  |Spin Tires a wrong dirt
                   |                            |rendering

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44486|screenshot                  |wine screenshot
        description|                            |

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44881|dirt screenshot             |windows screenshot
        description|                            |

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Dan Kegel  2013-06-22 10:15:18 CDT ---
So what's the problem -- there are supposed to be little chunks of dirt
flying in the air, and that doesn't happen on wine?

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #6 from Andrey Gusev  2013-06-22 11:31:08 CDT ---
(In reply to comment #5)
> So what's the problem -- there are supposed to be little chunks of dirt
> flying in the air, and that doesn't happen on wine?

No, Dan, doesn't happen. I did try yesterday on 1.6-rc3 and issue still
present.

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #7 from Dan Kegel  2013-06-22 12:04:07 CDT ---
I don't understand.  Can you describe the difference between those two
pictures?

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #8 from Nikolay Sivov  2013-06-22 12:22:09 CDT ---
I guess it's about a black areas that supposedly should be dirt animation of
some kind.

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #9 from Andrey Gusev  2013-06-22 12:37:16 CDT ---
(In reply to comment #7)
> I don't understand.  Can you describe the difference between those two
> pictures?

Did you try a demo? A little chunks of dirt flying in the air should be instead
of a black "squares".

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Christian Costa  2013-06-23 07:20:55 CDT ---
I confirm dirt/mud is not rendered correctly. black squares are displayed
instead.
I have to use native msvcr90 & d3dx9_36 dlls.
Is this line
err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from glUseProgramObjectARB @ glsl_shader.c / 6172
the only thing you got from the log?

I have some:
fixme:d3d_shader:shader_glsl_get_ffp_fragment_op_arg Per-stage constants not
implemented.
fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #8:
fixme:d3d_shader:print_glsl_info_log     0(12) : error C1008: undefined
variable "const0"
fixme:d3d_shader:shader_glsl_validate_link Program 9 link status invalid.

and a lot of:
err:d3d:wined3d_debug_callback 0x1bc4c8: "GL_INVALID_OPERATION error generated.
<program> object is not successfully linked, or is not a program object.".
which is the result of the first problem.

It seems the only interesting line is:
fixme:d3d_shader:shader_glsl_get_ffp_fragment_op_arg Per-stage constants not

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #11 from Andrey Gusev  2013-06-23 08:10:08 CDT ---
(In reply to comment #10)
> Is this line
> err:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from glUseProgramObjectARB @ glsl_shader.c / 6172
> the only thing you got from the log?

Yes, just this line has repeating while playing.

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #12 from Christian Costa  2013-06-23 10:16:38 CDT ---
Can you attach the log?

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #13 from Andrey Gusev  2013-06-23 11:53:12 CDT ---
Created attachment 44924
  --> http://bugs.winehq.org/attachment.cgi?id=44924
log

Christian, my fault, actually log has the same strings as you have.

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #14 from Christian Costa  2013-06-23 13:19:26 CDT ---
Created attachment 44926
  --> http://bugs.winehq.org/attachment.cgi?id=44926
Fix text display

I implemented per-stage constants handling. This fixes text display in the main
menu (ESC) and the popup when you click rescue and a lot of output errors.
Please give it a try.

The dirt effect is still missing. The remaining output errors are:
fixme:d3d_surface:surface_load_location Unimplemented copy from 0 to
SFLAG_INTEXTURE for depth/stencil buffers.
err:d3d_surface:surface_modify_location Surface 0x12ad5950 does not have any up
to date location.
err:d3d:state_undefined Undefined state.
err:d3d:state_undefined Undefined state.

I guess the surface errors are related to the dirt effect.

[Bug 33606] Spin Tires a wrong dirt rendering

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #15 from Andrey Gusev  2013-06-23 16:02:42 CDT ---
Christian, confirming, after applying your patch, I can change demo settings.

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Spin Tires a wrong dirt     |Spin Tires a wrong dirt
                   |rendering                   |rendering and black menu
                   |                            |with missing text

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-d3dx9               |directx-d3d

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #16 from Andrey Gusev  2013-08-01 10:06:03 CDT ---
I think bug 34010 is also somehow related.

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Anton Reshetnikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Anton Reshetnikov  2013-08-08 00:51:36 CDT ---
(In reply to comment #16)
> I think bug 34010 is also somehow related.

How to install the patch? )

Andrey, podskazhi pozhaluista, kak ustanovit` patch?

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #18 from Anton Reshetnikov  2013-08-08 01:02:47 CDT ---
everything is OK, I kind of figured.

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #19 from Andrey Gusev  2013-08-08 02:38:01 CDT ---
(In reply to comment #17)
> How to install the patch? )
>
> Andrey, podskazhi pozhaluista, kak ustanovit` patch?

Updated patch here http://source.winehq.org/patches/data/97483

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #20 from Andrey Gusev  2013-10-30 08:42:38 CDT ---
Still in 1.7.5
Please recommit the patch.

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

--- Comment #21 from Andrey Gusev  ---
Still in 1.7.11

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.oovee.co.uk/spin |http://oovee.chicsystems.ne
                   |tire-download-mirrors/      |t/SpinTiresInstall_060613.z
                   |                            |ip

[Bug 33606] Spin Tires a wrong dirt rendering and black menu with missing text

http://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #22 from Andrey Gusev  ---
Still in 1.7.16

[Bug 33606] Spin Tires: black menu with missing text (per-stage constants handling needed)

http://bugs.winehq.org/show_bug.cgi?id=33606

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Spin Tires a wrong dirt     |Spin Tires: black menu with
                   |rendering and black menu    |missing text (per-stage
                   |with missing text           |constants handling needed)

--- Comment #23 from Anastasius Focht  ---
Hello folks,

refining summary to target one problem (per-stage constants not implemented).

Regards

[Bug 33606] Spin Tires: black menu with missing text (per-stage constants handling needed)

https://bugs.winehq.org/show_bug.cgi?id=33606

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |23eed88fdedbbb7be67c60db369
                   |                            |a09fcc00a2602
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #24 from Andrey Gusev  ---
Fixed by commit
http://source.winehq.org/git/wine.git/commit/23eed88fdedbbb7be67c60db369a09f...

[Bug 33606] Spin Tires: black menu with missing text (per-stage constants handling needed)

https://bugs.winehq.org/show_bug.cgi?id=33606

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.18.