[Bug 48233] New: In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

Bug ID: 48233
           Summary: In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns
                    a darker value than on windows
           Product: Wine
           Version: 3.6
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 65879
  --> https://bugs.winehq.org/attachment.cgi?id=65879
Screenshot, showing shadow drawn with GetSysColor(COLOR_BTNSHADOW)

I recently converted my 32-bit app to 64-bits, and when I run either the 32-bit
version or the 64-bit version under a wine64 WINEPREFIX, the only difference I
notice is the value returned by GetSyscolor(COLOR_BTNSHADOW).  On Windows in
both the WIN32 and WIN64 versions of my app, it returns 0xa0a0a0, but on
WINE64, it returns 0x4c4c4c.

On WINE, I'm using the Ubuntu Light theme.  With that theme in effect, on
WINE32, GetSysColor(COLOR_BTNSHADOW) returns 0xa5a9ad.  But on WINE64, both the
WIN32 and WIN64 versions get 0x4c4c4c.  So the shadow looks too dark.  Again,
the WIN32 exe gets the right color under WINE32, but the same wrong color as
the WIN64 exe under WINE64 - which is why I think it's a WINE64 bug and not my
app.

Everything else seems to look the same between WINE32 and WINE64.

The attached screenshot shows the About dialog from my app.  There's a 3D frame
around the logo at the top - BTNSHADOW on top and left, BTNHIGHLIGHT on bottom
and right.  The text below it shows that this is the X64 version of the app,
and prints out the value returned by GetSysColor(COLOR_BTNSHADOW).

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #1 from Nikolay Sivov  ---
Does it return same colors when you run it in clean wineprefix without any
themes?

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #2 from [e-mail] ---
(In reply to Nikolay Sivov from comment #1)
> Does it return same colors when you run it in clean wineprefix without any
> themes?

With no theme enabled GetSyscolor(COLOR_BTNSHADOW) returns 0x808080 in all
cases - wine32 and wine64 running both 32- and 64-bit binaries.

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #3 from Nikolay Sivov  ---
Maybe values are set only for 32-bit branches, and not for both, I don't know.

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #4 from [e-mail] ---
Funny.  Having disabled the theme - and then re-enabled it, the darker shadow
color is now showing up under both 32- and 64-bit WINE.  There must be
something wrong with the theme file I'm using.

But I think it's the same 'Ubuntu light' theme that I had originally enabled. 
I.e., I simply picked it from the pull-down list on the winecfg 'Desktop
Integration' tab to re-enable it.

I had originally enabled this theme years ago in my plain .wine WINEPREFIX, and
only recently set up the .wine64 prefix.  So, maybe the code to *apply* the
theme in WINE is what's messing up.  Again, the shadow color in WINE32 *used*
to look right, but now it looks too dark in both WINE32 and WINE64...

I guess it's possible that when I re-imported the theme to set up .wine64 I
pulled in a different theme file, who knows...

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #5 from [e-mail] ---
Hey.  I just noticed that the Ubuntu-Light theme has 4 variants under Color:

Ambiance, Ambiance with Toolbars, Radiance and Radiance with Toolbars.

The dark shadow color only shows up (WINE32 or WINE64) when I've selected one
of the 'Ambiance' color schemes.  With Radiance selected, the shadows look
right.

So, I guess this is a bug in the theme (or how the theme is actually set up). 
Seems like it's not a WINE bug.  Sorry.

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

--- Comment #6 from [e-mail] ---
It does seem like winecfg has some problems with customizing colors, though.

I went in to fix the shadow color under the Ambiance color scheme, and it let
me do it.  But at one point, I hit Apply, and my selected colors reverted to
black.  After that, I was able to set them back to what I wanted.

Anyway, winecfg problems aside, WINE seems to be respecting the colors you set
in a theme - once you get them set right.

[Bug 48233] In a 64-bit app, GetSyscolor(COLOR_BTNSHADOW) returns a darker value than on windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48233

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown

--- Comment #7 from Nikolay Sivov  ---
It sounds like this wasn't gdi32 issue to begin with. I'm going to reset the
component keeping report open, until it becomes clear what's going on.