[Bug 34563] New: Regression in fae9738cc37c4d30710f12ee99abc11c7ae37130: rFactor 2 ModMgr.exe buttons not working properly
http://bugs.winehq.org/show_bug.cgi?id=34563
Bug #: 34563 Summary: Regression in fae9738cc37c4d30710f12ee99abc11c7ae37130: rFactor 2 ModMgr.exe buttons not working properly Product: Wine Version: 1.5.26 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: marcus.blumhagen@web.de Classification: Unclassified
The Mod Manager (ModMgr.exe) of rFactor 2 has stopped working with the above commit. I found it by means of git bisect.
How it is supposed to work: There is a list of items that can be installed. After marking one and then clicking the "Install" button a small popup window appears informing about the status of the action. On success said popup closes and the item will show up as installed.
What happens with the above commit applied: ModMgr.exe starts as usual, one can select items from the list. But on clicking say the "Install" button it only gets disabled (the label characters turns from black to grey) and nothing else happens. To me it looks like the action associated with those buttons is not executed.
http://bugs.winehq.org/show_bug.cgi?id=34563
Marcus Blumhagen marcus.blumhagen@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |djelinski1@gmail.com, | |marcus.blumhagen@web.de Summary|Regression in |Regression: rFactor 2 |fae9738cc37c4d30710f12ee99a |ModMgr.exe buttons not |bc11c7ae37130: rFactor 2 |working properly |ModMgr.exe buttons not | |working properly | Regression SHA1| |fae9738cc37c4d30710f12ee99a | |bc11c7ae37130
http://bugs.winehq.org/show_bug.cgi?id=34563
Marcus Blumhagen marcus.blumhagen@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=34563
--- Comment #1 from Daniel Jelinski djelinski1@gmail.com 2013-09-21 10:43:57 CDT --- The bug is quite unlikely to be caused by the said commit. Probably it was a bug elsewhere that was uncovered by this change. Is there a free download available? Does it work with native comctl? Does it work in wine's virtual desktop?
http://bugs.winehq.org/show_bug.cgi?id=34563
--- Comment #2 from Marcus Blumhagen marcus.blumhagen@web.de 2013-09-21 11:46:53 CDT --- (In reply to comment #1)
The bug is quite unlikely to be caused by the said commit. Probably it was a bug elsewhere that was uncovered by this change. Is there a free download available?
The download is available here: http://rfactor.net/web/getfile/lite-installer/
If you want to test component installation yourself, you should also download: http://rfactor.net/web/getfile/clio-197-pace-car/
That´s the smallest download I can find there. Feel free to download anything else from: http://rfactor.net/web/rf2/rf2dl/
To get to the Mod Manager the easiest way is to start "Launch rFactor.exe", then click "Manage Mods" in the bottom right. The .rfcmp file should be in the "Packages" folder inside the location chosen for the "Data Path" during installation.
Does it work with native comctl?
It does, thanks for the hint. I ran "winetricks comctl32" and now it works as expected.
Does it work in wine's virtual desktop?
Haven´t checked since it works with the native comctl. Also I couldn´t convince wine to run the virtual desktop. Should I even bother trying harder?
So should I report this bug against a different component? If so, which one or how should I go about finding that out myself?
http://bugs.winehq.org/show_bug.cgi?id=34563
--- Comment #3 from Daniel Jelinski djelinski1@gmail.com 2013-09-21 16:16:37 CDT --- Thanks for all the testing. I was able to reproduce the bug using the procedure you provided. The component is correct, and the bug is caused by reuse of one of the variables (cdsubitemmode) in LISTVIEW_DrawItem, which loses the CDRF_NOTIFYPOSTPAINT flag. Getting this right is not exactly easy. DrawItem function tries to do too many things at once and needs to be refactored first, so that postpaint event can actually be sent after the entire item (including subitems) is painted.
http://bugs.winehq.org/show_bug.cgi?id=34563
--- Comment #4 from Daniel Jelinski djelinski1@gmail.com --- This was fixed by fa3e750e2cfc5fe763c2891f5fa47fec2ded43b0 (checked with & without). Thanks Nikolay!
http://bugs.winehq.org/show_bug.cgi?id=34563
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |fa3e750e2cfc5fe763c2891f5fa | |47fec2ded43b0 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #5 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Daniel Jelinski from comment #4)
This was fixed by fa3e750e2cfc5fe763c2891f5fa47fec2ded43b0 (checked with & without). Thanks Nikolay!
Marking fixed.
https://bugs.winehq.org/show_bug.cgi?id=34563
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.23.
-
wine-bugs＠winehq.org