http://bugs.winehq.org/show_bug.cgi?id=20477
Summary: Regression -- Dragon NaturallySpeaking MSI installer fails Product: Wine Version: unspecified Platform: PC URL: http://nuance.com OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs@winehq.org ReportedBy: susancragin@earthlink.net
Created an attachment (id=24373) --> (http://bugs.winehq.org/attachment.cgi?id=24373) terminal output from dump
git version: wine-1.1.32-55-gd1472e2 Today's git will not install Dragon NaturallySpeaking. I tried installing on a clean wineprefix.
http://bugs.winehq.org/show_bug.cgi?id=20477
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #1 from Austin English austinenglish@gmail.com 2009-10-26 13:43:58 --- Regression test?
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #2 from Susan Cragin susancragin@earthlink.net 2009-10-26 16:22:20 --- susan@ubuntu:~/wine$ git bisect good ee6856d874d687c4504914e61bcde3e6b8823bca is first bad commit commit ee6856d874d687c4504914e61bcde3e6b8823bca Author: Vincent Povirk madewokherd@gmail.com Date: Fri Oct 23 13:57:42 2009 -0500
ole32: Don't use IEnumSTATSTG to search for elements of storages.
We use it to do a linear search of a binary tree, which is overkill. Replace it with a simple binary search.
:040000 040000 bbc59aaf3545a738bb4b76a0be8bc8af5cb8dbe8 e2fb0905525e99bfb5bb6deff6bbe67dbd9a60af M dlls susan@ubuntu:~/wine$
http://bugs.winehq.org/show_bug.cgi?id=20477
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #3 from Vincent Povirk madewokherd@gmail.com 2009-10-26 16:37:00 --- I knew that could break something, but I was hoping it wouldn't. Thanks for catching this so quickly.
This implies that some storage files contain invalid trees, and we need to account for that possibility, hence we really do need either a linear search or some preparation of the tree beforehand.
I think the best fix for now is to revert that patch and add a comment explaining that we really need to do that.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #4 from Austin English austinenglish@gmail.com 2009-10-26 16:44:26 --- (In reply to comment #3)
I knew that could break something, but I was hoping it wouldn't. Thanks for catching this so quickly.
Seems you broke a lot of stuff on appinstall as well:
excelviewer03-result.txt:Launching Microsoft Office Excel Viewer 2003 Setup, End-User License Agreement failed. Test failed. lockdown-result.txt:Launching Respondus LockDown Browser - InstallShield Wizard, Click Finish to exit the wizard failed. Test failed. photoshopcs2-result.txt:Launching Adobe Photoshop CS2 - License Agreement, License Agreement failed. Test failed.
Excel/Powerpoint/Word viewer 2003 and Lockdown browser all failed to install. Photoshop CS 2 did as well, but can't be as sure on that one. It has a couple race conditions (one in the installer, one in drawing an image). The installer race I fixed a month or so ago, and haven't seen until today, the other is still there.
The other failures are definitely new.
http://austinenglish.com/logs/appinstall-2009-10-26/summary.txt http://austinenglish.com/logs/appinstall-2009-10-26/
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2009-10-26 17:46:21 --- I think I was too hasty in my declaration of the cause. Something weird is going on if we're getting the same crash from multiple apps.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #6 from Vincent Povirk madewokherd@gmail.com 2009-10-26 18:01:27 --- msi_load_string_table is apparently failing. It looks like msi doesn't handle that case correctly and crashes (it shouldn't), but of course that's not the main problem. Most likely it's not finding either "_StringPool" or "_StringData" in the file.
It should be easy enough to dump the tree from a storage file, and that will tell us whether the tree is truly broken, or whether the search fails for some other reason.
Even if that tree is valid, I should probably also write a test case for my original change. It was a bit reckless not to do that when I knew MS's implementation might be able to (and therefore might need to) read files with an invalid tree.
http://bugs.winehq.org/show_bug.cgi?id=20477
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Version|unspecified |1.1.32 Summary|Regression -- Dragon |Dragon NaturallySpeaking |NaturallySpeaking MSI |MSI installer fails |installer fails | Ever Confirmed|0 |1
--- Comment #7 from Vitaliy Margolen vitaliy@kievinfo.com 2009-10-26 20:57:42 --- Confirming per comment 4.
http://bugs.winehq.org/show_bug.cgi?id=20477
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
--- Comment #8 from Austin English austinenglish@gmail.com 2009-10-26 22:29:24 --- For an easy to reproduce method, use 'winetricks -q art2kmin'.
http://bugs.winehq.org/show_bug.cgi?id=20477
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|msi |ole32
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #9 from Susan Cragin susancragin@earthlink.net 2009-10-27 10:28:36 --- wine-1.1.32-119-g07c321b Downloaded new wine & then updated to today's git. The problem persists.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #10 from Vincent Povirk madewokherd@gmail.com 2009-10-27 12:56:12 --- Python's msi installer (which also suffers from this bug) looks like it has a valid tree to me. I think that our comparison function must be wrong.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #11 from Vincent Povirk madewokherd@gmail.com 2009-10-27 13:09:00 --- Created an attachment (id=24394) --> (http://bugs.winehq.org/attachment.cgi?id=24394) fix the left/rightchild offset defines
The problem is much simpler than I ever suspected: I don't know the difference between left and right.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #12 from Vincent Povirk madewokherd@gmail.com 2009-10-27 13:14:31 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2009-October/080605.html
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #13 from Susan Cragin susancragin@earthlink.net 2009-10-27 14:51:07 --- Patch works.
http://bugs.winehq.org/show_bug.cgi?id=20477
--- Comment #14 from Vincent Povirk madewokherd@gmail.com 2009-10-27 14:52:22 --- I think that the patch identified in the bisect is correct, but the explanation / test cases are not directly relevant to this bug. I've posted them on wine-devel here: http://www.winehq.org/pipermail/wine-devel/2009-October/079478.html
http://bugs.winehq.org/show_bug.cgi?id=20477
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer
http://bugs.winehq.org/show_bug.cgi?id=20477
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |startaq@gmail.com
--- Comment #15 from Vincent Povirk madewokherd@gmail.com 2009-10-27 18:26:48 --- *** Bug 20494 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=20477
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #16 from Wylda wylda@volny.cz 2009-10-28 07:57:51 ---
Hi, maybe it's wasting of bytes, but when i spent some time with it, ie. for the record...
Fifa09_demo is affected like described in comment #3 with same console crash log. Good news is, that patch in comment #11 also fixed fifa09_demo installer.
http://bugs.winehq.org/show_bug.cgi?id=20477
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #17 from Dmitry Timoshkov dmitry@codeweavers.com 2009-10-28 11:27:44 --- The patch has been committed.
http://bugs.winehq.org/show_bug.cgi?id=20477
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fgatwork@verizon.net
--- Comment #18 from Dmitry Timoshkov dmitry@codeweavers.com 2009-10-29 02:12:26 --- *** Bug 20502 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=20477
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org 2009-11-13 12:44:41 --- Closing bugs fixed in 1.1.33.
-
wine-bugs＠winehq.org