[Bug 52743] New: regression cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Bug ID: 52743
           Summary: regression cannot write to _fdopen'ed stdout
           Product: Wine
           Version: 7.5
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

since wine 7.2, opening stdout with _fdopen and printing into it crashes

```
#include <stdio.h>
#include <io.h>
#include <fcntl.h>

int main()
{
  FILE * m_stdout = _fdopen(_fileno(stdout), "wb");
  fprintf(m_stdout, "foo\n");
  fclose(m_stdout);
  return 0;
}

$ x86_64-w64-mingw32-gcc main.c
$ wine a.exe
...
wine: Unhandled page fault on read access to 0000000000000050 at address
0000000170059685 (thread 0128), starting debugger...
...

```

For context, this is what qt-xmlpatterns does:

https://github.com/qt/qtxmlpatterns/blob/dev/tools/xmlpatterns/main.cpp#L184

[Bug 52743] regression cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

xantares  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |ArchLinux

[Bug 52743] regression cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #1 from xantares  ---
sorry wine 7.2 is ok, versions of wine>=7.3 are not

[Bug 52743] cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
            Summary|regression cannot write to  |cannot write to _fdopen'ed
                   |_fdopen'ed stdout           |stdout

[Bug 52743] cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #2 from Gijs Vermeulen  ---
It works fine for me with self-compiled wine-7.5 and wine-staging 7.5 from the
ArchLinux repos as well.

$ x86_64-w64-mingw32-gcc --version
x86_64-w64-mingw32-gcc (GCC) 11.2.0

[Bug 52743] cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Maurer  ---
Works fine for me as well. Are you using a clean WINEPREFIX? Also on Arch, btw.

[Bug 52743] cannot write to _fdopen'ed stdout

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #4 from xantares  ---
I failed to report that I was running it from a docker image (usually it
behaves the same).

FROM archlinux:latest
RUN echo -e "[multilib]\nInclude = /etc/pacman.d/mirrorlist" >>
/etc/pacman.conf
RUN pacman -Sy wine mingw-w64-gcc strace --noconfirm
WORKDIR /tmp
ADD main.c /tmp
RUN x86_64-w64-mingw32-gcc main.c
ENV WINEARCH=win64
RUN wine a.exe

I noticed that if I run it with the 64 bits exe right away it goes fine
(something wrong with the preloader code ?):

RUN wine64 a.exe

if I run it with strace I notice that some mmap call fails:

mmap2(NULL, 65536, PROT_NONE,
MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0^[[0m^[[91m) = -1 EPERM
(Operation not permitted)

Actually this problem is a regression in 7.5 from 7.4 as another 7.3 bug fixed
in 7.4 was hiding it:
https://bugs.winehq.org/show_bug.cgi?id=52614

Bisecting yields
https://github.com/wine-mirror/wine/commit/c7e87b536edb28bb48162690e0d42c9ba...:

c7e87b536edb28bb48162690e0d42c9ba9ccb43c is the first bad commit
commit c7e87b536edb28bb48162690e0d42c9ba9ccb43c
Author: Eric Pouech 
Date:   Thu Mar 17 08:27:22 2022 +0100

start: Force no console creation when using start /exec.

Signed-off-by: Eric Pouech 
    Signed-off-by: Jacek Caban 
    Signed-off-by: Alexandre Julliard

programs/start/start.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
bisect found first bad commitRemoving intermediate container b85bc621aa41

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |c7e87b536edb28bb48162690e0d
                   |                            |42c9ba9ccb43c
            Summary|cannot write to _fdopen'ed  |cannot write to _fdopen'ed
                   |stdout                      |stdout when running in
                   |                            |docker

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #5 from Eric Pouech  ---
1) please update your test to check whether m_stdout is NULL (it will at least
not segfault)
2) can you test if the proposed patch in
https://bugs.winehq.org/show_bug.cgi?id=52761 changes the situation
TIA

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |programs

--- Comment #6 from Austin English  ---
(In reply to Eric Pouech from comment #5)
> - please update your test to check whether m_stdout is NULL (it will at
>
> least not segfault)
> 2) can you test if the proposed patch in
> https://bugs.winehq.org/show_bug.cgi?id=52761 changes the situation
> TIA

winetricks-test also fails because of c7e87b536edb28bb48162690e0d42c9ba9ccb43c;
with https://bugs.winehq.org/attachment.cgi?id=72131 applied, things work
again.

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #7 from Austin English  ---
(In reply to Austin English from comment #6)
> (In reply to Eric Pouech from comment #5)
> > - please update your test to check whether m_stdout is NULL (it will at
> >
> > least not segfault)
> > 2) can you test if the proposed patch in
> > https://bugs.winehq.org/show_bug.cgi?id=52761 changes the situation
> > TIA
>
> winetricks-test also fails because of
> c7e87b536edb28bb48162690e0d42c9ba9ccb43c; with
> https://bugs.winehq.org/attachment.cgi?id=72131 applied, things work again.

Forgot to add, this isn't using docker, just shell; but I suspect in the
process of the test script calling winetricks calling wine, the
stdin|stdout|stderr is lost..

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #8 from Eric Pouech  ---
> Forgot to add, this isn't using docker, just shell; but I suspect in the
> process of the test script calling winetricks calling wine, the
> stdin|stdout|stderr is lost..

that's what's the patch tries to tackle: create a dummy console when neither 
of stdin/stdout/stderr is opened on an unix tty
(so mainly running from shell as: ./wine ... >& log < /dev/null will fall into
this)

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #9 from Austin English  ---
(In reply to Austin English from comment #6)
> (In reply to Eric Pouech from comment #5)
> > - please update your test to check whether m_stdout is NULL (it will at
> >
> > least not segfault)
> > 2) can you test if the proposed patch in
> > https://bugs.winehq.org/show_bug.cgi?id=52761 changes the situation
> > TIA
>
> winetricks-test also fails because of
> c7e87b536edb28bb48162690e0d42c9ba9ccb43c; with
> https://bugs.winehq.org/attachment.cgi?id=72131 applied, things work again.

Still present in wine-7.6-100-gae9266992a5 (i.e.,
eff83cd4e00e8ccd4daad05bdd6d76e77664ddd1 from bug 52771 doesn't make a
difference), for winetricks-test.

@Eric, please let me know if you think this should be its own bug (or if it
should be marked as a duplicate of bug 52761.

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #10 from Eric Pouech  ---
> @Eric, please let me know if you think this should be its own bug (or if it
> should be marked as a duplicate of bug 52761.

it should work when you give the exact path for the exec

this should work:
./wine programs/cmd/cmd.exe /c echo 'hello' >& ~/test.txt < /dev/null

while this doesn't (yet)
./wine cmd.exe /c echo 'hello' >& ~/test.txt < /dev/null

I'll post to wine-devel this missing bit

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

--- Comment #11 from Austin English  ---
(In reply to Eric Pouech from comment #10)
> I'll post to wine-devel this missing bit

Thanks, with wine-7.6-100-gae9266992a5 +
https://source.winehq.org/patches/data/232396 winetricks-test seems to be
working (still in progress, but all passing so far, instead of everything
failing..).

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

xantares  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #12 from xantares  ---
this is now fixed in version 7.7

[Bug 52743] cannot write to _fdopen'ed stdout when running in docker

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52743

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 7.8.