https://bugs.winehq.org/show_bug.cgi?id=51047
Bug ID: 51047 Summary: Significant performance regression in The Sims 2 Product: Wine Version: 5.14 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: sashok.olen@gmail.com CC: zzhang@codeweavers.com Regression SHA1: 9905a5a81d6baf59e992c5b2a8ea92ee4054e5d6 Distribution: ArchLinux
Hi, through regression testing I've discovered that commit 9905a5a81d6baf59e992c5b2a8ea92ee4054e5d6 Author: Zhiyi Zhang zzhang@codeweavers.com Date: Fri Jul 24 17:23:21 2020 +0800
winex11.drv: Add XRandR 1.4 display settings handler.
which was first included in 5.14 release, caused The Sims 2 - Ultimate Collection from Origin (no longer available for purchase) to experience a significant reduction in performance. For instance, in my save game, in Living Mode, frames per second drop from around 70 in Wine 5.13 to around 5 in Wine 5.14, and in Neighborhood mode, they drop from around 140 to 40 (can't give precise numbers due to The Sims 2 lacking any internal benchmarking tools, but the significant difference in FPS is always there and it's very noticeable and consistent). Should note that this issue applies both to WineD3D and third-party DXVK D3D9 implementation (for wined3d, you need staging with this game), and that I've previously discovered through an apitrace recording that this game seems to call IDirect3DDevice9::GetDisplayMode very often, sometimes 100 times per draw call, which could be related, seeing how the regression is in winex11. As this game is no longer available for purchase, I'm willing to temporarily lend my Origin account with this game for testing purposes. However, I think it's also available through Internet Archive, though not sure how legal that is.
https://bugs.winehq.org/show_bug.cgi?id=51047
Alexandr Oleynikov sashok.olen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sashok.olen@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=51047
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #1 from Zhiyi Zhang zzhang@codeweavers.com --- This is similar to https://bugs.winehq.org/show_bug.cgi?id=50096. Is it not fixed in the wine 6.0?
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #2 from Alexandr Oleynikov sashok.olen@gmail.com --- No, this is still an issue in new releases like 6.6.
https://bugs.winehq.org/show_bug.cgi?id=51047
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- Confirmed with Wine 6.6
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #4 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 69932 --> https://bugs.winehq.org/attachment.cgi?id=69932 patch
Does this patch restore the game's performance to what it was?
https://bugs.winehq.org/show_bug.cgi?id=51047
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #69932|0 |1 is obsolete| |
--- Comment #5 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 69933 --> https://bugs.winehq.org/attachment.cgi?id=69933 patch v2
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #6 from Alexandr Oleynikov sashok.olen@gmail.com --- So sorry that I've only now managed to read your messages and test the patch, idk how I missed it in my emails, but unfortunately the v2 patch does not restore Sims 2 performance back to normal (didn't try out v1), and neither does this patch by itself https://source.winehq.org/patches/data/205952
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #7 from Zhiyi Zhang zzhang@codeweavers.com --- That's weird. Did you compile wine with xrandr support when testing the patch? Could you do a performance profiling using sysprof and find out what's causing the slow down?
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #8 from Zhiyi Zhang zzhang@codeweavers.com --- Also please test with https://source.winehq.org/patches/data/205951 and https://source.winehq.org/patches/data/205952 both applied.
https://bugs.winehq.org/show_bug.cgi?id=51047
--- Comment #9 from Alexandr Oleynikov sashok.olen@gmail.com ---
That's weird. Did you compile wine with xrandr support when testing the patch?
I did.
Also please test with https://source.winehq.org/patches/data/205951 and https://source.winehq.org/patches/data/205952 both applied.
Indeed, applying that patch as well fixed the issue. Sorry for wasting a bit of time, didn't notice that patch was a part of a series.
https://bugs.winehq.org/show_bug.cgi?id=51047
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |7fabcf6fed93545cea5f8e4fdac | |e4355bb5710ed Resolution|--- |FIXED
--- Comment #10 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by 095bdc6 and 7fabcf6
https://bugs.winehq.org/show_bug.cgi?id=51047
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.9.
-
WineHQ Bugzilla