[Bug 46649] New: Tom Clancy's Rainbow Six: Vegas 2 needs D3DXDisassembleShader implementation

https://bugs.winehq.org/show_bug.cgi?id=46649

Bug ID: 46649
           Summary: Tom Clancy's Rainbow Six: Vegas 2 needs
                    D3DXDisassembleShader implementation
           Product: Wine
           Version: 4.1
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: directx-d3dx9
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Crashes at launch with 'Message  General protection fault!  History: '

fixme:d3dx:D3DXDisassembleShader 0x7671b00 0 (null) 0x62ce18: stub

wine-4.1-207-g7907ccfdcb

[Bug 46649] Tom Clancy's Rainbow Six: Vegas 2 needs D3DXDisassembleShader implementation

https://bugs.winehq.org/show_bug.cgi?id=46649

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
    Staged patchset|                            |https://github.com/Glorious
                   |                            |Eggroll/wine-staging-mirror
                   |                            |/tree/master/patches/d3dx9_
                   |                            |36-D3DXDisassembleShader

[Bug 46649] Tom Clancy's Rainbow Six: Vegas 2 needs D3DXDisassembleShader implementation

https://bugs.winehq.org/show_bug.cgi?id=46649

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|https://github.com/Glorious |https://github.com/wine-sta
                   |Eggroll/wine-staging-mirror |ging/wine-staging/tree/mast
                   |/tree/master/patches/d3dx9_ |er/patches/d3dx9_36-D3DXDis
                   |36-D3DXDisassembleShader    |assembleShader

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                 CC|                            |[e-mail]
            Summary|Tom Clancy's Rainbow Six:   |Multiple applications need
                   |Vegas 2 needs               |D3DXDisassembleShader()
                   |D3DXDisassembleShader       |implementation (Tom
                   |implementation              |Clancy's Rainbow Six: Vegas
                   |                            |2, The Void)

--- Comment #1 from Zebediah Figura  ---
This also apparently affects The Void:

https://web.archive.org/web/20170627001216/https://wine-staging.com/news/2016-02-23-release-1.9.4.html

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

--- Comment #2 from Zebediah Figura  ---
(In reply to Zebediah Figura from comment #1)
> This also apparently affects The Void:
>
> https://web.archive.org/web/20170627001216/https://wine-staging.com/news/
> 2016-02-23-release-1.9.4.html

I can confirm this, although The Void also needs D3DXFillCubeTextureTX() to
return success first. I've filed bug 48528 for this.

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Zebediah Figura  ---
*** Bug 50469 has been marked as a duplicate of this bug. ***

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

--- Comment #4 from Henri Verbeet  ---
In case anyone wants to pick this up, this functionality has been implemented
in vkd3d-shader for shader model 4 and 5 shaders by Isabella. It should be
relatively straightforward to port wined3d's shader model 1-3 parser (in
shader_sm1.c) to vkd3d-shader and then call vkd3d-shader from d3dx9.

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

--- Comment #5 from Nikolay Sivov  ---
With Wine 6.16 this issues is shifted to d3dcompiler's D3DDisassemble() that
needs to support pre-sm4 bytecode [1].

[1]
https://source.winehq.org/git/wine.git/?a=commit;h=4ad4e4a133e92f923f9eb3da5...

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |7bf58c895c3145187bbc6dcbe4e
                   |                            |0e14d11457a39
             Status|STAGED                      |RESOLVED

--- Comment #6 from Nikolay Sivov  ---
This is doing D3DXDisassembleShader -> D3DDisassemble -> libvkd3d-shader. It
seems to work for me, at least for Rainbow Six. I'm going to mark this fixed,
please open specific reports with vkd3d if some shader is not diassembled
correctly.

Commit 7bf58c895c3145187bbc6dcbe4e0e14d11457a39.

[Bug 46649] Multiple applications need D3DXDisassembleShader() implementation (Tom Clancy's Rainbow Six: Vegas 2, The Void)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46649

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc1.