[Bug 27158] New: Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Summary: Mouse Input in Source Engine Games is jittery
           Product: Wine
           Version: 1.3.20
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Mouse input in Source Engine games(Counter-Strike: Source, Half-Life 2, etc)
appears to jump around, making these games unplayable. This is probably due to
the latest input changes. I've tried setting native dinput8, which did not
solve the problem.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Evan Goers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

--- Comment #1 from Evan Goers  2011-05-13 23:27:52 CDT ---
If I compile it with --without-xinput2 the issue is gone. So it definitely has
to do with xinput2 and the latest changes in this area.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from joaopa  2011-05-14 01:41:49 CDT ---
You have to do a regression tests to find the wrong patch that introduced the
problem.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

--- Comment #3 from Evan Goers  2011-05-14 02:31:12 CDT ---
(In reply to comment #2)
> You have to do a regression tests to find the wrong patch that introduced the
> problem.

Will do. In the meantime, can anyone else confirm?

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Jerome Leclanche  2011-05-14 07:33:05 CDT ---
Possible dupe: bug 27156. Please try reverting that commit before doing the
regression test.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

JR  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Luke Bratch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from GyB  2011-05-15 03:36:50 CDT ---
I'm experiencing the same problem in HL2 and CS:Source when using Wine-1.3.20.
Mouse movement is constantly jumping around.

There are at least two commits involved in the issue:

1) When you move the mouse to turn around, the camera position is jumping
around.
Caused by
http://source.winehq.org/git/wine.git/commit/8e9b4e0a5c6bee5f72ca2314db26233...

2) When you press the mouse button to shoot, the camera always jumps in
different directions.
Caused by
http://source.winehq.org/git/wine.git/commit/fd4ad5a60433b8314dce684b9d52f43...

With both commits reverted the problem seemed to be resolved, however the
strange camera jumping issue still occurs *occasionally* (first I thought it
was caused by some lagging issue).
There must be a third, earlier commit, introducing the problem but currently I
have no more time on regression testing.

Evan, I'm looking forward to your result in regression testing ;)

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

--- Comment #6 from Evan Goers  2011-05-15 04:30:41 CDT ---
(In reply to comment #5)
> I'm experiencing the same problem in HL2 and CS:Source when using Wine-1.3.20.
> Mouse movement is constantly jumping around.
>
> There are at least two commits involved in the issue:
> - When you move the mouse to turn around, the camera position is jumping
>
> around.
> Caused by
> http://source.winehq.org/git/wine.git/commit/8e9b4e0a5c6bee5f72ca2314db26233...
> - When you press the mouse button to shoot, the camera always jumps in
>
> different directions.
> Caused by
> http://source.winehq.org/git/wine.git/commit/fd4ad5a60433b8314dce684b9d52f43...
>
> With both commits reverted the problem seemed to be resolved, however the
> strange camera jumping issue still occurs *occasionally* (first I thought it
> was caused by some lagging issue).
> There must be a third, earlier commit, introducing the problem but currently I
> have no more time on regression testing.
>
> Evan, I'm looking forward to your result in regression testing ;)

Does the 'lagging' feel like a sudden massive loss in FPS? If so, I've seen
this issue as far back as 1.3.10 or so. It appears totally at random and I
think it's unrelated to this.

As far as the regression test goes, I'm in the process right now.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

--- Comment #7 from GyB  2011-05-15 04:57:24 CDT ---
(In reply to comment #6)
> Does the 'lagging' feel like a sudden massive loss in FPS? If so, I've seen
> this issue as far back as 1.3.10 or so. It appears totally at random and I
> think it's unrelated to this.

No, it is due to
http://source.winehq.org/git/wine.git/commit/a59c7cc8596b658d3c0854a737528cf...

This is the commit which introduced the strange mouse jumping issue. It happens
occasionally but frequently enough to annoy you while playing.
The other two commits in comment #5 made the problem more serious: the jittery
mouse movement became persistent.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

--- Comment #8 from Evan Goers  2011-05-15 05:05:51 CDT ---
Well it looks like the regression test didn't reveal anything new after
reverting the two commits in comment #5(and doing a bisect). The bug
disappeared for me after reverting those.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Bully Bull  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #9 from Bully Bull  2011-05-15 06:53:41 CDT ---
*** This bug has been confirmed by popular vote. ***

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Fab  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

3vi1  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #10 from 3vi1  2011-05-15 12:28:08 CDT ---
Wish I had thought to search on some different terms this morning.  I would
have got here sooner and saved myself a bit of regression testing.  :)

At any rate, I too tracked it to
http://source.winehq.org/git/wine.git/commit/8e9b4e0a5c6bee5f72ca2314db26233...
and verified that reverting that patch seems to correct the main problem.

I wish I could help fix it, but knowing less than nothing about XInput1/2 I
don't entirely follow the intention of the original patch yet.  The only thing
really clear is that each time the one-second minimum is passed, it's merging
input that should have been ignored.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Nemesis Enforcer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Nemesis Enforcer  2011-05-15 14:25:24 CDT ---
I followed the regression testing procedure and can confirm that the commit

http://source.winehq.org/git/wine.git/commit/fd4ad5a60433b8314dce684b9d52f43...

also causes mouse jumping every second when "looking around" in Counter-Strike
1.6. When in the main menu or in the in-game menus (e.g. Buy Menu), the cursor
moves normally.

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #12 from Austin English  2011-05-15 15:22:53 CDT ---
Dupe.

*** This bug has been marked as a duplicate of bug 27156 ***

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Fab  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |

[Bug 27158] Mouse Input in Source Engine Games is jittery

http://bugs.winehq.org/show_bug.cgi?id=27158

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Austin English  2011-05-16 04:34:34 CDT ---
Closing.