[Bug 38205] New: Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

Bug ID: 38205
           Summary: Unreal Tournament 3 Black Edition installer fails
                    after the language selection
           Product: Wine
           Version: 1.7.37
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: Installer, regression
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 0dba391d67a4cf564371c44a3a781d1e9e3507c2
      Distribution: ---

Created attachment 50998
  --> https://bugs.winehq.org/attachment.cgi?id=50998
+msi debug log

Tested with UT 3 Black Edition from Gamersgate.
Can't reproduce with UT3 Beta Demo.

After the language selection dialog the installer is failing with the error
"1628: Failed to complete installation"

Used to work in 1.7.36, regression introduced by

0dba391d67a4cf564371c44a3a781d1e9e3507c2 is the first bad commit
commit 0dba391d67a4cf564371c44a3a781d1e9e3507c2
Author: Hans Leidekker 
Date:   Fri Feb 13 13:39:38 2015 +0100

msi: Don't write streams to storage until the database is committed.

Native allows streams to be created with names that exceed the maximum
    length allowed by OLE storages. These streams can be used normally, it's
    just not possible to commit such a database.

wine-1.7.38-34-g11b4200

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #1 from Hans Leidekker  ---
Created attachment 51000
  --> https://bugs.winehq.org/attachment.cgi?id=51000
patch

Can you try this patch?

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Hans Leidekker from comment #1)
> Created attachment 51000 [details]
> patch
>
> Can you try this patch?

The patch works and the game can be installed properly, thanks.

I've just noticed a strange issue when using 'wine uninstaller'. It's not due
to your patch because this occurs in 1.7.36 too.
After installing UT3 Black Edition in a clean wineprefix I have 4 entries in
the uninstaller menu:
Ageia Physx v7.09.13
Unreal Tournament 3 Black
Wine Gecko (32-bit)
Wine Mono

I click on the 'Unreal Tournament 3 Black' entry and click <Remove>...It's not
the game that gets removed but Gecko. I click again on the game to uninstall
and this time Physx gets removed. Clicking again on the game entry and this
time Mono gets removed. Finally only the game remains in the list. Really
weird...
Are you aware of such an issue? Maybe a bugreport is already exist for that
problem.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #3 from Hans Leidekker  ---
(In reply to Béla Gyebrószki from comment #2)
> (In reply to Hans Leidekker from comment #1)
> > Created attachment 51000 [details]
> > patch
> >
> > Can you try this patch?
>
> The patch works and the game can be installed properly, thanks.

Thank you for testing the patch.
> I've just noticed a strange issue when using 'wine uninstaller'. It's not
> due to your patch because this occurs in 1.7.36 too.
> After installing UT3 Black Edition in a clean wineprefix I have 4 entries in
> the uninstaller menu:
> Ageia Physx v7.09.13
> Unreal Tournament 3 Black
> Wine Gecko (32-bit)
> Wine Mono
>
> I click on the 'Unreal Tournament 3 Black' entry and click <Remove>...It's
> not the game that gets removed but Gecko. I click again on the game to
> uninstall and this time Physx gets removed. Clicking again on the game entry
> and this time Mono gets removed. Finally only the game remains in the list.
> Really weird...
> Are you aware of such an issue? Maybe a bugreport is already exist for that
> problem.

I didn't know about this issue. I tried to reproduce it with two random msi
packages installed in addition to Gecko and Mono using a 32-bit prefix but it
behaved correctly.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #4 from Béla Gyebrószki  ---
(In reply to Hans Leidekker from comment #3)
> > I've just noticed a strange issue when using 'wine uninstaller'. It's not
> > due to your patch because this occurs in 1.7.36 too.
> > After installing UT3 Black Edition in a clean wineprefix I have 4 entries in
> > the uninstaller menu:
> > Ageia Physx v7.09.13
> > Unreal Tournament 3 Black
> > Wine Gecko (32-bit)
> > Wine Mono
> >
> > I click on the 'Unreal Tournament 3 Black' entry and click <Remove>...It's
> > not the game that gets removed but Gecko. I click again on the game to
> > uninstall and this time Physx gets removed. Clicking again on the game entry
> > and this time Mono gets removed. Finally only the game remains in the list.
> > Really weird...
> > Are you aware of such an issue? Maybe a bugreport is already exist for that
> > problem.
>
> I didn't know about this issue. I tried to reproduce it with two random msi
> packages installed in addition to Gecko and Mono using a 32-bit prefix but
> it behaved correctly.

Opened bug #38207 for the problem, that can be reproduced with the demo.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

Erich E. Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erich.e.hoover@wine-staging
                   |                            |.com

--- Comment #5 from Erich E. Hoover  ---
I'm also running into trouble with this commit, but it's not fixed by the
proposed patch.  I'm using MsiDb to replace tables in an MSI file and I'm
seeing garbage when it tries to commit a stream:
err:msidb:msi_commit_streams failed to create stream
L"\432f\42e5\4568\4230\47b6\4126\4825" (hr = 80030050)
err:msi:MsiDatabaseCommit Failed to commit streams!
fixme:msi:MsiGetLastErrorRecord 
Z:\tmp\build-msi.uCtY0PUBfi\data.msi: Database commit failed

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #6 from Hans Leidekker  ---
(In reply to Erich E. Hoover from comment #5)
> I'm also running into trouble with this commit, but it's not fixed by the
> proposed patch.  I'm using MsiDb to replace tables in an MSI file and I'm
> seeing garbage when it tries to commit a stream:
> err:msidb:msi_commit_streams failed to create stream
> L"\432f\42e5\4568\4230\47b6\4126\4825" (hr = 80030050)
> err:msi:MsiDatabaseCommit Failed to commit streams!
> fixme:msi:MsiGetLastErrorRecord 
> Z:\tmp\build-msi.uCtY0PUBfi\data.msi: Database commit failed

Can you retry with current git? If it still fails, please attach a +msi,+msidb
trace. The regression reported by Béla should be fixed by
db3fdbe1e3570f9b79f5c00fd166881e78c5f9a6 (which is an improved version of the
patch attached here).

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #7 from Béla Gyebrószki  ---
Created attachment 51043
  --> https://bugs.winehq.org/attachment.cgi?id=51043
+msi debug log (wine-1.7.38-223-g8fa8a23)

(In reply to Hans Leidekker from comment #6)
> The regression reported by Béla should be fixed by
> db3fdbe1e3570f9b79f5c00fd166881e78c5f9a6 (which is an improved version of
> the patch attached here).

Just tested in wine-1.7.38-223-g8fa8a23..unfortunately the problem remains in
the latest version: I still receive "1628: Failed to complete installation"
error message after the language selection dialog.
Attaching a new +msi log.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #8 from Erich E. Hoover  ---
(In reply to Hans Leidekker from comment #6)
> ...
> Can you retry with current git? If it still fails, please attach a
> +msi,+msidb trace. The regression reported by Béla should be fixed by
> db3fdbe1e3570f9b79f5c00fd166881e78c5f9a6 (which is an improved version of
> the patch attached here).

I was testing with the latest git, but I now believe the problem is not
actually in Wine - it appears that the installer package I was editing became
corrupted at some point.  It's odd that before that commit I could still edit
it, but anyway - I don't think the commit is actually responsible for the
problem.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51043|0                           |1
        is obsolete|                            |

--- Comment #9 from Béla Gyebrószki  ---
Created attachment 51114
  --> https://bugs.winehq.org/attachment.cgi?id=51114
+msi,+msidb log (uncompressed 1.3 MB)

+msi,+msidb log created with wine-1.7.39-75-g3c2d0b9.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

--- Comment #10 from Hans Leidekker  ---
(In reply to Béla Gyebrószki from comment #9)
> Created attachment 51114 [details]
> +msi,+msidb log (uncompressed 1.3 MB)
>
> +msi,+msidb log created with wine-1.7.39-75-g3c2d0b9.

Thanks. Can you try again with current git?

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |052b3a748e144093ec7043e6833
                   |                            |3fbc2e85fcdd7
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Béla Gyebrószki  ---
Fixed in wine-1.7.39-113-g3c5387d, thanks.

[Bug 38205] Unreal Tournament 3 Black Edition installer fails after the language selection

https://bugs.winehq.org/show_bug.cgi?id=38205

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.40.