[Bug 19627] New: Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Summary: Muziic installer causes a page fault
           Product: Wine
           Version: 1.1.27
          Platform: PC
               URL: http://download.cnet.com/Muziic/3000-2168_4-10910117.h
                    tml?part=dl-10045338&subj=dl&tag=button
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22898)
 --> (http://bugs.winehq.org/attachment.cgi?id=22898)
Wine 1.1.27 console output

The Muziic installer causes a page fault towards the end of the installation.
Despite this, it does seem to be installed.

Backtrace:
=>0 0xb7dd273f strlenW+0x15(str=0x10)
[/home/test/wine-git/libs/wine/../../include/wine/unicode.h:216] in
libwine.so.1 (0x0032f1c4)
  1 0x7b8651b0 WideCharToMultiByte+0x51(page=0, flags=0, src=0x10, srclen=-1,
dst="çkÆ{", dstlen=260, defchar=0x0, used=(nil))
[/home/test/wine-git/dlls/kernel32/locale.c:1902] in kernel32 (0x0032f234)

Running with LANG="en_GB.UTF-8" as default.

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

--- Comment #1 from Ken Sharp   2009-08-08 08:57:38 ---
Created an attachment (id=22899)
 --> (http://bugs.winehq.org/attachment.cgi?id=22899)
Wine 1.1.27 +relay +seh +tid (5.9MB)

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |shell32

--- Comment #2 from Juan Lang   2009-08-08 10:31:23 ---
This looks like a shell32 bug.  From the log:
fixme:shell:IPersistFile_fnGetCurFile (0x18eb00)

Looking at the source for it,

static HRESULT WINAPI IPersistFile_fnGetCurFile(IPersistFile* iface, LPOLESTR
*ppszFileName)
{
        IShellLinkImpl *This = impl_from_IPersistFile(iface);
        FIXME("(%p)\n",This);
        return NOERROR;
}

it returns NOERROR without setting the output string ppszFileName, so naturally
the application assumes it can dereference it.

At least the stub should set *ppszFileName to NULL.  It should probably also
return something else.  Or, better yet, it should be able to use This->pidl to
determine a path.

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Mikolaj Zalewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |DUPLICATE

--- Comment #3 from Mikolaj Zalewski   2010-02-07 13:45:23 ---
The lack of IPersistFile::GetCurFile in ShellLink is already tracked by bug
#21297 (if that bug gets fixed, but the problem still presists, feel free to
reopen this bug).

*** This bug has been marked as a duplicate of bug 21297 ***

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |

--- Comment #4 from Ken Sharp   2010-02-07 17:56:02 ---
Then that's the duplicate, and until now contained less garbage.

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

--- Comment #5 from Ken Sharp   2010-02-07 17:56:29 ---
> From Anastasius:

"The crash itself ... well, the app uses IPersistFile::GetCurFile and expects
the out parameter to contain something useful.
Wine returns "success" but doesn't initialize the out parameter hence the app
accesses uninitialized stack garbage, leading to crash."

[Bug 19627] Muziic installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Ken Sharp   2010-02-07 17:56:44 ---
*** Bug 21297 has been marked as a duplicate of this bug. ***

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Muziic installer causes a   |IPersistFile_fnGetCurFile
                   |page fault                  |too stubby, some installers
                   |                            |fail

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.2.0

--- Comment #7 from Dan Kegel   2010-02-07 21:25:10 ---
Good analysis, affects multiple apps -> nominating for 1.2

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Nikolay Sivov   2010-03-19 12:09:50 ---
Fixed by b774baa35c6faf3135240dd860321372d06e16ef.

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-03-19 14:10:34 ---
Closing bugs fixed in 1.1.41.

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

http://bugs.winehq.org/show_bug.cgi?id=19627

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b774baa35c6faf3135240dd8603
                   |                            |21372d06e16ef

[Bug 19627] IPersistFile_fnGetCurFile too stubby, some installers fail

https://bugs.winehq.org/show_bug.cgi?id=19627

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]