http://bugs.winehq.org/show_bug.cgi?id=19369
Summary: C&C3 and Kane's Wrath crash with DSOUND_BufPtrDiff assertion Product: Wine Version: 1.1.26 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dsound AssignedTo: wine-bugs@winehq.org ReportedBy: ehoover@mines.edu
In Wine 1.1.26 (this does not occur in 1.1.25) both Command and Conquer 3 and C&C3: Kane's Wrath crash with a DSound assertion. Relevant snippet of log (Kane's Wrath): --- fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x160888,0x160788): stub mes\Command & Conquer 3 Kane's Wrath\RetailExe\1.2\cnc3ep1.dat: mixer.c:306: DSOUND_BufPtrDiff: Assertion `ptr2 < buflen' failed. fixme:faultrep:ReportFault 0x1556e35c 0x0 stub fixme:winmm:MMDRV_Exit Closing while ll-driver open ---
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #1 from Jeff Zaroyko jeffz@jeffz.name 2009-07-18 21:14:45 --- have you done a regression test?
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #2 from Erich Hoover ehoover@mines.edu 2009-07-18 22:03:13 --- (In reply to comment #1)
have you done a regression test?
I'm working on it between loads of laundry.
http://bugs.winehq.org/show_bug.cgi?id=19369
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |m.b.lankhorst@gmail.com
--- Comment #3 from Erich Hoover ehoover@mines.edu 2009-07-19 00:18:35 --- Bisect result: --- f27d88e16fe0292d3efa7dac8966a0b612e62e6d is first bad commit commit f27d88e16fe0292d3efa7dac8966a0b612e62e6d Author: Maarten Lankhorst m.b.lankhorst@gmail.com Date: Sun Jul 12 20:11:55 2009 +0200
winealsa.drv: Add support for indirect read/write in directsound support.
Allows pulseaudio to use the idsdriver interface, making it almost as fast as using native pulseaudio calls for as far as directsound is concerned. Prevents the creation of separate winmm feeder threads.
:040000 040000 b1f0046a4a3e5bd01940590deb289dc88b51bee7 1b818c85052c5351c569da754e4571090bd57f56 M dlls ---
http://bugs.winehq.org/show_bug.cgi?id=19369
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #4 from Erich Hoover ehoover@mines.edu 2009-07-19 00:58:06 --- (In reply to comment #3)
Bisect result:
f27d88e16fe0292d3efa7dac8966a0b612e62e6d is first bad commit ...
Only a very small portion of the commit is responsible for the problem (and is unrelated to the rest of the code). I've submitted a patch to revert the responsible portion: http://www.winehq.org/pipermail/wine-patches/2009-July/076109.html
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #5 from Andrew Nguyen arethusa26@gmail.com 2009-07-24 11:18:42 --- Your patch seems to have been committed as 69609983eef5b60edd6ab4c348c07771bc683349, so I presume this is fixed?
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #6 from Andrew Nguyen arethusa26@gmail.com 2009-07-24 11:19:34 --- Oops, I meant commit 0addd3ba5a7c1de970d1829f77969e5331ad2be0.
http://bugs.winehq.org/show_bug.cgi?id=19369
Maarten Lankhorst m.b.lankhorst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #7 from Maarten Lankhorst m.b.lankhorst@gmail.com 2009-07-28 15:13:46 --- you might as well have reverted this whole patch, this doesn't fix the problem but just goes back to old behavior. I rather have a log to figure out what is going wrong, that will help more than reverting the complete commit.
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #8 from Erich Hoover ehoover@mines.edu 2009-08-05 00:50:06 --- Sorry for the delay - I've been on vacation for a couple weeks, I'll see if I have some time to figure it out this weekend.
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #9 from Erich Hoover ehoover@mines.edu 2009-09-13 00:30:15 --- Created an attachment (id=23564) --> (http://bugs.winehq.org/attachment.cgi?id=23564) Fix DSOUND_BufPtrDiff in Kane's Wrath with new audio pathway
I believe that I've found the issue that causes Kane's Wrath to crash with the new audio pathway. It appears that the buffer position is not being initialized when the buffer is created. So, if someone more knowledgeable wrt. Wine's audio subsystem could make sure that this patch is appropriate then I would greatly appreciate it.
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #10 from Maarten Lankhorst m.b.lankhorst@gmail.com 2009-09-13 05:23:26 --- Since the position in this case is all fake anyway that patch looks fine :) Just send it to wine-patches@winehq.org thanks for catching that bug
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #11 from Andrew Nguyen arethusa26@gmail.com 2009-09-19 15:28:06 --- The patch was committed as 336b0ef18f832aee8766374e636fd3d43b2fd1f1, so this is fixed.
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #12 from Erich Hoover ehoover@mines.edu 2009-09-19 15:31:47 --- (In reply to comment #11)
The patch was committed as 336b0ef18f832aee8766374e636fd3d43b2fd1f1, so this is fixed.
Have you tested it and confirmed that it's fixed for you?
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #13 from Andrew Nguyen arethusa26@gmail.com 2009-09-19 15:59:08 --- Hmm, I don't possess C&C 3 and I don't have PulseAudio installed, so I'm not able to gain first-hand confirmation of the fix. I noticed that the commit was in Git, so I figured it had been fixed, but that may not be the case judging from what you're saying.
http://bugs.winehq.org/show_bug.cgi?id=19369
--- Comment #14 from Erich Hoover ehoover@mines.edu 2009-09-19 16:36:24 --- (In reply to comment #13)
Hmm, I don't possess C&C 3 and I don't have PulseAudio installed, so I'm not able to gain first-hand confirmation of the fix. I noticed that the commit was in Git, so I figured it had been fixed, but that may not be the case judging from what you're saying.
I have tested the fix extensively, but I personally feel more comfortable waiting to resolve a bug until someone else has chimed up and said that it works for them as well.
http://bugs.winehq.org/show_bug.cgi?id=19369
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #15 from Erich Hoover ehoover@mines.edu 2009-10-07 08:25:33 --- Received additional confirmation of resolution via private email.
http://bugs.winehq.org/show_bug.cgi?id=19369
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org 2009-10-09 11:14:18 --- Closing bugs fixed in 1.1.31.