[Bug 23235] New: If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Summary: If Xserver does not suppoer MIT-SHM, log get spammed
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

If Xserver does not support MIT-SHM extension, log is spammed with a lot of

Xlib:  extension "MIT-SHM" missing on display "localhost:11.0".

messages.

It would be better if such message would appear only once.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.2-rc3
           Severity|normal                      |enhancement

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Vitaliy Margolen   2010-06-18 08:52:41 ---
Wine doesn't print this message - xlib does.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
          Component|winex11.drv                 |-unknown

--- Comment #2 from Vitaliy Margolen   2010-06-18 08:53:00 ---
Closing invalid - not Wine bug.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #3 from Adam Klobukowski   2010-06-18 13:52:35 ---
Can't Wine tell xlib not to try to use MIT-SHM if it isn't available?

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #4 from Dmitry Timoshkov   2010-06-19 00:13:49 ---
(In reply to comment #3)
> Can't Wine tell xlib not to try to use MIT-SHM if it isn't available?

Wine doesn't use XSHM when it's not available, probably XLib prints
the warning when Wine just queries for that extension.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #5 from Adam Klobukowski   2010-06-19 00:59:04 ---
Then, wine should not query for it over and over - it will not appear after it
was missing the first time :)

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #6 from Dmitry Timoshkov   2010-06-19 22:45:31 ---
(In reply to comment #5)
> Then, wine should not query for it over and over - it will not appear after it
> was missing the first time :)

It's ridiculous to print loud warnings in the first place when someone just
queries for a feature.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Kenneth Robinette  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Kenneth Robinette  2011-01-30 09:53:47 CST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Then, wine should not query for it over and over - it will not appear after it
> > was missing the first time :)
>
> It's ridiculous to print loud warnings in the first place when someone just
> queries for a feature.

Ah, the dictators at WINE speaks again.  A user reports a problem, and they are
ignored.  Case closed, not a WINE problem.  Really?  Why not look at the
problem report and help resolve it.

I see the same thing, and if you take a few nanoseconds and do a web search,
you will find that this has been around for years.

The only way you can get rid of the thousands of messages flooding the network
regarding the MIT_XSHM not supported message is to configure WINE with:

configure --without-xshm

Who cares whether is ridiculous for X-11 to keep printing the message.  The
point is, it does.  Every program/system involved in this reports back to WINE
that the option MIT-XSHM is NOT SUPPORTED, yet the messages continue to flow.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #8 from Henri Verbeet  2011-01-30 10:42:19 CST ---
Created an attachment (id=33058)
 --> (http://bugs.winehq.org/attachment.cgi?id=33058)
patch

It should be trivial to query for the extension only during initialization, the
attached patch should be enough. I'm not sure I'm convinced this is really
worth changing though.

(In reply to comment #7)
> Ah, the dictators at WINE speaks again.  A user reports a problem, and they are
> ignored.  Case closed, not a WINE problem.  Really?  Why not look at the
> problem report and help resolve it.

Please go troll somewhere else, it's very unhelpful. Besides, bug trackers are
for technical discussion, blogs are for trolling.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #9 from Kenneth Robinette  2011-02-01 11:11:44 CST ---
(In reply to comment #8)
> Created an attachment (id=33058)

--> (http://bugs.winehq.org/attachment.cgi?id=33058) [details]
> patch
> It should be trivial to query for the extension only during initialization, the
> attached patch should be enough. I'm not sure I'm convinced this is really
> worth changing though.
> (In reply to comment #7)
> > Ah, the dictators at WINE speaks again.  A user reports a problem, and they are
> > ignored.  Case closed, not a WINE problem.  Really?  Why not look at the
> > problem report and help resolve it.
>
> Please go troll somewhere else, it's very unhelpful. Besides, bug trackers are
> for technical discussion, blogs are for trolling.

I was not trolling, and this is a technical discussion.  When a subsystem such
as wine send thousands of needless messages over a network, network admin
people tend to get very upset, as they should.

I tested your patch with the latest wine git and am happy to report that it
fixed the problem.  Now all wine based programs run much faster when using X11
remotely and all the needless WINE messages are gone.  Thank you.  Will look
forward to seeing this fixed in the next wine-1.3.13 version.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #10 from Henri Verbeet  2011-02-01 11:29:17 CST ---
(In reply to comment #9)
> I was not trolling, and this is a technical discussion.  When a subsystem such
> as wine send thousands of needless messages over a network, network admin
> people tend to get very upset, as they should.

I think the amount of network traffic generated by the queries would be
insignificant compared to the actual bitmap data. Regardless, that's still
basically an Xlib issue, afaik there's no reason for Xlib to ask the server or
to print that message after the first time for each connection. (And so far I
haven't actually seen any evidence it does communicate with the server for each
query.)

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

--- Comment #11 from Kenneth Robinette  2011-02-01 11:37:00 CST ---
(In reply to comment #10)
> (In reply to comment #9)
> > I was not trolling, and this is a technical discussion.  When a subsystem such
> > as wine send thousands of needless messages over a network, network admin
> > people tend to get very upset, as they should.
>
> I think the amount of network traffic generated by the queries would be
> insignificant compared to the actual bitmap data. Regardless, that's still
> basically an Xlib issue, afaik there's no reason for Xlib to ask the server or
> to print that message after the first time for each connection. (And so far I
> haven't actually seen any evidence it does communicate with the server for each
> query.)

Could be.  All I know is if you configure WINE with --without-xshm the problem
goes away (a fix suggested by someone at codeweavers).  I can submit a problem
report to Apple, but figure they would just laugh.  So I guess we are stuck
with the --without-xshm solution.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED
         Resolution|INVALID                     |FIXED

--- Comment #12 from Austin English  2011-02-02 12:59:21 CST ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=b44bdfd20a4d025483d1bd...

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

http://bugs.winehq.org/show_bug.cgi?id=23235

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2011-02-04 13:20:37 CST ---
Closing bugs fixed in 1.3.13.

[Bug 23235] If Xserver does not suppoer MIT-SHM, log get spammed

https://bugs.winehq.org/show_bug.cgi?id=23235

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |b44bdfd20a4d025483d1bd5bdbf
                   |                            |a1f7b829055f1