[Bug 14901] New: MoveFile fails when used to recase some letters of the filename

Summary: MoveFile fails when used to recase some letters of the filename Product: Wine Version: 1.1.2 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: redneb@mailinator.com

When my program executes the MoveFile windows API function having as arguments two strings that are equal (in a case insensitive way) then MoveFile fails and GetLastError returns 183 (i.e. "File already exists"). For example, assume that the current directory contains a file "foobar". If you run MoveFile("foobar","Foobar") you will get the above error. On the contrary this works fine under windows. Even MoveFile("foobar","foobar") works under windows. I have tested that with 0.9.61/1.1.0/1.1.2 (under Gentoo) and 1.0.0 (under Ubuntu).

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

18 Aug 18 Aug

6:16 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #1 from James Hawkins truiken@gmail.com 2008-08-18 01:16:11 --- Please add a test to the Wine test suite to prove this behavior. See wine/dlls/kernel32/tests/file.c

wine-bugs＠winehq.org

19 Aug 19 Aug

7:15 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #2 from redneb@mailinator.com 2008-08-19 02:15:39 --- Created an attachment (id=15481) --> (http://bugs.winehq.org/attachment.cgi?id=15481) adds an extra test for MoveFileA

wine-bugs＠winehq.org

7:16 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #3 from redneb@mailinator.com 2008-08-19 02:16:19 --- I added a function called test_2_MoveFileA in wine/dlls/kernel32/tests/file.c that should exemplify the problem. I was not able to verify this becauce "make test" fails in other tests earlier. Also this function doesn't test MoveFileW which also has the bug.

wine-bugs＠winehq.org

7:18 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

James Hawkins truiken@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase

--- Comment #4 from James Hawkins truiken@gmail.com 2008-08-19 02:18:29 --- Please add those tests to the existing test_MoveFileA tests then submit the patch to wine-patches. bugzilla is not scanned for patches.

wine-bugs＠winehq.org

7:19 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #5 from James Hawkins truiken@gmail.com 2008-08-19 02:19:13 --- Also note: * no c++ comments * failing tests have to be wrapped in todo_wine, see the rest of the file for examples

wine-bugs＠winehq.org

9:23 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #6 from redneb@mailinator.com 2008-08-19 04:23:03 --- In order to write a proper test it would help if I could run "make test" successfully (when my patch is not applied) so that I can check whether my patch does what it is supposed to. Isn't "make test" supposed to succeed?

wine-bugs＠winehq.org

9:36 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #7 from James Hawkins truiken@gmail.com 2008-08-19 04:36:03 --- Where are you running make test from?

wine-bugs＠winehq.org

10:10 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #8 from redneb@mailinator.com 2008-08-19 05:10:19 ---

From the top directory

wine-bugs＠winehq.org

2:54 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #9 from Austin English austinenglish@gmail.com 2008-08-19 09:54:07 --- (In reply to comment #6)

In order to write a proper test it would help if I could run "make test" successfully (when my patch is not applied) so that I can check whether my patch does what it is supposed to. Isn't "make test" supposed to succeed?

It fails on older window managers/quite a few video cards. Use:

$ make -k test

to ignore failures. Ignore anything in user32/d3d* (unless you changed something there).

wine-bugs＠winehq.org

20 Aug 20 Aug

8:58 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

redneb@mailinator.com changed:

--- Comment #10 from redneb@mailinator.com 2008-08-20 03:58:50 --- Created an attachment (id=15498) --> (http://bugs.winehq.org/attachment.cgi?id=15498) adds an extra test case for MoveFileA

I merged the two functions. In order to check it I used the following command:

../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c

from the wine/dlls/kernel32/tests directory

wine-bugs＠winehq.org

20 Feb 20 Feb

7:34 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #11 from Austin English austinenglish@gmail.com 2009-02-20 13:34:46 --- I sent a modified testcase that was committed today: http://source.winehq.org/git/wine.git/?a=commitdiff;h=68cc3ff120756977c08033...

I'd suggest closing this bug as abandoned/invalid...we've got a testcase for it, so we'll know when the bug is fixed (when the todo_wine is removed). No need to keep a bugzilla bug open for it.

wine-bugs＠winehq.org

9 Mar 9 Mar

6:34 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

redneb@gmx.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |redneb@gmx.com

--- Comment #12 from redneb@gmx.com 2009-03-09 13:34:26 --- (In reply to comment #11)

I sent a modified testcase that was committed today: http://source.winehq.org/git/wine.git/?a=commitdiff;h=68cc3ff120756977c08033...

Your testcase doesn't test the case when letter recasing occurs such as MoveFile("foobar","Foobar")

wine-bugs＠winehq.org

10 Mar 10 Mar

3:45 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #13 from Austin English austinenglish@gmail.com 2009-03-09 22:45:50 --- (In reply to comment #12)

http://www.winehq.org/pipermail/wine-devel/2009-February/073307.html

(In reply to comment #11)

...
I sent a modified testcase that was committed today: http://source.winehq.org/git/wine.git/?a=commitdiff;h=68cc3ff120756977c08033...

Your testcase doesn't test the case when letter recasing occurs such as MoveFile("foobar","Foobar")

wine-bugs＠winehq.org

5:21 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #14 from redneb@gmx.com 2009-03-10 00:21:59 --- (In reply to comment #13)

(In reply to comment #12)

...
(In reply to comment #11)

...
I sent a modified testcase that was committed today: http://source.winehq.org/git/wine.git/?a=commitdiff;h=68cc3ff120756977c08033...

Your testcase doesn't test the case when letter recasing occurs such as MoveFile("foobar","Foobar")

http://www.winehq.org/pipermail/wine-devel/2009-February/073307.html

That's not correct. MoveFile("foobar","Foobar") works just fine under windows (i.e. it's not a noop, it *does* recase the filename). The test should test that case as well.

wine-bugs＠winehq.org

8:12 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com

--- Comment #15 from Austin English austinenglish@gmail.com 2009-03-10 03:12:21 --- I'll take a look.

wine-bugs＠winehq.org

7:29 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Austin English austinenglish@gmail.com changed:

--- Comment #16 from Austin English austinenglish@gmail.com 2009-03-10 14:29:26 --- Created an attachment (id=19866) --> (http://bugs.winehq.org/attachment.cgi?id=19866) testcase

Passes on Wine/2K/XP. Does that test what you want?

wine-bugs＠winehq.org

11 Mar 11 Mar

5:22 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #17 from redneb@gmx.com 2009-03-11 00:22:32 --- (In reply to comment #16)

Created an attachment (id=19866)

--> (http://bugs.winehq.org/attachment.cgi?id=19866) [details]

testcase

Passes on Wine/2K/XP. Does that test what you want?

Yes

wine-bugs＠winehq.org

12 Mar 12 Mar

5:30 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #18 from Austin English austinenglish@gmail.com 2009-03-12 12:30:18 --- (In reply to comment #17)

(In reply to comment #16)

...
Created an attachment (id=19866)

--> (http://bugs.winehq.org/attachment.cgi?id=19866) [details] [details]

...
testcase

Passes on Wine/2K/XP. Does that test what you want?

Yes

There's not really a need to test that...wine already deals with files in a case insensitive way. When the testcase I already submitted is fixed, your case will be as well.

wine-bugs＠winehq.org

14 Mar 14 Mar

8:16 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #19 from redneb@gmx.com 2009-03-14 15:16:41 --- (In reply to comment #18)

(...) wine already deals with files in a case insensitive way (...)

That's where the problem is. Windows has case insensitive filename semantics but MoveFile is case sensitive in some ways. So I wouldn't be surprised if someone fixes your test case but the problem is still there. On the other hand, I don't really know much about the internals of wine so I might be mistaken.

wine-bugs＠winehq.org

16 Mar 16 Mar

5:24 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #20 from Dmitry Timoshkov dmitry@codeweavers.com 2009-03-16 00:24:14 --- (In reply to comment #16)

Created an attachment (id=19866)

--> (http://bugs.winehq.org/attachment.cgi?id=19866) [details]

testcase Passes on Wine/2K/XP. Does that test what you want?

There is no need for such a complicated test, to create an uppercased version of source it's enough to do LCMapString(LCMAP_UPPERCASE, source, dest); and call MoveFile() once again. But you still don't test the result of the the MoveFile() call, that's not just a return value, that's also a file name of the target. That could be accomplished by calling FindFirstFile(source) and comparing the returned buffer with dest (in a case insensitive way).

wine-bugs＠winehq.org

5:26 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #21 from Dmitry Timoshkov dmitry@codeweavers.com 2009-03-16 00:26:56 --- (In reply to comment #20)

(in a case insensitive way).

s/insensitive/sensitive/

i.e. as simple lstrcmp() does.

wine-bugs＠winehq.org

15 Sep 15 Sep

8:34 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #22 from Austin English austinenglish@gmail.com 2009-09-15 15:34:40 --- Is this still an issue in current (1.1.29 or newer) wine?

wine-bugs＠winehq.org

9:47 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #23 from redneb@gmx.com 2009-09-15 16:47:16 --- (In reply to comment #22)

Is this still an issue in current (1.1.29 or newer) wine?

Yes, the bug is still there in commit 4e6db1e18637106aef1f736dad6e9fcd6ff6dc3e.

wine-bugs＠winehq.org

26 May 26 May

8:57 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC|austinenglish@gmail.com |

wine-bugs＠winehq.org

19 Mar 19 Mar

7:52 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #24 from Austin English austinenglish@gmail.com 2012-03-19 14:52:27 CDT --- This is your friendly reminder that there has been no bug activity for 650 days. Is this still an issue in current (1.4 or newer) wine?

wine-bugs＠winehq.org

11:55 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Bruno Jesus 00cpxxx@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com

--- Comment #25 from Bruno Jesus 00cpxxx@gmail.com 2012-03-19 18:55:05 CDT --- Still present as seen in the dupe bug 27084.

wine-bugs＠winehq.org

20 Mar 20 Mar

12:33 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #26 from redneb@gmx.com 2012-03-19 19:33:54 CDT --- Yup, it's still present.

wine-bugs＠winehq.org

26 Apr 26 Apr

3:50 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Bruno Jesus 00cpxxx@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tastky@gmail.com

--- Comment #27 from Bruno Jesus 00cpxxx@gmail.com 2012-04-25 22:50:03 CDT --- *** Bug 27084 has been marked as a duplicate of this bug. ***

wine-bugs＠winehq.org

4:02 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Bruno Jesus 00cpxxx@gmail.com changed:

--- Comment #28 from Bruno Jesus 00cpxxx@gmail.com 2012-04-25 23:02:30 CDT --- Confirming and adding a real application: mp3tag

My original rejected patch to fix this is in http://bugs.winehq.org/attachment.cgi?id=39257

wine-bugs＠winehq.org

12 Nov 12 Nov

11:06 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

tristan hontoir@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |hontoir@gmail.com

--- Comment #29 from tristan hontoir@gmail.com 2012-11-12 05:06:35 CST --- Same problem in foobar2000 v1.1.16 when using "File Operations" > "Move To..."

wine-bugs＠winehq.org

11 Mar 11 Mar

6:54 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Mark K markk@clara.co.uk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |markk@clara.co.uk

--- Comment #30 from Mark K markk@clara.co.uk --- WinUAE is another program affected by this bug; see bug 35772.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

6:55 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #31 from Mark K markk@clara.co.uk --- *** Bug 35772 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2 Oct 2 Oct

12:02 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

super_man@post.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com

--- Comment #32 from super_man@post.com --- patching file dlls/kernel32/path.c Hunk #1 succeeded at 1251 (offset 182 lines). Hunk #2 succeeded at 1272 (offset 182 lines). Hunk #3 succeeded at 1311 (offset 182 lines). Hunk #4 succeeded at 1330 (offset 182 lines).

Bruno's patch still applies 1.7.51

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11 Nov 11 Nov

2:23 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

winetest@luukku.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com

--- Comment #33 from winetest@luukku.com ---

Bruno's patch still applies 1.7.51

patching file dlls/kernel32/path.c Hunk #1 succeeded at 1237 (offset 168 lines). Hunk #2 succeeded at 1258 (offset 168 lines). Hunk #3 succeeded at 1297 (offset 168 lines). Hunk #4 succeeded at 1316 (offset 168 lines).

Against 1.9.22-git.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Nov 16 Nov

4:39 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Sebastian Lackner sebastian@fds-team.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2 Apr 2 Apr

3:20 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Omega Software development@winomega.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |development@winomega.com

--- Comment #34 from Omega Software development@winomega.com --- Created attachment 60965 --> https://bugs.winehq.org/attachment.cgi?id=60965 Bruno's patch from bug 27084 + remove todo_wine

Bruno's patch still works with current Wine. It was missing the removal of todo_wine for MoveFileA test, so adding it here.

Bruno said in bug 27084 that his patch was rejected, but I can't find this in wine-devel archives.

Does anyone know the reason it was rejected?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Jun 1 Jun

4:33 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

André H. nerv@dawncrow.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

14 Oct 14 Oct

7:10 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Alex Henrie alexhenrie24@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

28 Dec 28 Dec

9:46 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #35 from Mathew Hodson mathew.hodson@gmail.com --- https://source.winehq.org/git/wine.git/commitdiff/7edfcd63ada3206b62f4fcee7b...

Is this fixed after this commit?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

29 Dec 29 Dec

12:01 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #36 from redneb@gmx.com --- I wouldn't say it is. While the behavior has now improved, as it does not return an error anymore, you still cannot change the case of the letters of a filename, i.e. you cannot rename "test.txt" to "TEST.TXT". If you try to do that, no error will be reported, but the filename will remain "test.txt".

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4:18 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #37 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to redneb from comment #36)

I wouldn't say it is. While the behavior has now improved, as it does not return an error anymore, you still cannot change the case of the letters of a filename, i.e. you cannot rename "test.txt" to "TEST.TXT". If you try to do that, no error will be reported, but the filename will remain "test.txt".

I'd suggest to create a separate bug report for file name recasing, since MoveFile() no longer fails this bug could be maked as resolved.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

25 Jan 25 Jan

4:25 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Dmitry Timoshkov dmitry@baikal.ru changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathanbelsewir@yahoo.de

--- Comment #38 from Dmitry Timoshkov dmitry@baikal.ru --- *** Bug 46505 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

26 Jan 26 Jan

1:35 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #39 from Dmitry Timoshkov dmitry@baikal.ru --- *** Bug 46505 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11 Mar 11 Mar

1:57 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

--- Comment #40 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Dmitry Timoshkov from comment #37)

I'd suggest to create a separate bug report for file name recasing, since MoveFile() no longer fails this bug could be maked as resolved.

I think bug 46203 would be a good candidate, if I'm not mistaken.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

27 Dec 27 Dec

1:52 a.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename

Gijs Vermeulen gijsvrm@gmail.com changed:

--- Comment #41 from Gijs Vermeulen gijsvrm@gmail.com --- (In reply to Gijs Vermeulen from comment #40)

(In reply to Dmitry Timoshkov from comment #37)

...
I'd suggest to create a separate bug report for file name recasing, since MoveFile() no longer fails this bug could be maked as resolved.

I think bug 46203 would be a good candidate, if I'm not mistaken.

I'll go ahead and mark this FIXED, the recasing issue is tracked in the bug mentioned above.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9:48 p.m.

New subject: [Bug 14901] MoveFile fails when used to recase some letters of the filename