[Bug 10394] New: No$gba Open file dialog non-resizable ( OFN_ENABLESIZING not implemented)
http://bugs.winehq.org/show_bug.cgi?id=10394
Summary: No$gba Open file dialog non-resizable (OFN_ENABLESIZING not implemented) Product: Wine Version: 0.9.49. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: trivial Priority: P2 Component: wine-user AssignedTo: wine-bugs@winehq.org ReportedBy: echidnaman@gmail.com
The "Open file" dialogs of any No$gba builds over version 2.4b do not allow the user to resize the file dialog in Wine. (This feature was added in 2.4c, and works in Windows)
When opening the Open file dialog, the user receives this fixme:
fixme:commdlg:GetFileName95 Flags 0x00800000 not yet implemented
Which tells that OFN_ENABLESIZING isn't implemented.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #1 from Jonathan echidnaman@gmail.com 2007-11-27 10:51:44 --- A dll override will fix this issue, but using the built-in dll also causes some bugs.
http://bugs.winehq.org/show_bug.cgi?id=10394
Jonathan echidnaman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://nocash.emubase.de/no$ | |gba-w.zip Keywords| |download, FIXME OS/Version|other |Linux Platform|Other |PC
http://bugs.winehq.org/show_bug.cgi?id=10394
Jonathan echidnaman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |comdlg32
http://bugs.winehq.org/show_bug.cgi?id=10394
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from Austin English austinenglish@gmail.com 2008-01-28 14:18:35 --- Confirming.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #3 from knipl@in.tum.de 2008-10-28 05:14:01 --- Still in wine 1.1.7.
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami wine-bugzilla6437@diaasami.fastmail.fm changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine- | |bugzilla6437@diaasami.fastma | |il.fm
--- Comment #4 from Diaa Sami wine-bugzilla6437@diaasami.fastmail.fm 2009-01-22 10:38:42 --- I'm new to WINE development and I can see this in the FIXME list, I'm can try fixing this bug(by implementing OFN_ENABLESIZING), Should I give it a shot or wait for confirmation or find another bug to work on?
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #5 from Austin English austinenglish@gmail.com 2009-01-22 12:39:47 --- (In reply to comment #4)
I'm new to WINE development and I can see this in the FIXME list, I'm can try fixing this bug(by implementing OFN_ENABLESIZING), Should I give it a shot or wait for confirmation or find another bug to work on?
If you can do it, then go for it. No one seems to be working on this.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #6 from Diaa Sami diaasami@gmail.com 2009-01-25 08:56:16 --- Created an attachment (id=18982) --> (http://bugs.winehq.org/attachment.cgi?id=18982) An initial patch that makes the Open file dialog resizable
There are several modifications that need to be done, I know, I just wanted to submit an early working patch to see how am I doing as this is my first patch to WINE, so any comments are appreciated.
This enables resizing always, whether OFN_ENABLESIZING is specified or not, this will be fixed, also it affects only the open file dialog.
A good sample for testing is wxwidget's dialogs sample[1], run it then press Ctrl-O.
[1] ftp://biolpc22.york.ac.uk/pub/binary/wxWidgets-WidgetsDemo-Windows.zip
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #7 from Austin English austinenglish@gmail.com 2009-01-25 15:26:59 --- (In reply to comment #6)
Created an attachment (id=18982)
--> (http://bugs.winehq.org/attachment.cgi?id=18982) [details]
An initial patch that makes the Open file dialog resizable
There are several modifications that need to be done, I know, I just wanted to submit an early working patch to see how am I doing as this is my first patch to WINE, so any comments are appreciated.
This enables resizing always, whether OFN_ENABLESIZING is specified or not, this will be fixed, also it affects only the open file dialog.
A good sample for testing is wxwidget's dialogs sample[1], run it then press Ctrl-O.
[1] ftp://biolpc22.york.ac.uk/pub/binary/wxWidgets-WidgetsDemo-Windows.zip
You'd be better off sending it to wine-devel and ask for comments. Patches aren't really looked at here.
Before doing so, though, two comments: A) No C++ comments (//), use /* comment */ instead. B) A testcase would help substantially.
http://bugs.winehq.org/show_bug.cgi?id=10394
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|FIXME |patch
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #8 from Diaa Sami diaasami@gmail.com 2009-01-26 06:34:07 ---
B) A testcase would help substantially.
Does this mean a unit test or a testing scenario?
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18982|0 |1 is obsolete| |
--- Comment #9 from Diaa Sami diaasami@gmail.com 2009-01-26 14:08:44 --- Created an attachment (id=19007) --> (http://bugs.winehq.org/attachment.cgi?id=19007) An improved version of the initial patch
This is an improved version of the initial patch, uses the OFN_ENABLESIZING flag, no C++ comments, no warnings, doesn't use global and static variables.
http://bugs.winehq.org/show_bug.cgi?id=10394
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #10 from Vincent Povirk madewokherd@gmail.com 2009-01-26 15:10:38 --- If ClientToScreenR isn't going to be used, you should remove it. ScreenToClientR and Resize should be declared as static because so they are local to that source file.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #11 from Austin English austinenglish@gmail.com 2009-01-26 16:21:58 --- (In reply to comment #8)
B) A testcase would help substantially.
Does this mean a unit test or a testing scenario?
http://wiki.winehq.org/ConformanceTests http://wiki.winehq.org/WritingConformanceTests
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19007|0 |1 is obsolete| |
--- Comment #12 from Diaa Sami diaasami@gmail.com 2009-01-26 17:09:43 --- Created an attachment (id=19012) --> (http://bugs.winehq.org/attachment.cgi?id=19012) Added support for custom controls
Added support for custom controls. Removed unused code (such as ClientToScreenR) Local functions were declared static.
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19012|0 |1 is obsolete| |
--- Comment #13 from Diaa Sami diaasami@gmail.com 2009-01-28 21:02:39 --- Created an attachment (id=19066) --> (http://bugs.winehq.org/attachment.cgi?id=19066) Updated version of the patch
Added some documentation.
I found that similar resizing code resides in shell/brsfolder.c(for resizing the ShBrowseForFolder dialog) but due to the nature of the code, it can't be reused, probably I will try to modify it to work in both cases.
http://bugs.winehq.org/show_bug.cgi?id=10394
Elias Norberg elno0959@student.su.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |elno0959@student.su.se
--- Comment #14 from Elias Norberg elno0959@student.su.se 2009-01-31 10:18:12 --- I did some work on this earlier - but ran into some problems with bug 13134 - which you've commented on also.
Your patch (sadly) does not fix this either. I might have parts of testcase for this somewhere among my sources, which might help tough.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #15 from Diaa Sami diaasami@gmail.com 2009-02-06 03:11:16 --- Created an attachment (id=19276) --> (http://bugs.winehq.org/attachment.cgi?id=19276) Adds a test for file dialog resizing, succeeds on Windows XP.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #16 from Austin English austinenglish@gmail.com 2009-02-06 18:25:15 --- (In reply to comment #15)
Created an attachment (id=19276)
--> (http://bugs.winehq.org/attachment.cgi?id=19276) [details]
Adds a test for file dialog resizing, succeeds on Windows XP.
You need to wrap wine failures in todo_wine.
Also, no C++ comments.
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19276|0 |1 is obsolete| |
--- Comment #17 from Diaa Sami diaasami@gmail.com 2009-02-07 05:56:36 --- Created an attachment (id=19309) --> (http://bugs.winehq.org/attachment.cgi?id=19309) An improved version of the test patch
I wrapped tests in todo_wine and improved the general structure of the code by adding comments and other minor edits.
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19309|0 |1 is obsolete| |
--- Comment #18 from Diaa Sami diaasami@gmail.com 2009-02-07 09:07:05 --- Created an attachment (id=19312) --> (http://bugs.winehq.org/attachment.cgi?id=19312) Updated tests patch
Sorry, Sent the wrong file last time
http://bugs.winehq.org/show_bug.cgi?id=10394
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase
--- Comment #19 from Austin English austinenglish@gmail.com 2009-02-07 22:36:18 --- (In reply to comment #18)
Created an attachment (id=19312)
--> (http://bugs.winehq.org/attachment.cgi?id=19312) [details]
Updated tests patch
Sorry, Sent the wrong file last time
Fails here: filedlg.c:389: Test succeeded inside todo block: 0-th control wasn't resized horizontally properly filedlg.c:393: Test succeeded inside todo block: 0-th control wasn't resized vertically properly filedlg.c:389: Test succeeded inside todo block: 1-th control wasn't resized horizontally properly filedlg.c:393: Test succeeded inside todo block: 1-th control wasn't resized vertically properly filedlg.c:389: Test succeeded inside todo block: 3-th control wasn't resized horizontally properly filedlg.c:393: Test succeeded inside todo block: 3-th control wasn't resized vertically properly filedlg.c:393: Test succeeded inside todo block: 0-th control wasn't resized vertically properly filedlg.c:393: Test succeeded inside todo block: 1-th control wasn't resized vertically properly filedlg.c:393: Test succeeded inside todo block: 3-th control wasn't resized vertically properly make: *** [filedlg.ok] Error 9
http://bugs.winehq.org/show_bug.cgi?id=10394
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19312|0 |1 is obsolete| |
--- Comment #20 from Diaa Sami diaasami@gmail.com 2009-02-08 18:41:03 --- Created an attachment (id=19340) --> (http://bugs.winehq.org/attachment.cgi?id=19340) Updated tests patch - fails completely with current WINE
Sorry I missed this, now the test fails completely with the current WINE.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #21 from Austin English austinenglish@gmail.com 2009-02-09 10:15:08 --- (In reply to comment #20)
Created an attachment (id=19340)
--> (http://bugs.winehq.org/attachment.cgi?id=19340) [details]
Updated tests patch - fails completely with current WINE
Sorry I missed this, now the test fails completely with the current WINE.
That's fine, as long as it passes on windows. When wine gets fixed, we'll remove the todo's.
Fails for me on XP (didn't test Wine). C:\Documents and Settings\Austin\Desktop>comdlg32_crosstest.exe filedlg filedlg.c:424: Test failed: Couldn't get 2-th child control filedlg: 74 tests executed (0 marked as todo, 1 failure), 0 skipped.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #22 from Diaa Sami diaasami@gmail.com 2009-02-09 11:47:57 ---
That's fine, as long as it passes on windows. When wine gets fixed, we'll remove the todo's.
Fails for me on XP (didn't test Wine). C:\Documents and Settings\Austin\Desktop>comdlg32_crosstest.exe filedlg filedlg.c:424: Test failed: Couldn't get 2-th child control filedlg: 74 tests executed (0 marked as todo, 1 failure), 0 skipped.
I ran it again and it succeeded on my Windows XP, I suspected mingw so I cross-compiled it and on running I got the same error that you got.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #23 from Diaa Sami diaasami@gmail.com 2009-02-09 11:50:59 --- Created an attachment (id=19351) --> (http://bugs.winehq.org/attachment.cgi?id=19351) Minimal independent application that tests dialog resizing
When compiled with VC succeeds and when cross-compiled with MinGW fails.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #24 from Austin English austinenglish@gmail.com 2009-02-09 12:05:27 --- (In reply to comment #23)
Created an attachment (id=19351)
--> (http://bugs.winehq.org/attachment.cgi?id=19351) [details]
Minimal independent application that tests dialog resizing
When compiled with VC succeeds and when cross-compiled with MinGW fails.
Ahh. Might be helpful to file a bug with MinGW.
The tests are built daily with MinGW, so you should aim to get the test to pass there. We don't (yet) support building with VC 9.
http://bugs.winehq.org/show_bug.cgi?id=10394
--- Comment #25 from Rein Klazes wijn@online.nl 2009-05-17 03:11:58 --- Sorry I missed this bug report. The OFN_ENABLESIZING flag is now implemented, but in a simplistic way: just the Browser view is resized, other control's are just moved down- or rightwards to get out of the way.
Your test program is still failing on wine:
cmndlg_test.c:173: Test failed: Couldn't get 2-th child control cmndlg_test.c:148: Test failed: 0-th control wasn't resized horizontally properly cmndlg_test.c:148: Test failed: 3-th control wasn't resized horizontally properly
Dunno about the first failure, happens here on windows XP as well compiled with Visual Studio 6, but the other two can be used for a better resizing fix.
How about submitting your test patch? If you need help let me know.
http://bugs.winehq.org/show_bug.cgi?id=10394
Rein Klazes wijn@online.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #26 from Rein Klazes wijn@online.nl 2009-07-07 10:59:28 --- Fixed by commit:
http://source.winehq.org/git/wine.git/?a=commit;h=c23ccc03d98c73bfc24d1754a3...
http://bugs.winehq.org/show_bug.cgi?id=10394
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #27 from Alexandre Julliard julliard@winehq.org 2009-07-17 12:01:43 --- Closing bugs fixed in 1.1.26.
-
wine-bugs＠winehq.org