[Bug 48170] New: start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

Bug ID: 48170
           Summary: start.exe: /min no longer works
           Product: Wine
           Version: 4.15
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

42fa293d48be89ce06b1aab264c5c0d8cc1b4f53 is the first bad commit
commit 42fa293d48be89ce06b1aab264c5c0d8cc1b4f53
Author: Damjan Jovanovic 
Date:   Sun Aug 11 16:28:50 2019 +0200

start.exe: Search PATH for the executable to launch.

We want to launch all executables through CreateProcess(), but need to
    provide the full path, as the searching CreateProcess() does
    internally when the application name is NULL is more limited: it only
    searches for .EXE files.

Signed-off-by: Damjan Jovanovic 
    Signed-off-by: Alexandre Julliard

before this, `wine start /min notepad` would start notepad minimized. Now, it
appears as a normal window.

Persists in wine-4.20-175-g190fb605c3

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

--- Comment #1 from Damjan Jovanovic  ---
That's unusual, as we check for "/min":

else if (is_option(argv[i], minW)) {
                        sei.nShow = SW_SHOWMINIMIZED;
                }

and set SW_SHOWMINIMIZED into sei.nShow

There are then 2 paths to launch the executable, the ShellExecuteExW() path
which takes the sei, and the CreateProcessW() path, which does convert
sei.nShow into startup_info.wShowWindow:

startup_info.wShowWindow = sei.nShow;

Maybe we also need to set STARTF_USESHOWWINDOW into startup_info.dwFlags?

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |42fa293d48be89ce06b1aab264c
                   |                            |5c0d8cc1b4f53

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

--- Comment #2 from Damjan Jovanovic  ---
(In reply to Damjan Jovanovic from comment #1)
> That's unusual, as we check for "/min":
>             else if (is_option(argv[i], minW)) {
>                     sei.nShow = SW_SHOWMINIMIZED;
>             }
>
> and set SW_SHOWMINIMIZED into sei.nShow
>
> There are then 2 paths to launch the executable, the ShellExecuteExW() path
> which takes the sei, and the CreateProcessW() path, which does convert
> sei.nShow into startup_info.wShowWindow:
>                 startup_info.wShowWindow = sei.nShow;
>
> Maybe we also need to set STARTF_USESHOWWINDOW into startup_info.dwFlags?

That is the case.

Patch sent: https://source.winehq.org/patches/data/174517

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c5bceecb51efc52b315b3526d9a
                   |                            |85f2373e229cc
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Damjan Jovanovic  ---
Patch committed, resolving fixed.

Thank you Austin.

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

--- Comment #4 from Austin English  ---
(In reply to Damjan Jovanovic from comment #3)
> Patch committed, resolving fixed.
>
> Thank you Austin.

Works here as well, thanks Damjan!

[Bug 48170] start.exe: /min no longer works

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48170

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 4.21.