[Bug 7189] VS.NET 2005 fails to install

http://bugs.winehq.org/show_bug.cgi?id=7189

--- Comment #22 from Anastasius Focht   2008-03-02 15:25:03 ---
Hello,

--- quote ---
So I tried the patch A.F. pointed to.  It doesn't apply cleanly today;
I'll attach a rediffed version.  But even with that patch,
the installer says msxml 6 failed to install.
--- quote ---

Of course it doesn't apply/work anymore because James Hawkins is actively
working in this area, doing several code refactoring/rewrites/cleanups.
That's why I refrained from updating my patches in bugzilla for some time.
It would be pointless and short lived ... I and didn't want to hear "I already
have patch in pipeline for xxx".

If you're itchy and don't want to wait for new official patches you can use a
one liner which retrieves the requested installer properties from uninstall key
(certain installer properties get only stored in this place by wine's msi).

--- snip ---

diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index 4ea7b06..481e48f 100644
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -630,7 +630,7 @@ static UINT WINAPI MSI_GetProductInfo(LPCWSTR szProduct,
LPCWSTR szAttribute,
     if (classes)
         MSIREG_OpenLocalSystemProductKey(szProduct, &userdata, FALSE);
     else
-        MSIREG_OpenInstallPropertiesKey(szProduct, &userdata, FALSE);
+        MSIREG_OpenUninstallKey(szProduct, &userdata, FALSE);

if (!lstrcmpW(szAttribute, INSTALLPROPERTY_HELPLINKW) ||
         !lstrcmpW(szAttribute, INSTALLPROPERTY_HELPTELEPHONEW) ||

--- snip ---

Regards