[Bug 21490] New: Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() returns failure

http://bugs.winehq.org/show_bug.cgi?id=21490

Summary: Debug build of Chromium aborts on startup because
                    GdiInitializeLanguagePack() returns failure
           Product: Wine
           Version: 1.1.32
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, patch, source
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This was mentioned in passing in bug 20671.
You can run a debug build of Chromium on Wine with --no-sandbox,
but you have to get GdiInitializeLanguagePack to return success
first, or it will abort early with
[41:42:5571:FATAL:render_process.cc(62)] Check failed: gdi_init_lpk. 
The patch attached to bug 20671 does the trick.

http://m-a-tech.blogspot.com/2009/04/emf-buffer-idiocracy.html
explains why Chrome calls that function; it's needed to make native behave.

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() returns failure

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #1 from Nikolay Sivov   2010-01-25 08:37:47 ---
It looks like Chromium doesn't care about return value:
---
  if (GetModuleHandle(L"LPK.DLL") == NULL) {
    // Makes sure lpk.dll is loaded by gdi32 to make sure ExtTextOut() works
    // when buffering into a EMF buffer for printing.
    typedef BOOL (__stdcall *GdiInitializeLanguagePack)(int LoadedShapingDLLs);
    GdiInitializeLanguagePack gdi_init_lpk =
        reinterpret_cast<GdiInitializeLanguagePack>(GetProcAddress(
            GetModuleHandle(L"GDI32.DLL"),
            "GdiInitializeLanguagePack"));
    DCHECK(gdi_init_lpk);
    if (gdi_init_lpk) {
      gdi_init_lpk(0);
    }
  }
---

It just calls it with zero parameter. Or am I wrong?

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |
            Summary|Debug build of Chromium     |Debug build of Chromium
                   |aborts on startup because   |aborts on startup because
                   |GdiInitializeLanguagePack() |GdiInitializeLanguagePack()
                   |returns failure             |is too stubby?

--- Comment #2 from Dan Kegel   2010-01-25 08:56:02 ---
Aw, poof, you're right.  So maybe we can return failure and make it happy.
In any case, without the patch I gave, it aborts, and with that patch, it runs.

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #3 from Nikolay Sivov   2010-01-25 09:01:13 ---
(In reply to comment #2)
> Aw, poof, you're right.  So maybe we can return failure and make it happy.
> In any case, without the patch I gave, it aborts, and with that patch, it runs.

Don't you mind to send a stub in? It should return 0 and have a FIXME() line in
it.

So this is a blocker for bug 20671?

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #4 from Dan Kegel   2010-01-25 12:49:07 ---
It doesn't block bug 20671 -- that's the release build, this is the debug
build.

I'd love to send in a patch but I'm running ragged, don't have time at the
moment.

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #5 from Nikolay Sivov   2010-01-25 12:51:02 ---
(In reply to comment #4)
> It doesn't block bug 20671 -- that's the release build, this is the debug
> build.
>
> I'd love to send in a patch but I'm running ragged, don't have time at the
> moment.

Ok. I can do this if you don't mind.

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #6 from Nikolay Sivov   2010-01-25 15:10:29 ---
Patch sent:

http://www.winehq.org/pipermail/wine-patches/2010-January/084111.html

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

--- Comment #7 from Nikolay Sivov   2010-01-26 14:58:01 ---
Hi, Dan.

Stub is committed as b3a193a5dd98aeb99c845f1e5c4a1e01abe6e9b0. Is it enough?

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Dan Kegel   2010-01-26 22:05:20 ---
Yes, I'm using it to mark the bug fixed :-)

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

http://bugs.winehq.org/show_bug.cgi?id=21490

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-02-05 11:39:21 ---
Closing bugs fixed in 1.1.38.

[Bug 21490] Debug build of Chromium aborts on startup because GdiInitializeLanguagePack() is too stubby?

https://bugs.winehq.org/show_bug.cgi?id=21490

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b3a193a5dd98aeb99c845f1e5c4
                   |                            |a1e01abe6e9b0
                 CC|                            |[e-mail]