[Bug 57338] New: wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Bug ID: 57338
           Summary: wine-gecko/wine-mono don't cache their installers if
                    using a username with unicode characters
           Product: Wine
           Version: 9.19
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: download, source
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

Noticed while looking at https://github.com/Winetricks/winetricks/pull/2278

I created a test user (`tëstuser`). If I then run Wine under that user, I get a
popup to install wine-mono. The installer downloads and installs wine-mono,
great.

Making a second prefix shows the installer prompt again. The installer doesn't
get cached in ~/.cache/wine (as it does for my normal, ascii-named user).

If the installer is put in /usr/local/share/wine/mono, it gets picked up from
there, as expected.

Which makes me wonder, are unicode characters supported in usernames for wine?
I suspect there may be other lurking issues like this, if so.

FWIW, Windows appears to support it (though various software is broken when
doing so), see https://cornevandriel.com/articles/unicode-in-windows-usernames

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Austin English  ---
Alexandre, could I get your opinion on this, please?

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #2 from Esme Povirk  ---
Saw this error in a log:

0164:warn:appwizcpl:get_cache_file_name L"Z:\home\t\fffdstuser\.cache" does
not exist and could not be created (3)

I think we lost the unicode character when doing getenv() here:
https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/appwiz.cpl/addons.c?r...

Checking in cmd, both XDG_CACHE_HOME and WINEHOMEDIR preserve the character,
and WINEHOMEDIR is set to ??\Z:\home\tëstuser, so clearly this conversion from
a unix path to dos path is possible, but I'm not sure how to do it properly.

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #3 from Esme Povirk  ---
I think ntdll is able to do this with $HOME because it does getenv() on the
unix side. That doesn't really make sense for appwiz.cpl.

I guess maybe we could use wgetenv and convert using UNIXCP?

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #4 from Alexandre Julliard  ---
(In reply to Austin English from comment #1)
> Alexandre, could I get your opinion on this, please?

It should be supported, but there are most likely some bugs here and there.

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #5 from Esme Povirk  ---
Made an MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/7055

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #6 from Austin English  ---
(In reply to Esme Povirk from comment #5)
> Made an MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/7055

Works here, thanks!

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

--- Comment #7 from Rafał Mużyło  ---
Just repeating what I've said in the chat: that mr could use something with
fewer conversion roundtrips - likely something like that bit in init_xdg...

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |164264216d0a6854cb37f92a7e8
                   |                            |abfa480c87784
             Status|NEW                         |RESOLVED

--- Comment #8 from Esme Povirk  ---
MR was merged with the requested changes as
164264216d0a6854cb37f92a7e8abfa480c87784

[Bug 57338] wine-gecko/wine-mono don't cache their installers if using a username with unicode characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57338

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 10.1.