[Bug 41369] New: UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Bug ID: 41369
           Summary: UIAnimation (Windows Animation Manager /
                    UIAnimation.dll) is missing in Wine
           Product: Wine
           Version: 1.9.19
          Hardware: x86
               URL: https://msdn.microsoft.com/en-us/library/windows/deskt
                    op/dd756787(v=vs.85).aspx
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Windows has provided this set of APIs since Win7 (& Vista with Platform
Update).
https://msdn.microsoft.com/en-us/library/windows/desktop/dd756787(v=vs.85).a...

It is need to install and run paint.net v4.x.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #1 from Austin English  ---
(In reply to toe_head2001 from comment #0)
> Windows has provided this set of APIs since Win7 (& Vista with Platform
> Update).
> https://msdn.microsoft.com/en-us/library/windows/desktop/dd756787(v=vs.85).
> aspx
>
> It is need to install and run paint.net v4.x.

Please attach the terminal output.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #2 from [e-mail] ---
Created attachment 55723
  --> https://bugs.winehq.org/attachment.cgi?id=55723
The paint.net installation is looking for UIAnimationManager

err:ole:CoGetClassObject class {4c1fc63a-695c-47e8-a339-1a194be3d0b8} not
registered
err:ole:CoGetClassObject no class object {4c1fc63a-695c-47e8-a339-1a194be3d0b8}
could be created for context 0x1

https://msdn.microsoft.com/en-us/library/windows/desktop/dd317019(v=vs.85).a...

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #3 from [e-mail] ---
Created attachment 55724
  --> https://bugs.winehq.org/attachment.cgi?id=55724
The paint.net installation is looking for UIAnimationManager

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
           Keywords|                            |download, patch
     Ever confirmed|0                           |1

--- Comment #4 from Austin English  ---
https://source.winehq.org/patches/data/126625

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |

--- Comment #5 from Nikolay Sivov  ---
This patch won't make any difference, it doesn't register any objects.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Louis Lenders  ---
*** Bug 38319 has been marked as a duplicate of this bug. ***

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Louis Lenders  ---
Created attachment 61565
  --> https://bugs.winehq.org/attachment.cgi?id=61565
add more interfaces to uianimation.idl

I add two patches here that make installer succeed, and get the program itsself
paint.net passing the required uianimation stuff, (only to run into missing
d2d2-issues) unfortunately.
 This patch is updating uianimation.idl.file

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #8 from Louis Lenders  ---
Created attachment 61566
  --> https://bugs.winehq.org/attachment.cgi?id=61566
uianimation add stub dll

second patch, just followed ``boiler-plate`` recipe from developersguide to add
all required stub interfaces, and returning S_OK for all functions that
Paint.net calls (and crashes if not returning S_OK), and implement a few
``semi-stubs``

I don`t know if I dide things correctly, feedback welcome. As quite some
functions require returning S_OK, and there`s no real implementation, i think
this is not something for upstream wine, but maybe after review and
adjustmensts it could be something for staging?

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #9 from Gijs Vermeulen  ---
(In reply to Louis Lenders from comment #8)

This is just an idea, so it might be terrible:

Maybe it would be a good idea to send the idl, stub dll and stub interfaces
patches to upstream but make everything return E_NOTIMPL (like other stub
interfaces). Then you could put patches to change these E_NOTIMPL to S_OK in
staging to check for regressions. When it is almost certain that the interfaces
faking success don't cause any regressions, then maybe it can be changed
upstream as well.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
          Component|-unknown                    |uiautomationcore

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/uianimation-stub
                   |                            |s

--- Comment #10 from Alistair Leslie-Hughes  ---
I've staged these patches with some minor changes.

The IDL patch is fine but is missing a few v1_enum.

The uianimaton patch should really be broken up into manageable chunks. 
1. Stub DLL
2. Register Interfaces
3. Each Interface in there own patch
4. Any semi-stubs in there own patch
5. Tests

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|uiautomationcore            |-unknown

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

Mark Hatsell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #11 from Louis Lenders  ---
Created attachment 61573
  --> https://bugs.winehq.org/attachment.cgi?id=61573
update idl patch

Hi alistair, thanks for the comments and addition . 
In the idl patch I attached previously  I also forgot the attached additions,
see attached patch. In current state of the idl in staging the  classes don`t
get registered, so Paint.Net still fails to install. Sorry for the extra noise

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #12 from Alistair Leslie-Hughes  ---
(In reply to Louis Lenders from comment #11)
> Created attachment 61573 [details]
> update idl patch
>
> Hi alistair, thanks for the comments and addition . 
> In the idl patch I attached previously  I also forgot the attached
> additions, see attached patch. In current state of the idl in staging the 
> classes don`t get registered, so Paint.Net still fails to install. Sorry for
> the extra noise

Thanks Louis.  I've updated the IDL patch in staging and it will appear when I
push the next lot of changes up.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Fabian Maurer  ---
Latest Paint.NET (https://www.dotpdn.com/files/paint.net.4.2.5.install.zip)
still fails with
> 0033:err:ole:CoGetClassObject class {4c1fc63a-695c-47e8-a339-1a194be3d0b8} not registered

Using wine-staging 4.17 and a fresh WINEPREFIX with dotnet472 installed.

Mind taking a look at that?

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #14 from Louis Lenders  ---
(In reply to Fabian Maurer from comment #13)
> Latest Paint.NET (https://www.dotpdn.com/files/paint.net.4.2.5.install.zip)
> still fails with
> > 0033:err:ole:CoGetClassObject class {4c1fc63a-695c-47e8-a339-1a194be3d0b8} not registered
>
> Using wine-staging 4.17 and a fresh WINEPREFIX with dotnet472 installed.
>
> Mind taking a look at that?

Does patch below help? It creates the mentioned regkey for me
I don`t know enough of the stuff to know if it`s really correct; i just made a
patch that time that helped paint.net to get around the uianimation errors,
maybe Alistair could comment (?)

diff --git a/include/uianimation.idl b/include/uianimation.idl
index 631af11899..70c710cdf8 100644
--- a/include/uianimation.idl
+++ b/include/uianimation.idl
@@ -585,7 +585,8 @@ interface IUIAnimationTransitionLibrary : IUnknown
 library UIAnimation
 {
     [
-        uuid(bfcd4a0c-06b6-4384-b768-0daa792c380e)
+        uuid(bfcd4a0c-06b6-4384-b768-0daa792c380e),
+        threading(both)
     ]
     coclass UIAnimationTimer
     {
@@ -593,7 +594,8 @@ library UIAnimation
     }

[
-        uuid(4c1fc63a-695c-47e8-a339-1a194be3d0b8)
+        uuid(4c1fc63a-695c-47e8-a339-1a194be3d0b8),
+        threading(both)
     ]
     coclass UIAnimationManager
     {
@@ -601,7 +603,8 @@ library UIAnimation
     }

[
-        uuid(8a9b1cdd-fcd7-419c-8b44-42fd17db1887)
+        uuid(8a9b1cdd-fcd7-419c-8b44-42fd17db1887),
+        threading(both)
     ]
     coclass UIAnimationTransitionFactory
     {
@@ -609,7 +612,8 @@ library UIAnimation
     }

[
-        uuid(1d6322ad-aa85-4ef5-a828-86d71067d145)
+        uuid(1d6322ad-aa85-4ef5-a828-86d71067d145),
+        threading(both)
     ]
     coclass UIAnimationTransitionLibrary
     {

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #15 from Alistair Leslie-Hughes  ---
(In reply to Louis Lenders from comment #14)
> (In reply to Fabian Maurer from comment #13)
> > Latest Paint.NET (https://www.dotpdn.com/files/paint.net.4.2.5.install.zip)
> > still fails with
> > > 0033:err:ole:CoGetClassObject class {4c1fc63a-695c-47e8-a339-1a194be3d0b8} not registered
> >
> > Using wine-staging 4.17 and a fresh WINEPREFIX with dotnet472 installed.
> >
> > Mind taking a look at that?
>
> Does patch below help? It creates the mentioned regkey for me
> I don`t know enough of the stuff to know if it`s really correct; i just made
> a patch that time that helped paint.net to get around the uianimation
> errors, maybe Alistair could comment (?)

The patch is good and should be submitted upstream.

The threading model for each of these CoClass's is "both" on windows, which
allows any applications to use these interfaces. As opposed to only an
"apartment" threaded application (which is wine currently).

Currently only staging will register these interfaces.  The remaining
uianimation patches in staging, need to be split up (0002 mostly) before
upstreaming.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

--- Comment #16 from Fabian Maurer  ---
This is fixed as of
https://source.winehq.org/git/wine.git/?a=commit;h=e798001f8621ddcf4fc777ef7...

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e798001f8621ddcf4fc777ef7c1
                   |                            |e788cd3ff4b72
             Status|STAGED                      |RESOLVED
         Resolution|---                         |FIXED

--- Comment #17 from Alistair Leslie-Hughes  ---
Marking as fixed.

Missing Interfaces should be filed as new bugs reports.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  ---
Closing bugs fixed in 4.19.

[Bug 41369] UIAnimation (Windows Animation Manager / UIAnimation.dll) is missing in Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41369

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://msdn.microsoft.com/ |https://web.archive.org/web
                   |en-us/library/windows/deskt |/20150218142643/http://www.
                   |op/dd756787(v=vs.85).aspx   |dotpdn.com/files/paint.net.
                   |                            |4.0.5.install.zip
                 CC|                            |[e-mail]