[Bug 48654] New: Automate checking the WTBS patches

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48654

Bug ID: 48654
           Summary: Automate checking the WTBS patches
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

See bug 48653 for a description of the WTBS and how to check the jobs created
when running it on the TestBot.

Some patches in the WTBS are not meant to create TestBot jobs but rather to
verify that it ignores non-Wine patches, or patches that don't impact the tests
or the Wine build, etc.

Those still create entries in the 'wine-devel' page, that is in the TestBot's
Patches table. Each entry gets the patch subject and a disposition property
indicating what the TestBot did with the patch. Unfortunately non-Wine patches
are not kept around so there is no way to get at the WTBS fields for those. So
a TestWTBS.patches script would need to get the WTBS properties from another
source.

For instance it could be given the path to the WTBS mbox and get the properties
from there. It would not need to understand all the intricacies of the mbox
format (though with the appropriate Perl module it may be easy to parse). As a
last resort, all we would care about is:
* The 'From' lines to delimit emails.
* The 'Subject:' lines to match the mbox emails with Patches entries.
* The WTBS properties in the commit message following the Subject line.

Checking the patch objects would require an extra property:
* WTBS.Patch.Disposition
  This should be set to the expected patch disposition such as 'No patch
found', 'Not a Wine patch', etc. A default disposition could be set if a
'WTBS.Job.*' or other task property is specified.

[Bug 48654] Automate checking the WTBS patches

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48654

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from François Gouget  ---
This is done. See the testbot/tests/TestWTBS commits, starting with:

commit 18965f76c01c7cb6bb2729fea49ca4a24120b704
Author: Francois Gouget 
Date:   Mon Jan 25 14:52:34 2021 +0100

testbot/TestWTBS: Allow checking the patches disposition.

This allows verifying that patches that should not result in a TestBot
    job are indeed ignored for the right reason (aka disposition).

For instance:
    ----- TestWTBS -----
    p patch.Disposition Does not impact the Wine build
    ----- TestWTBS -----

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 48654] Automate checking the WTBS patches

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48654

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from François Gouget  ---
Closing.