[Bug 53180] New: Would you please implement WinTLS ?

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Bug ID: 53180
           Summary: Would you please implement WinTLS ?
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

aria2 uses WinTLS for https support. But seems currently wine does not support
this feature.

Reproduce:

Download aria2 windows build from
https://github.com/aria2/aria2/releases/download/release-1.36.0/aria2-1.36.0...

unzip and execute:

```
$ wine aria2c.exe --console-log-level=debug https://github.com
0100:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"RC4" not supported

06/19 10:37:58 [INFO] <<--- --- --- ---

06/19 10:37:58 [INFO]   --- --- --- ---

06/19 10:37:58 [INFO]   --- --- --- --->>

06/19 10:37:58 [INFO] aria2 1.36.0

06/19 10:37:58 [INFO] mingw-w64 8.0.0 (alpha) / gcc 10-win32 20210110
  built by  x86_64-pc-linux-gnu
  targeting x86_64-w64-mingw32
  on        Aug 21 2021 17:37:16

06/19 10:37:58 [INFO] Windows 7 (Service Pack 1) (x86_64) (6.1)

06/19 10:37:58 [INFO] zlib/1.2.11 expat/2.4.1 sqlite3/3.36.0 GMP/6.2.1
c-ares/1.17.2 libssh2/1.9.0

06/19 10:37:58 [INFO] Logging started.

06/19 10:37:58 [INFO] Checking configured addresses

06/19 10:37:58 [INFO] Not considered: ::1

06/19 10:37:58 [INFO] Not considered: 127.0.0.1

06/19 10:37:58 [INFO] Found configured address:
2409:8a70:9c8:c620:6cdc:8f41:b638:5d4f

06/19 10:37:58 [INFO] Not considered: fe80::2a66:3ae2:70a0:cb25%wlp1s0

06/19 10:37:58 [INFO] Found configured address: 192.168.50.196

06/19 10:37:58 [INFO] IPv4 configured=1, IPv6 configured=1

06/19 10:37:58 [NOTICE] Downloading 1 item(s)

06/19 10:37:58 [DEBUG] 1 RequestGroup(s) added.

06/19 10:37:58 [DEBUG] CUID#7 - socket: read:0, write:0, hup:0, err:0

06/19 10:37:58 [DEBUG] Selected from normCands

06/19 10:37:58 [DEBUG] FeedbackURISelector selected https://github.com

06/19 10:37:58 [DEBUG] CUID#7 - socket: read:0, write:0, hup:0, err:0
0100:fixme:iphlpapi:GetBestRoute2 (00000000015612D0, 0, 0000000000000000,
00000000015614B8, 0x00000000, 0000000000B5F3E0, 0000000000B5F3C0): stub

06/19 10:37:58 [INFO] CUID#7 - Resolving hostname github.com

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:0, write:0, hup:0, err:0

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:0, write:0, hup:0, err:0

06/19 10:37:59 [INFO] CUID#7 - Name resolution complete: github.com ->
192.30.255.112

06/19 10:37:59 [INFO] CUID#7 - Connecting to 192.30.255.112:443

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:0, write:0, hup:0, err:0

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:0, write:1, hup:0, err:0

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:0, write:1, hup:0, err:0

06/19 10:37:59 [DEBUG] Creating TLS session

06/19 10:37:59 [DEBUG] TLS Handshaking

06/19 10:37:59 [DEBUG] WinTLS: Starting/Resuming TLS Connect

06/19 10:37:59 [DEBUG] WinTLS: Initializing handshake

06/19 10:37:59 [DEBUG] WinTLS: Writing handshake

06/19 10:37:59 [DEBUG] WinTLS: Reading handshake...

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:1, write:0, hup:0, err:0

06/19 10:37:59 [DEBUG] WinTLS: Starting/Resuming TLS Connect

06/19 10:37:59 [DEBUG] WinTLS: Reading handshake...

06/19 10:37:59 [DEBUG] WinTLS: Continuing with handshake

06/19 10:37:59 [DEBUG] WinTLS: Writing handshake

06/19 10:37:59 [DEBUG] WinTLS: Reading handshake...

06/19 10:37:59 [DEBUG] CUID#7 - socket: read:1, write:0, hup:0, err:0

06/19 10:37:59 [DEBUG] WinTLS: Starting/Resuming TLS Connect

06/19 10:37:59 [DEBUG] WinTLS: Reading handshake...
0100:fixme:secur32:schan_QueryContextAttributesA Unhandled attribute 0x64

06/19 10:37:59 [INFO] WinTLS: connected with: Unknown
0100:fixme:secur32:schan_QueryContextAttributesA Unhandled attribute 0x64
Assertion failed: 0, file WinTLSSession.cc, line 798
```

[Bug 53180] Would you please implement WinTLS ?

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Feng Yu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |bcrypt
            Version|unspecified                 |7.11

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
            Summary|Would you please implement  |aria2 needs
                   |WinTLS ?                    |QueryContextAttributes(SECP
                   |                            |KG_ATTR_CIPHER_INFO) to
                   |                            |return a valid version
          Component|bcrypt                      |secur32

--- Comment #1 from Zeb Figura  ---
WinTLS seems to be an internal name for the software's Windows TLS backend.
Fortunately the source code makes it quite easy to determine the underlying
cause of the bug.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

--- Comment #2 from Feng Yu  ---
Yeah. The error code line is:
https://github.com/aria2/aria2/blob/release-1.36.0/src/WinTLSSession.cc#L798

A2_LOG_INFO(
        fmt("WinTLS: connected with: %s", getCipherSuite(&handle_).c_str()));
    switch (getProtocolVersion(&handle_)) {
    case 0x302:
      version = TLS_PROTO_TLS11;
      break;
    case 0x303:
      version = TLS_PROTO_TLS12;
      break;
    default:
      assert(0);
      abort();
    }

Seems getCipherSuite(&handle_).c_str()) returns unknown in Wine.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

--- Comment #3 from Hans Leidekker  ---
(In reply to Feng Yu from comment #2)
> Seems getCipherSuite(&handle_).c_str()) returns unknown in Wine.

It's using SECPKG_ATTR_CIPHER_INFO, which is unimplemented. I'll take a look.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                URL|                            |https://web.archive.org/web
                   |                            |/20220602124911if_/https://
                   |                            |objects.githubusercontent.c
                   |                            |om/github-production-releas
                   |                            |e-asset-2e65be/1116542/7e54
                   |                            |5693-c86e-4ff0-9dc5-cc56882
                   |                            |146f7?X-Amz-Algorithm=AWS4-
                   |                            |HMAC-SHA256&X-Amz-Credentia
                   |                            |l=AKIAIWNJYAX4CSVEH53A%2F20
                   |                            |220602%2Fus-east-1%2Fs3%2Fa
                   |                            |ws4_request&X-Amz-Date=2022
                   |                            |0602T124905Z&X-Amz-Expires=
                   |                            |300&X-Amz-Signature=6eb89cb
                   |                            |53e9d3f6c44e39991f64628c3db
                   |                            |e69e332fbadd4fb00ccc739c6f2
                   |                            |90d&X-Amz-SignedHeaders=hos
                   |                            |t&actor_id=0&key_id=0&repo_
                   |                            |id=1116542&response-content
                   |                            |-disposition=attachment%3B%
                   |                            |20filename%3Daria2-1.36.0-w
                   |                            |in-64bit-build1.zip&respons
                   |                            |e-content-type=application%
                   |                            |2Foctet-stream

--- Comment #4 from Gijs Vermeulen  ---
Confirming and adding stable download.

$ sha1sum aria2-1.36.0-win-64bit-build1.zip
5bdaf191639816590bba08d4b6da306fb3c4c905  aria2-1.36.0-win-64bit-build1.zip

$ du -sh aria2-1.36.0-win-64bit-build1.zip
2,4M    aria2-1.36.0-win-64bit-build1.zip

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

--- Comment #5 from Feng Yu  ---
Any update? Is there any plans to fix this issue ?

Thanks.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |99e2f4caca474d14efd55e6a008
                   |                            |bd57c720e0fd7
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Hans Leidekker  ---
(In reply to Feng Yu from comment #5)
> Any update? Is there any plans to fix this issue ?

It should be fixed with 99e2f4caca474d14efd55e6a008bd57c720e0fd7.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 7.12.

[Bug 53180] aria2 needs QueryContextAttributes(SECPKG_ATTR_CIPHER_INFO) to return a valid version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53180

--- Comment #8 from Feng Yu  ---
Great. With the latest 7.12, confirmed this issue fixed. Thanks.